Update package:web_benchmarks dep.#8530
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Nov 15, 2024
ditman:update-web-benchmarks-pkg
Merged
Update package:web_benchmarks dep.#8530auto-submit[bot] merged 1 commit intoflutter:masterfrom ditman:update-web-benchmarks-pkg
auto-submit[bot] merged 1 commit intoflutter:masterfrom
ditman:update-web-benchmarks-pkg
Conversation
elliette
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is in preparation of the removal of
--web-renderer=html.WebRendererenum. packages#8103 (tooling change to remove the parameter from the benchmark runner)Tests
In this case, CI should continue normally. The change is just adopting a new major version of
package:web_benchmarksthat removed some public API (that wasn't used in devtools).Pre-launch Checklist
///).If you need help, consider asking for help on Discord.