You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 21, 2025. It is now read-only.
@chinmaygarde Looks like the the overlaid __config_site file was added in #588. Are we manually rolling from an upstream source? If so, we probably want to avoid patching it here in order to avoid it getting stomped on the next roll. Maybe cleaner to add the define in a globally used config in GN instead.
The intent here is to get our config closer to the google3 config. We recently had an internal-only breakage b/262764490 (fix) due to a missing #include <vector> that was transitively included.
Would be nice to eventually add iwyu to the lint, but this at least covers libcxx includes.
__config_site is part of Flutter's buildroot and is not copied from any upstream source. It contains customized flags for configuring Flutter's use of libcxx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it easier to spot missing includes causing problems on internal builds such has flutter/engine#38332.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.