Repository navigation
Add and default to Hybrid composition on Android - #916
Conversation
|
Would this cause issues on android 9 below if the useHybridComposition is not set to false? if yes it might be a good idea to set the default based on the android version here - and not have user miss it and wonder why its broken for some devices. |
|
@yoavrofe any updates? |
|
I agree that this would be better. However, determining the Android version requires native code or an external package, and is asynchronous, so it may add to the complexity of the library. I personally decided to do it when initializing my app. |
|
@yoavrofe The asynchronous nature makes this much harder indeed. I also checked for hybrid composition for android <= 9 - it seems to just cause a slight reduction in performance. So lets get this merged - can you run flutter format? Might also be great if you could add some short documentation on the use of hybrid composition to the readme. |
* fixed issue with android:exported
felix-ht
left a comment
There was a problem hiding this comment.
I did the formatting and added code to the the composition mode in the example
|
I am getting really weird behaviour, seemingly after this PR. |
|
@aaverin hard to say - you can just turn of hybrid composition to check if this is the cause |
Using Virtual Display on Android 12 may lead to problems.
This PR adds and defaults to [Hybrid Composition](Hybrid Composition). The problem I noticed doesn't exist when Hybrid Composition is used.
I suggest using Hybrid Composition for android 10 and above, and setting
MapboxMap.useHybridComposition=falseon Android 9 and below.This is the default also on the Google Maps plugin maintained by the Flutter team, although there's an error there where the property useAndroidViewSurface is reversed.