Skip to content
This repository was archived by the owner on Sep 1, 2025. It is now read-only.

feat(build): #944 doas make#945

Merged
kamadorueda merged 1 commit intofluidattacks:mainfrom
kamadorueda:main
Sep 30, 2022
Merged

feat(build): #944 doas make#945
kamadorueda merged 1 commit intofluidattacks:mainfrom
kamadorueda:main

Conversation

@kamadorueda
Copy link
Contributor

@kamadorueda kamadorueda commented Sep 30, 2022

  • We cannot make the container fully non-root, but we can make makes run as makes.
  • Expose this feature under a feature flag, since it has a small performance hit at the beginning while chown-ing /nix and also allowing us to test this without much risk

@kamadorueda
feat(build): fluidattacks#944 doas make
3b69cc8 
- We cannot make the container fully non-root,
  but we can make makes run as makes.
- Expose this feature under a feature flag,
  since it has a small performance hit
  at the beginning while chown-ing /nix
  and also allowing us to test this without
  much risk
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kamadorueda kamadorueda merged commit 120ea38 into fluidattacks:main Sep 30, 2022
github-actions bot added a commit that referenced this pull request Sep 30, 2022
@github-actions
Merge pull request #945 from kamadorueda/main
cc3446b 
feat(build): #944 doas make
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kamadorueda