Skip to content
This repository was archived by the owner on Sep 1, 2025. It is now read-only.

feat(back): #1343 deprecate args git fetchers#1344

Merged
dsalaza4 merged 1 commit intofluidattacks:mainfrom
rohaquinlop:issue-1343
Jun 26, 2024
Merged

feat(back): #1343 deprecate args git fetchers#1344
dsalaza4 merged 1 commit intofluidattacks:mainfrom
rohaquinlop:issue-1343

Conversation

@rohaquinlop
Copy link
Contributor

  • Remove fetchGithub and fetchGitlab from the agnostic.nix file.
  • Replace fetchGithub and fetchGitlab with builtins.fetchTarball in the fetch-nix,
    lint-git-mailmap and
    secure-kubernetes-with-rbac-police args.
  • Update the fetchers documentation.
  • The only fetchGit in the project is in the src/nix/sources.nix file, which is generated by
    Niv.

- Remove `fetchGithub` and `fetchGitlab` from
the agnostic.nix file.
- Replace `fetchGithub` and `fetchGitlab` with
`builtins.fetchTarball` in the `fetch-nix`,
`lint-git-mailmap` and
`secure-kubernetes-with-rbac-police` args.
- Update the fetchers documentation.
- The only `fetchGit` in the project is in the
`src/nix/sources.nix` file, which is generated by
Niv.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
Copy link
Contributor

@dsalaza4 dsalaza4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dsalaza4 dsalaza4 merged commit 0fb94bc into fluidattacks:main Jun 26, 2024
@rohaquinlop rohaquinlop deleted the issue-1343 branch June 26, 2024 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants