Improve Touch (Part 1 - Timestamps) - #282
Conversation
…stamp, move MotionEvent to bottom, merge switch cases,
…DL implementation
Co-Authored-By: rikner <rikner@web.de>
| return firstExistingEvent | ||
| } else { | ||
| // No matching event found, creating a new one | ||
| return UIEvent(touch: newTouch) |
There was a problem hiding this comment.
something about this implementation broke last I looked at it - which is why I started implementing proper multitouch.
this is half implementing multitouch because it pays attention to touchId - for this to work in a minimal implementation we need to remove that and always assume touchId == 0
|
@rikner it would be awesome if you could provide an update whether this is still relevant, still builds, and still works as expected. From looking quickly at the code it seems like we should be able to merge this 👍 |
|
@ephemer Yeah, I will take care of this very very soon. |
|
@ephemer merged master and tested this on my phone. velocity scrolling now reliably works and I also compared the CPU usage with the master branch, which was exactly the same 👍 |
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=========================================
Coverage ? 51.16%
=========================================
Files ? 87
Lines ? 3223
Branches ? 0
=========================================
Hits ? 1649
Misses ? 1574
Partials ? 0
Continue to review full report at Codecov.
|
|
@janek 💯 |
4 participants
Fixes #217
Type of change:
Motivation (current vs expected behavior)
SDL's touch handling makes it impossible to get accurate timestamps on events, which breaks our velocity scrolling and causes other weird behaviour.
Also manually tested on my Android phone 👍
Please check if the PR fulfills these requirements