fix(imap): close debug log file handle to prevent fd leak#525
Merged
Conversation
Fixes floatpane#504\n\nconnectWithOptions() was opening a new file handle for DEBUG_IMAP on every connection but never closing it, leaking a fd each time. moved the open into a sync.Once so theres one shared handle for the process lifetime.
Member
|
@sueun-dev thank you for your contribution! Please, run |
Signed-off-by: drew <me@andrinoff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #504
connectWithOptions()was opening a new debug log file handle every time an IMAP connection was created whenDEBUG_IMAPis set, but never closing it. over time this leaks a file descriptor per connection (fetches, IDLE reconnects, etc).moved the
os.OpenFilecall into async.Onceso theres one shared handle for the entire process lifetime. the helpergetDebugIMAPWriter()returns the cachedio.Writeror nil if the env var isnt set.pretty straightforward fix, lmk if theres anything I missed