Skip to content

feat: add termimage#1366

Merged
andrinoff merged 6 commits into
floatpane:masterfrom
andrinoff:feat/termimage
May 27, 2026
Merged

feat: add termimage#1366
andrinoff merged 6 commits into
floatpane:masterfrom
andrinoff:feat/termimage

Conversation

@andrinoff
Copy link
Copy Markdown
Member

@andrinoff andrinoff commented May 27, 2026

What?

Replaces our image rendering with floatpane/termimage

Why?

termimage was built to be a more secure way to show an image without the worry of harming your computer.

@andrinoff
feat: add termimage
5e616b2 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot floatpanebot added enhancement New feature or request dependencies Dependency updates area/tui Terminal UI / view layer area/build Build system / Makefile / packaging size/XL Diff: 800+ lines labels May 27, 2026
@andrinoff
Copy link
Copy Markdown
Member Author

andrinoff commented May 27, 2026 •
edited by floatpanebot
Loading

❌ CI failed

Commit: c0cc0a6 · run logs

Failed jobs:

@andrinoff
fix up and bump
40b2d09 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot
Copy link
Copy Markdown
Member

floatpanebot commented May 27, 2026

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff
docs: add attribution
55d0304 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot floatpanebot added the area/docs Docs site / README label May 27, 2026
@floatpanebot
Copy link
Copy Markdown
Member

floatpanebot commented May 27, 2026

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff andrinoff marked this pull request as ready for review May 27, 2026 14:27
@andrinoff andrinoff requested a review from a team as a code owner May 27, 2026 14:28
@andrinoff
format
ffb67b3 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot
Copy link
Copy Markdown
Member

floatpanebot commented May 27, 2026

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff
fix: satisfy linter
9c8025e 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot
Copy link
Copy Markdown
Member

floatpanebot commented May 27, 2026

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff
tidy
5425b59 
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot
Copy link
Copy Markdown
Member

floatpanebot commented May 27, 2026

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@andrinoff
Copy link
Copy Markdown
Member Author

andrinoff commented May 27, 2026

tests are valid. GitHub bugs.

@andrinoff
Copy link
Copy Markdown
Member Author

andrinoff commented May 27, 2026

/approve

floatpanebot
floatpanebot approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @andrinoff via /approve command.

@andrinoff andrinoff merged commit c0cc0a6 into floatpane:master May 27, 2026
21 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@floatpanebot floatpanebot floatpanebot approved these changes

Assignees

No one assigned

Labels

area/build Build system / Makefile / packaging area/docs Docs site / README area/tui Terminal UI / view layer dependencies Dependency updates enhancement New feature or request size/XL Diff: 800+ lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrinoff @floatpanebot