feat(roles): five coding-agent personas (D3 #37 reopened) - #39
Merged
Conversation
The five coding-agent personas (D3 follow-up) reference six skills that did not exist on disk: code_review, code_generation, test_generation, test_execution, security_scan, dependency_audit. Each ships: * skills/<name>/skill.yaml — LOW-risk manifest, adapter_class StubCodingSkill, domain_id software_engineering or security_audit (per the receptor model in docs/SUBAGENT_COMMUNICATION.md). * skills/<name>/adapter.py — pass-through StubCodingSkill that round-trips the LLM-supplied text and tags it with the skill_id for audit attribution. The skills are governance-only stubs. The LLM still does the actual work via its natural-language output; the skill registry contributes: * Cat-A A-017 enforcement (skill ceiling + allow-list). * Audit anchor on TASK_COMPLETE.invocations. * skill_in_use column on the cluster panel (PR #29). Replacing each adapter with a real linter / static-analysis / pytest backend is a separate hardening track. Tests — tests/test_stub_skills.py (10 cases): * All six manifests load via SkillRegistry.load_from. * All six are LOW risk (default MEDIUM ceiling accepts them). * Adapter round-trips input text per skill_id (parametrised). * Per-skill module isolation — each adapter resolves to its own manifest's skill_id. * Domain-id alignment matches the receptor-filter expectations. 110 passed across PR-26..30 + new module on the local sweep. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Specialist personas for cluster fan-out — each is a narrowed coding_agent with distinct system prompt, default skill set, estimator config, and eval rubric. Designs from docs/CODING_AGENT_SUBROLES.md. New role directories under roles/: * coding_agent_architect — single-instance interface designer. Estimator: fixed count=1. Default skill: code_review. Pattern B (knowledge-share fan-in) — publishes draft_interface. * coding_agent_implementer — multi-instance code writer. Estimator: heuristic base=1, per_n_tokens=1500, cap=4 + difficulty bumps for 'concurrency' and 'refactor'. Default skill: code_generation. * coding_agent_reviewer — single-instance verdict author. Estimator: fixed count=1. Default skills: code_review + security_scan. Carries security_audit receptor. * coding_agent_tester — multi-instance test author + runner. Estimator: heuristic base=1, per_n_tokens=3000, cap=3 + security difficulty bump. Default skills: test_generation, test_execution. * coding_agent_dependency — single-instance CVE / license auditor. Estimator: fixed count=1. Default skills: dependency_audit, security_scan. Carries security_audit receptor. Each persona carries: * role.md — operator-facing markdown source (lints clean). * role.yaml — canonical compiled YAML. * system_prompt.md — distinct prompt that includes the persona's cancellation behaviour. * eval_rubric.yaml — weights sum to 1.0, security ≥ 10% (mirrors the schema invariant pinned for the bare coding_agent). Tests — tests/test_coding_agent_personas.py (32 cases — 5 personas × 6 invariants each + 2 cross-persona): * role.md lints clean (5). * role.yaml loads via RoleLoader with the right estimator block + max_parallel_tasks (5). * default_skills ⊆ allowed_skills (5). * default_skills resolve in the live skill registry — D4 prerequisite (5). * Rubric weights sum to 1.0 (5). * Rubric security weight ≥ 10% (5). * Reviewer + dependency_auditor carry security_audit receptor (1). 131 passed across the related test sweep. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
flg77
added a commit
that referenced
this pull request
May 31, 2026
…tor-repurpose, compliance-multikind, sub-collective-editor (2026-05-31) Five OpenSpec proposals authored during the 2026-05-30 / 2026-05-31 brainstorm waves. All five carry the same shape: phase 1 purely additive, later phases gated on operator review or sibling proposals. 1. `20260530-acc-dreaming-agent` — out-of-band memory consolidation role (analogue of Anthropic Dreaming, May 2026). Phase 1 observation- only: M5 (centroid recompute) + M8 (poisoning detection) + M10 (markdown export) + M11 (convergent-workflow) + M12 (preference extraction). Six lifted safety invariants from Anthropic's design. Brainstorm: `Notes/.../ACC-Dreaming/`. 2. `20260531-acc-role-package-format` — versioned signed `.accpkg` packages + community hub. Phase 1 format spec + reference CLI. Maturity ladder (alpha/beta/stable/hardened); cosign+SPIFFE trust; edge specialist mode after Phase 3 substrate slim. Brainstorm: `Notes/.../ACC-Role-Format/`. 3. `20260531-orchestrator-repurpose-skills-mcp-specialist` — closes followup #37. Orchestrator stops competing with Assistant on routing and starts answering "what's available?" — owns the collective's capability catalog. Phase 1 catalog + capability.query subject (read-only). Brainstorm: `Notes/.../ACC-Orchestrator-Repurpose/`. 4. `20260531-compliance-pane-multikind-consolidation` — closes followup #39. Compliance pane now carries six oversight kinds undifferentiated; Phase 1 adds a `kind` discriminator on `OversightItem` + three sub- tabs (Approvals / Audit / Diagnostics). Brainstorm: `Notes/.../ACC-Compliance-Pane-Multikind/`. 5. `20260531-managed-sub-collectives-typed-editor` — closes followup #42. AoA-P3a's `managed_sub_collectives` dict gains a typed editor sub-tab on the Ecosystem Agentset surface (Roster · Sub-collectives · Raw YAML). Phase 1 local roles only; Phase 4 rides role-package marketplace; Phase 5 rides orchestrator's CapabilityIndex. Brainstorm: `Notes/.../ACC-Subcollective-Editor/`. Cross-proposal dependencies (each implementable in isolation; ride deps checked at gate, not in code): - Orchestrator's RECOMMEND_* kind → Compliance Multi-Kind registers it - Dreamer's DREAM_REPORT kind → Compliance Multi-Kind registers it - Sub-Collective Editor Phase 4 → Role-Package Format Phase 4 - Sub-Collective Editor Phase 5 → Orchestrator Repurpose Phase 1 - Orchestrator Phase 5 → Role-Package Format Phase 4 - Orchestrator Phase 6 → Dreamer Phase 5 (M9) Each proposal has a matching brainstorm folder in the Obsidian vault with the operational reasoning (annotated bibliography, open questions, operator-facing UX sketches) preserved. Tracker: followup-acc.md — #37, #39, #42 marked CLOSED with proposal links; #38 documented (no fix), #40 gated on A2A Phase 3, #41 doc-sync already applied. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
flg77
added a commit
that referenced
this pull request
Jun 8, 2026
Stage 2 cutover: remove 43 movable roles from in-tree
flg77
added a commit
that referenced
this pull request
Jun 29, 2026
…cryptography (#141) Resolves the Python (pip) Dependabot alerts on flg77/acc-spearhead. Most were a stale uv.lock (last generated 2026-06-14) whose pins lagged the already-permissive pyproject constraints; one needed a constraint widening. Lockfile refresh (constraints already allowed the fix — `uv lock --upgrade-package`): aiohttp 3.14.0 → 3.14.1 (#15-22, 8 alerts) pyjwt 2.12.1 → 2.13.0 (#9-13, 5 alerts) starlette 1.0.1 → 1.3.1 (#24-27, 4 alerts; transitive via fastapi) msgpack 1.1.2 → 1.2.1 (#37, high) joserfc 1.6.5 → 1.7.2 (#39; transitive via authlib) Constraint widening (fix was outside the pin): cryptography 46.0.7 → 48.0.1 (#14/#23, two HIGH) — pyproject `<47`→`>=48.0.1,<49`. The Ed25519 arbiter sign/verify API is stable across 46→48; operator "pin and bump" one major at a time. The lock also catches up on the speech/turbovec optional-deps added since 06-14 (faster-whisper/piper-tts/ctranslate2/onnxruntime/av/turbovec) — no security content, just lock/pyproject reconciliation. No downgrades. Not fixed here (separate handling): transformers (#1) — vulnerable `Trainer` not in our execution path; ST<5.0 blocks the 5.0.0rc3 fix → dismissed on GitHub with that reason (intent already in pyproject). torch (#7, low) — no patched release exists → dismissed "no fix available". npm console-plugin (7 alerts) — need npm/node (absent here) → fleet hand-off. Verified with the bumped libs installed: signatures/spiffe 153 ✓, a2a/messenger/ slack/webgui/redis 168 ✓ (321 total, 0 failures). Co-authored-by: flg <flg@acc1.ic3net.internal> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopened — #37 auto-closed when its base branch deleted on merge. 59/59 across personas + stub-skills + arbiter + CLI YAML tests on this branch (which now includes #34 + #35 via main).