Skip to content

add activities when a host is enrolled/unenrolled from MDM - #9127

Merged
roperzh merged 6 commits into
mainfrom
8996-mdm-activities
Dec 28, 2022
Merged

add activities when a host is enrolled/unenrolled from MDM#9127
roperzh merged 6 commits into
mainfrom
8996-mdm-activities

Conversation

@roperzh

@roperzh roperzh commented Dec 27, 2022

Copy link
Copy Markdown
Contributor

#8996

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md)
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • Manual QA for all new/changed functionality

Comment thread cmd/fleet/apple_mdm.go Outdated
@roperzh
roperzh temporarily deployed to Docker Hub December 27, 2022 20:10 — with GitHub Actions Inactive
Comment thread server/datastore/mysql/apple_mdm.go
Comment thread server/fleet/apple_mdm.go
@codecov-commenter

codecov-commenter commented Dec 27, 2022

Copy link
Copy Markdown

Codecov Report

Base: 59.68% // Head: 59.67% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d22285f) compared to base (19ad7cc).
Patch coverage: 38.19% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9127      +/-   ##
==========================================
- Coverage   59.68%   59.67%   -0.01%     
==========================================
  Files         479      479              
  Lines       47343    47451     +108     
==========================================
+ Hits        28257    28318      +61     
- Misses      16422    16461      +39     
- Partials     2664     2672       +8     
Impacted Files Coverage Δ
cmd/fleet/apple_mdm.go 0.00% <0.00%> (ø)
cmd/fleet/serve.go 3.23% <0.00%> (ø)
server/fleet/activities.go 0.00% <0.00%> (ø)
server/fleet/datastore.go 0.00% <ø> (ø)
server/fleet/hosts.go 32.17% <ø> (-0.87%) ⬇️
server/fleet/apple_mdm.go 10.93% <5.12%> (-19.07%) ⬇️
server/datastore/mysql/apple_mdm.go 42.18% <60.00%> (+2.18%) ⬆️
server/datastore/mysql/hosts.go 80.52% <70.58%> (-0.07%) ⬇️
server/datastore/mysql/activities.go 73.01% <100.00%> (+2.84%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread server/fleet/apple_mdm.go
Comment thread server/fleet/apple_mdm.go Outdated
@roperzh
roperzh temporarily deployed to Docker Hub December 28, 2022 00:02 — with GitHub Actions Inactive
@roperzh
roperzh temporarily deployed to Docker Hub December 28, 2022 00:11 — with GitHub Actions Inactive
@roperzh
roperzh temporarily deployed to Docker Hub December 28, 2022 17:45 — with GitHub Actions Inactive
@roperzh
roperzh temporarily deployed to Docker Hub December 28, 2022 17:46 — with GitHub Actions Inactive
@roperzh
roperzh marked this pull request as ready for review December 28, 2022 17:47
@roperzh
roperzh requested a review from a team as a code owner December 28, 2022 17:47

@gillespi314 gillespi314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@roperzh
roperzh merged commit 1b47f9e into main Dec 28, 2022
@roperzh
roperzh deleted the 8996-mdm-activities branch December 28, 2022 19:41
roperzh pushed a commit that referenced this pull request Jan 23, 2023
This is a follow up from #9127 in order to completely omit those fields
from the response instead of returning `null` in order to be consistent
with how the API generally works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants