Windows installer now ensures that legacy osquery installations gets removed during clean install by marcosd4h · Pull Request #9048 · fleetdm/fleet

marcosd4h · 2022-12-16T16:06:01Z

This relates to #8891

This PR introduces Wix custom actions usage

Checklist for submitter

If some of the following don't apply, delete the relevant line.

Changes file added for user-visible changes in changes/ or orbit/changes/.
Manual QA for all new/changed functionality

…removed during clean install

codecov-commenter · 2022-12-16T16:22:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.25%. Comparing base (f5b60b9) to head (d90e07a).
⚠️ Report is 16884 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #9048    +/-   ##
========================================
  Coverage   60.24%   60.25%            
========================================
  Files         472      473     +1     
  Lines       45759    46063   +304     
========================================
+ Hits        27566    27753   +187     
- Misses      15623    15706    +83     
- Partials     2570     2604    +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

michalnicp · 2022-12-16T16:32:32Z

+	}
+
+	if err := ioutil.WriteFile(path, contents.Bytes(), constant.DefaultFileMode); err != nil {
+		return fmt.Errorf("epowershell installer utils file write: %w", err)


nit: spelling

Thanks, just fixed this

michalnicp · 2022-12-16T16:32:45Z

@@ -0,0 +1 @@
+* Windows installer now ensures that installed osquery versio get removed before installing Orbit


nit: spelling

zwass

I'll give the code a more thorough review (only skimmed it so far). Can you please document in the PR description what manual QA steps you went through? For these kinds of complex agent PRs it's really helpful for me to get confidence that we've gone through a thorough set of tests.

marcosd4h · 2022-12-16T18:18:58Z

I'll give the code a more thorough review (only skimmed it so far). Can you please document in the PR description what manual QA steps you went through? For these kinds of complex agent PRs it's really helpful for me to get confidence that we've gone through a thorough set of tests.

Hey @zwass, sure, that's a good point!

I've manually tested the following scenarios. The scenarios3 and scenario4 are the ones that caused issues on the field

Scenario 1 - Clean Orbit installation

Run msiexec /lv loginstall.txt /i <package.msi> to install the package
Manual check that everything is working

Scenario 2 - Clean Orbit uninstallation

Run msiexec /lv loguninstall.txt /x <package.msi> to uninstall the package
Manual check that everything got uninstalled and removed

Scenario 3 - Problematic Scenario - Multiple logged-in users with legacy osquery installation

Create two local users accounts on a Windows machine
Install osquery using one of the users (no previous osquery/orbit installations)
Then login as a different user and try installing Orbit. Without the fix, orbit installation will not succeed. The fix will ensure cleaning up legacy osquery installations and installing Orbit.
Manual check that everything is working

Scenario 4 - Problematic Scenario - Multiple users with legacy osquery installation - Only one user is logged in

Create two local users accounts on a Windows machine
Install osquery using one of the users (no previous osquery/orbit installations)
Reboot
Once the machine is back, login as a different user and try installing Orbit. Without the fix, orbit installation will not succeed. The fix will ensure cleaning up legacy osquery installations and installing Orbit.
Manual check that everything is working

…oving installer_utils.ps1 deployment by removing duplicate

zwass

@marcosd4h besides the logging, this lgtm. If there's a reason for not doing the logging I'm good to merge as-is.

Let's try to merge this today (mergefreeze can be skipped due to bugfix).

zwass · 2022-12-19T19:37:24Z

+        }
+        catch
+        {
+


Can/should we be logging in this and other catch blocks?

@zwass Yes, this is a good point. Console logs are captured and logged by msiexec, so adding log lines here is a good idea. I've just pushed the change to add support for this.

marcosd4h · 2022-12-19T21:10:48Z

@xpkoala This PR adds support for custom action logic on the Windows MSI installer. There is one custom action added here to uninstall old vanilla osquery installs - see scenarios 3 and 4 above. @zwass asked to merge this so the fix can get into the upcoming release and unblock a customer that is having this problem, see #8891. Can you prioritize testing this when having some time available? Let me know if you need helping on setting up your testing environment (win10 box - 2 local accounts - osquery installed by one of the users - orbit installed by the user that did not install osquery)

Windows installer now ensures that legacy osquery installations gets …

aad0e5a

…removed during clean install

marcosd4h requested a review from zwass December 16, 2022 16:06

marcosd4h requested a review from a team as a code owner December 16, 2022 16:06

michalnicp reviewed Dec 16, 2022

View reviewed changes

Fixing cosmetic issues

1eb880e

marcosd4h temporarily deployed to Docker Hub December 16, 2022 17:54 — with GitHub Actions Inactive

zwass reviewed Dec 16, 2022

View reviewed changes

Fixing CI issue by making test to wait for installer completion. Impr…

0b0719e

…oving installer_utils.ps1 deployment by removing duplicate

marcosd4h requested a review from a team December 16, 2022 18:55

marcosd4h temporarily deployed to Docker Hub December 16, 2022 18:55 — with GitHub Actions Inactive

zwass reviewed Dec 19, 2022

View reviewed changes

Addressing code review changes

d90e07a

marcosd4h temporarily deployed to Docker Hub December 19, 2022 20:55 — with GitHub Actions Inactive

marcosd4h requested a review from zwass December 19, 2022 21:10

zwass approved these changes Dec 20, 2022

View reviewed changes

zwass merged commit 605ae86 into main Dec 20, 2022

zwass deleted the 8891-installer-custom-actions branch December 20, 2022 00:06

zwass mentioned this pull request Jan 17, 2023

Orbit cannot be installed on top of legacy Osquery 4.5.1 installations #8891

Closed

Navigation Menu

Uh oh!

Windows installer now ensures that legacy osquery installations gets removed during clean install - #9048

Windows installer now ensures that legacy osquery installations gets removed during clean install#9048
zwass merged 4 commits into
mainfrom
8891-installer-custom-actions

marcosd4h commented Dec 16, 2022

Uh oh!

codecov-commenter commented Dec 16, 2022 •

edited by codecov Bot

Loading

Uh oh!

michalnicp Dec 16, 2022

Uh oh!

marcosd4h Dec 16, 2022

Uh oh!

michalnicp Dec 16, 2022

Uh oh!

marcosd4h Dec 16, 2022

Uh oh!

zwass left a comment

Uh oh!

marcosd4h commented Dec 16, 2022 •

edited

Loading

Uh oh!

zwass left a comment

Uh oh!

zwass Dec 19, 2022

Uh oh!

marcosd4h Dec 19, 2022

Uh oh!

marcosd4h commented Dec 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1 @@
		* Windows installer now ensures that installed osquery versio get removed before installing Orbit

Uh oh!

Conversation

marcosd4h commented Dec 16, 2022

Checklist for submitter

Uh oh!

codecov-commenter commented Dec 16, 2022 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

michalnicp Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

marcosd4h Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

michalnicp Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

marcosd4h Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

zwass left a comment

Choose a reason for hiding this comment

Uh oh!

marcosd4h commented Dec 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zwass left a comment

Choose a reason for hiding this comment

Uh oh!

zwass Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

marcosd4h Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

marcosd4h commented Dec 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Dec 16, 2022 •

edited by codecov Bot

Loading

marcosd4h commented Dec 16, 2022 •

edited

Loading