Flowtest E2E settings - #654
Merged
Merged
Conversation
zwass
reviewed
Apr 16, 2021
zwass
left a comment
zwass
left a comment
Member
There was a problem hiding this comment.
Looks great! Please add the advanced options before merging and then we can do a quick review and have you take a look at the email parts in a fresh PR.
RachelElysia
marked this pull request as ready for review
April 19, 2021 17:05
Member
Author
|
I left a comment about the advance option sliders on line 75 Feel free to add input @zwass Once this is approved, I can rebase the other pull request and move the second test in email.spec.ts into its proper scope, settings.spec.ts (this test) |
RachelElysia
added a commit
to RachelElysia/fleet
that referenced
this pull request
Apr 21, 2021
* Fill out form, pseudocode check updated fields * Create update assertions * Update page before assertions * Start advanced options * Add advance options Co-authored-by: Rachel Elysia Perkins <rachel@fleetdm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done:
Need:
@zwass feel free to add input
Closes #647