Edit label and Add label frontend fixes - #644
Merged
noahtalerman merged 2 commits intoApr 16, 2021
Merged
Conversation
…correct label when cancel add new label
zwass
approved these changes
Apr 16, 2021
RachelElysia
pushed a commit
to RachelElysia/fleet
that referenced
this pull request
Apr 21, 2021
- Moves `isEditLabel` out of `<ManageHostPage />`'s state and into its props. The implementation is now similar to `isAddLabel`. - Add `selectedFilter` to the URL path when editing or adding labels. This helps navigate the user back to the selected label after they click "Cancel" when editing or adding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Edit label" mode, while an interesting idea for power label users, isn't a great experience.
Selecting "Edit" for a particular label and then navigating to a built-in label would result in a "Built-in labels can't be edited" message.
Moves
isEditLabelout of<ManageHostPage />'s state and into its props. The implementation is now similar toisAddLabel.Add
selectedFilterto the URL path when editing or adding labels. This helps navigate the user back to the selected label after they click "Cancel" when editing or adding.Loom demo
https://www.loom.com/share/0f2f81611b3d4893a3dd7815c18a0775?sharedAppSource=team_library
Closes #215
Closes #85