Skip to content

Query Buttons: Export Results and Export Errors - #638

Merged
RachelElysia merged 6 commits into
fleetdm:masterfrom
RachelElysia:export-buttons
Apr 19, 2021
Merged

Query Buttons: Export Results and Export Errors#638
RachelElysia merged 6 commits into
fleetdm:masterfrom
RachelElysia:export-buttons

Conversation

@RachelElysia

@RachelElysia RachelElysia commented Apr 13, 2021

Copy link
Copy Markdown
Member
  • Only show Export Results and Fullscreen Buttons iff query has results and no errors
  • Export Errors Button iff query has errors

Closes #300

Screen Shot 2021-04-16 at 2 21 19 PM

@RachelElysia
RachelElysia requested a review from zwass April 13, 2021 21:30
@RachelElysia
RachelElysia marked this pull request as draft April 13, 2021 21:55
@RachelElysia RachelElysia changed the title Toggle "Export Results" button Query Buttons: Export Results and Export Errors Apr 16, 2021
@RachelElysia
RachelElysia marked this pull request as ready for review April 16, 2021 18:19
Comment thread frontend/components/queries/QueryResultsTable/QueryResultsTable.jsx Outdated
Co-authored-by: noahtalerman <47070608+noahtalerman@users.noreply.github.com>
@zwass

zwass commented Apr 20, 2021

Copy link
Copy Markdown
Member

Looks like the JS linting failed with this PR. No need to revert it, please make a new PR that fixes the lint issues :)

RachelElysia added a commit to RachelElysia/fleet that referenced this pull request Apr 21, 2021
* Fullscreen mode always an option
* Export Results button iff results && no errors
* Export Errors button added

Suggestion added by: @noahtalerman <noah@fleetdm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide export results button and add export errors button when appropriate.

3 participants