Fix built-in Linux labels missing derived distributions - #51249
Fix built-in Linux labels missing derived distributions#51249juan-fdz-hawa wants to merge 3 commits into
Conversation
Resolves #46905 osquery reports a derived distribution's own ID in os_version.platform and lists only its ancestors in platform_like, so Pop!_OS (platform "pop", platform_like "ubuntu debian") matched neither "Ubuntu Linux" nor "Debian-based Linux hosts". - Ubuntu Linux: also match platform_like "%ubuntu%" (Pop!_OS, Linux Mint, Zorin OS, KDE neon). - Fedora Linux: name LIKE "%fedora%" instead of = "Fedora Linux", covering Fedora 33 and earlier, which report name "Fedora". - Debian-based Linux hosts: add platform = 'debian' (Debian reports no platform_like at all) and platform_like "%ubuntu%". - RPM-based Linux hosts: add the SUSE family and Amazon Linux. - Mirror the last two in the all-deb-hosts and all-rpm-hosts reports.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51249 +/- ##
==========================================
+ Coverage 68.77% 68.78% +0.01%
==========================================
Files 4000 4002 +2
Lines 258322 258533 +211
Branches 13704 13704
==========================================
+ Hits 177651 177822 +171
- Misses 64890 64918 +28
- Partials 15781 15793 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4622d74 to
a19af61
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughBuilt-in Linux label queries now recognize Debian, Ubuntu, RHEL, Fedora, and SUSE platform values. Ubuntu and Fedora definitions were updated in test helpers and MySQL data. A MySQL migration applies the updated queries and records the migration. Label templates, reports, fixtures, and datastore tests were synchronized with the new matching rules. Merge Risk: ⚪ Minimal · up to This change broadens built-in Linux label matching for derived distributions; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves #46905
osquery reports a derived distribution's own ID in os_version.platform and lists only its ancestors in platform_like, so Pop!_OS (platform "pop", platform_like "ubuntu debian") matched neither "Ubuntu Linux" nor "Debian-based Linux hosts".
Test matrix:
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing
Summary by CodeRabbit
New Features
Bug Fixes