Skip to content

Fixed slow migration. (#50992) - #50997

Merged
getvictor merged 1 commit into
rc-minor-fleet-v4.91.0from
50933-migration-cherry-pick
Aug 11, 2026
Merged

Fixed slow migration. (#50992)#50997
getvictor merged 1 commit into
rc-minor-fleet-v4.91.0from
50933-migration-cherry-pick

Conversation

@getvictor

Copy link
Copy Markdown
Member

Related issue: Resolves #50933

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes
    files
    for more information.

Testing

  • QA'd all new/changed functionality manually

Summary by CodeRabbit

  • Bug Fixes
  • Improved the performance of database migrations for deployments with many Windows host certificates.
  • Reduced delays when identifying certificates for soft deletion during migration.

(cherry picked from commit 1f923ad)

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #50933

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

## Testing

- [x] QA'd all new/changed functionality manually

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved the performance of database migrations for deployments with
many Windows host certificates.
- Reduced delays when identifying certificates for soft deletion during
migration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit 1f923ad)
@getvictor
getvictor marked this pull request as ready for review August 11, 2026 19:38
@getvictor
getvictor requested a review from a team as a code owner August 11, 2026 19:38
@getvictor getvictor linked an issue Aug 11, 2026 that may be closed by this pull request
2 tasks
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.91.0@9638487). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.91.0   #50997   +/-   ##
=========================================================
  Coverage                          ?   68.53%           
=========================================================
  Files                             ?     3980           
  Lines                             ?   256341           
  Branches                          ?    13816           
=========================================================
  Hits                              ?   175674           
  Misses                            ?    65043           
  Partials                          ?    15624           
Flag Coverage Δ
backend 69.63% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@getvictor
getvictor merged commit e42798c into rc-minor-fleet-v4.91.0 Aug 11, 2026
34 of 36 checks passed
@getvictor
getvictor deleted the 50933-migration-cherry-pick branch August 11, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v4.89.2 -> v4.90.0 -> Long running migration(s)

2 participants