Add Nexus Shell as a macOS Fleet-maintained app - #50822
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds Nexus Shell version 1.6.9 as a maintained macOS application. The change defines Homebrew cask metadata, Darwin installation and uninstallation behavior, catalog registration, cleanup paths, and frontend icon mapping. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #50822 +/- ##
==========================================
- Coverage 68.53% 68.53% -0.01%
==========================================
Files 3977 3978 +1
Lines 256168 256170 +2
Branches 13818 13818
==========================================
+ Hits 175566 175567 +1
- Misses 64982 64983 +1
Partials 15620 15620
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
CI note: the failing No Nexus Shell metadata error is shown by this failed job. I am happy to adjust anything on the PR if maintainers prefer a different approach. |
|
@viewer12 thanks for submitting. I am curious, do you have any plans to get this into homebrew natively without a custom tap? We've submitted these on behalf of developers before if you need help. The only reason I ask is the "custom-tap" that we have created is for apps that can not be in homebrew that our customers have asked for. It doesn't function as a custom tap (like Let me know your thoughts or if you have any questions. |
|
Thanks — yes, I would appreciate help getting Nexus Shell into I had held back because the canonical repository is a small, binary-only releases repository and its raw GitHub notability metrics are low. I have since rechecked the current Acceptable Casks guidance, which notes that those metrics may not represent an application whose repository is used only to host binaries. I understand that this permits review rather than guaranteeing acceptance. The app otherwise follows the cask requirements:
If you prefer, I can open and maintain the native cask PR myself. If submitting it on behalf of the developer is easier for Fleet's workflow, I am happy to provide any metadata or verification you need. For this Fleet PR, waiting for the native cask seems preferable to adding an entry that must be updated manually. Once the cask is accepted, I can update this branch to consume it. |
Summary
Developer disclosure: I maintain Nexus Shell and am submitting this catalog entry transparently.
Verified metadata
1.6.9sameral.Nexus-Shell5MBFAB57U2088938eb901760a3123be7c8df18a41d480f234358a3a56f248de88bcc83a61dTesting
check-jsonschema.git diff --checkpassed.Other checklist sections in the general Fleet PR template do not apply to this maintained-app catalog contribution.
Summary by CodeRabbit