Skip to content

Add Nexus Shell as a macOS Fleet-maintained app - #50822

Open
viewer12 wants to merge 2 commits into
fleetdm:mainfrom
viewer12:codex/add-nexus-shell-fma
Open

Add Nexus Shell as a macOS Fleet-maintained app#50822
viewer12 wants to merge 2 commits into
fleetdm:mainfrom
viewer12:codex/add-nexus-shell-fma

Conversation

@viewer12

@viewer12 viewer12 commented Aug 8, 2026

Copy link
Copy Markdown

Summary

  • Add Nexus Shell as a macOS Fleet-maintained app using the documented custom-tap flow.
  • Include the generated app manifest, inventory/patch queries, install and uninstall scripts, and catalog icon.
  • Track the vendor-hosted, versioned DMG for Apple Silicon Macs.

Developer disclosure: I maintain Nexus Shell and am submitting this catalog entry transparently.

Verified metadata

  • Version: 1.6.9
  • Bundle identifier: sameral.Nexus-Shell
  • Team ID: 5MBFAB57U2
  • Minimum macOS: Sonoma
  • Architecture: Apple Silicon
  • Installer SHA-256: 088938eb901760a3123be7c8df18a41d480f234358a3a56f248de88bcc83a61d
  • Gatekeeper: accepted, notarized Developer ID

Testing

  • Input schema validated with check-jsonschema.
  • Maintained-app Go tests passed.
  • Custom-tap API metadata and FMA output regenerated.
  • Official DMG verified with PlistBuddy, codesign, spctl, and SHA-256.
  • Generated JSON validated and git diff --check passed.
  • QA'd all new/changed functionality manually.

Other checklist sections in the general Fleet PR template do not apply to this maintained-app catalog contribution.

Summary by CodeRabbit

  • New Features
    • Added Nexus Shell to the maintained macOS software catalog.
    • Added support for installing, updating, uninstalling, and cleaning up Nexus Shell version 1.6.9.
    • Added Nexus Shell’s application icon to software listings.
    • Included macOS 14 or later on ARM64 system requirements.
    • Added safeguards to preserve app data during removal by moving related files to the user’s Trash.

@viewer12
viewer12 requested a review from a team as a code owner August 8, 2026 01:35
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c0d6524-5c19-48d1-8676-a3e441fc7de4

📥 Commits

Reviewing files that changed from the base of the PR and between 2ae52cf and d7ca4d3.

📒 Files selected for processing (3)
  • ee/maintained-apps/inputs/homebrew/custom-tap/Casks/nexus-shell.rb
  • ee/maintained-apps/inputs/homebrew/custom-tap/api/nexus-shell.json
  • ee/maintained-apps/outputs/nexus-shell/darwin.json
🚧 Files skipped from review as they are similar to previous changes (3)
  • ee/maintained-apps/inputs/homebrew/custom-tap/api/nexus-shell.json
  • ee/maintained-apps/inputs/homebrew/custom-tap/Casks/nexus-shell.rb
  • ee/maintained-apps/outputs/nexus-shell/darwin.json

Walkthrough

Adds Nexus Shell version 1.6.9 as a maintained macOS application. The change defines Homebrew cask metadata, Darwin installation and uninstallation behavior, catalog registration, cleanup paths, and frontend icon mapping.

Possibly related PRs

  • fleetdm/fleet#50050: Modifies the maintained macOS app catalog and software icon registry with related app registration changes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly states the purpose, scope, verified metadata, testing, and manual QA results for the maintained-app catalog contribution.
Title check ✅ Passed The title clearly identifies the addition of Nexus Shell as a macOS Fleet-maintained app.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.53%. Comparing base (bc537a3) to head (d7ca4d3).

Files with missing lines Patch % Lines
...pages/SoftwarePage/components/icons/NexusShell.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #50822      +/-   ##
==========================================
- Coverage   68.53%   68.53%   -0.01%     
==========================================
  Files        3977     3978       +1     
  Lines      256168   256170       +2     
  Branches    13818    13818              
==========================================
+ Hits       175566   175567       +1     
- Misses      64982    64983       +1     
  Partials    15620    15620              
Flag Coverage Δ
frontend 62.71% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@viewer12

viewer12 commented Aug 8, 2026

Copy link
Copy Markdown
Author

CI note: the failing Validate maintained apps inputs job stops during checkout before validation. The workflow fixes repository: fleetdm/fleet while using ${{ github.head_ref }}, so it looks for codex/add-nexus-shell-fma in the upstream repository instead of the PR head repository (viewer12/fleet). The branch and head commit d7ca4d3 are still available in the fork, and the Darwin maintained-app validation and product-related checks pass.

No Nexus Shell metadata error is shown by this failed job. I am happy to adjust anything on the PR if maintainers prefer a different approach.

@allenhouchins

Copy link
Copy Markdown
Member

@viewer12 thanks for submitting. I am curious, do you have any plans to get this into homebrew natively without a custom tap? We've submitted these on behalf of developers before if you need help.

The only reason I ask is the "custom-tap" that we have created is for apps that can not be in homebrew that our customers have asked for. It doesn't function as a custom tap (like viewer12/tap/nexus-shell), it just tricks our ingesters into thinking its talking to a homebrew tap for apps not supported by homebrew. I can put Nexus Shell there if it must but that means it has to be manually updated every time there is a release versus we can ingest updates automatically from homebrew.

Let me know your thoughts or if you have any questions.

@viewer12

Copy link
Copy Markdown
Author

Thanks — yes, I would appreciate help getting Nexus Shell into homebrew/cask natively.

I had held back because the canonical repository is a small, binary-only releases repository and its raw GitHub notability metrics are low. I have since rechecked the current Acceptable Casks guidance, which notes that those metrics may not represent an application whose repository is used only to host binaries. I understand that this permits review rather than guaranteeing acceptance.

The app otherwise follows the cask requirements:

If you prefer, I can open and maintain the native cask PR myself. If submitting it on behalf of the developer is easier for Fleet's workflow, I am happy to provide any metadata or verification you need.

For this Fleet PR, waiting for the native cask seems preferable to adding an entry that must be updated manually. Once the cask is accepted, I can update this branch to consume it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants