Bump out-of-order migrations not included in v4.90.0 - #50690
Conversation
Two migrations merged to main were not included in the v4.90.0 release but have timestamps older than 20260723181411 (the latest migration shipped in v4.90.0). Databases already on v4.90.0 would never apply them, since goose only runs migrations newer than the current version. Bumped via tools/bump-migration: - 20260721090128_AddTokenInvalidToABMTokens -> 20260806154139 - 20260721160351_AddHostMDMWindowsProfilesStatus -> 20260806154150
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughTwo MySQL migrations now use timestamps Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…r it PR #50690 (open, not yet merged) renames two out-of-order migrations that shipped after the v4.90.0 cut so they sort after it: 20260721090128_AddTokenInvalidToABMTokens -> 20260806154139, and 20260721160351_AddHostMDMWindowsProfilesStatus -> 20260806154150. Cherry-picked that rename here so our migration keeps running last, and bumped 20260804143233_CreateHostMDMAppleDeviceVitals -> 20260806161534 accordingly. Regenerated schema.sql.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #50690 +/- ##
=======================================
Coverage 68.35% 68.35%
=======================================
Files 3957 3957
Lines 254097 254097
Branches 13490 13490
=======================================
+ Hits 173684 173688 +4
Misses 64859 64859
+ Partials 15554 15550 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Two migrations merged to
mainwere not included in the v4.90.0 release but have timestamps older than20260723181411_MultipleCustomPackagesPerTitle(the latest migration shipped in v4.90.0). Databases already on v4.90.0 would never apply them, since goose only runs migrations newer than the current (highest applied) version.Bumped both to current timestamps via
tools/bump-migration:20260721090128_AddTokenInvalidToABMTokens→20260806154139_AddTokenInvalidToABMTokens20260721160351_AddHostMDMWindowsProfilesStatus→20260806154150_AddHostMDMWindowsProfilesStatusNo schema or logic changes — only the file names,
Up_/Down_/TestUp_function names, and the regeneratedschema.sql(migration_status_tablesversions). Verified that none of the other unreleased migrations (20260724+) depend on the schema these two create, so applying them last is safe.Checklist for submitter
If some of the following don't apply, delete the relevant line.
Testing
Database migrations
COLLATE utf8mb4_unicode_ci).Summary by CodeRabbit