Regenerate Fleet Desktop FMA manifests for v1.4.0 - #50674
Conversation
PR #49910 bumped Casks/fleet-desktop.rb to 1.4.0 but never ran regenerate.sh or the ingester, so api/fleet-desktop.json and outputs/fleet-desktop/darwin.json were still on 1.3.4 and still pointed at the old allenhouchins/fleet-desktop GitHub release URL. The .rb bump therefore had no effect on what Fleet serves. Regenerate both from the existing cask. No cask changes. Verified the 1.4.0 installer against the cask stanzas: sha256 matches c920b983..., receipt id com.fleetdm.fleet-desktop matches both the pkgutil: and quit: stanzas, and CFBundleShortVersionString is 1.4.0 (so the patched query won't report a perpetual update).
GitHub Actions
Inactive
Script Diff Resultsee/maintained-apps/outputs/fleet-desktop/darwin.json=== Install // 5d021f75 -> 0341b271 ===
--- /tmp/old.w3gI0W 2026-08-06 13:59:39.988333976 +0000
+++ /tmp/new.Zwpvcp 2026-08-06 13:59:39.988333976 +0000
@@ -96,5 +96,5 @@
# install pkg files
quit_and_track_application 'com.fleetdm.fleet-desktop'
-sudo installer -pkg "$TMPDIR/fleet_desktop-v1.3.4.pkg" -target / || exit $?
+sudo installer -pkg "$TMPDIR/fleet_desktop-v1.4.0.pkg" -target / || exit $?
relaunch_application 'com.fleetdm.fleet-desktop'
=== Uninstall Script (no changes) === |
There was a problem hiding this comment.
Pull request overview
Updates Fleet’s generated Fleet-maintained app (FMA) manifests for Fleet Desktop macOS v1.4.0, ensuring the served installer URL, version checks, and checksums match the current release (and no longer reference the stale GitHub release feed).
Changes:
- Regenerated the Fleet Desktop output manifest (
outputs/.../darwin.json) to v1.4.0 (version, patched query, installer URL, sha256, install script ref). - Regenerated the Homebrew API JSON (
inputs/.../api/fleet-desktop.json) to v1.4.0 (homepage/url/version/sha256/pkg filename, and livecheck skip metadata).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ee/maintained-apps/outputs/fleet-desktop/darwin.json | Updates the served macOS manifest to Fleet Desktop 1.4.0, including the new download.fleetdm.com installer URL and matching checksum/script ref. |
| ee/maintained-apps/inputs/homebrew/custom-tap/api/fleet-desktop.json | Regenerates the Homebrew-derived API JSON so Fleet Desktop 1.4.0 metadata (URL/version/sha/pkg) matches the cask and upstream distribution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughUpdated Fleet Desktop from version 1.3.4 to 1.4.0 in the Homebrew cask and macOS app definitions. Updated release URLs, installer filenames, install script references, version conditions, and SHA-256 checksums. The Homebrew metadata now uses the Fleet repository homepage and disables livecheck. Uninstall references and existing install-script behavior remain unchanged. Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Related issue: NA — follow-up to #49910
What changed
Regenerates
api/fleet-desktop.jsonandoutputs/fleet-desktop/darwin.jsonfor Fleet Desktop v1.4.0. No cask changes.Why
#49910 bumped
Casks/fleet-desktop.rbto 1.4.0 but never ranregenerate.shor the ingester, so the generated manifests — the files Fleet actually serves — were still on 1.3.4 and still pointed at the oldallenhouchins/fleet-desktopGitHub release URL. That release feed is stale (it stops at v1.3.4); 1.4.0 is hosted atdownload.fleetdm.com. The.rbbump had no effect in production, and nothing in CI catches this kind of drift.This was found during a routine custom-tap maintenance pass. All four casks (druva-insync, fleet-desktop, xcreds, zoom-rooms) are at their latest upstream versions, so this is the only change needed:
inSync-8.1.3r110967tag-5.9(9148)cdn.zoom.us/prod/7.1.5.13403/Notes for reviewers
Verified the 1.4.0 installer against the cask stanzas before regenerating:
c920b983…com.fleetdm.fleet-desktop(fromPackageInfo) matches both thepkgutil:andquit:stanzasCFBundleShortVersionStringis1.4.0, matching the cask version — so thepatchedquery won't produce a perpetual false "Update available"pkgstanza filenamefleet_desktop-v1.4.0.pkgmatches the downloaded filenameregenerate.shrebuilds all four api JSONs; only fleet-desktop changed, so there was no brew schema drift to absorb on the others. Theinstall_script_refchanges (5d021f75→0341b271) only because the pkg filename inside the script changed;uninstall_script_refis unchanged.Unrelated, not addressed here: brew emits a deprecation warning on three casks for
depends_on macos: ">= :ventura"(string comparison) vsdepends_on macos: :ventura. It doesn't affect the generated JSON.Checklist for submitter
fleetd/orbit/Fleet Desktop
runtime.GOOSis used as needed to isolate changesThis is a macOS-only FMA manifest regeneration — no Go code, no schema, no fleetd/orbit runtime changes. The remaining template sections (changes file, SQL/input validation, timeouts, automated tests, migrations, config settings, fleetd compatibility/auto-update) don't apply; prior custom-tap bumps (#49563, #50651) likewise carry no changes file.
Summary by CodeRabbit