Skip to content

Remove Gadwin PrintScreen, PrintScreen Pro, and ScreenRecorder FMAs (expired TLS cert on download host) - #50470

Merged
allenhouchins merged 1 commit into
mainfrom
remove-gadwin-fmas
Aug 4, 2026
Merged

Remove Gadwin PrintScreen, PrintScreen Pro, and ScreenRecorder FMAs (expired TLS cert on download host)#50470
allenhouchins merged 1 commit into
mainfrom
remove-gadwin-fmas

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Aug 3, 2026

Copy link
Copy Markdown
Member

Related issue: NA

Removes the three Gadwin Fleet-maintained apps: Gadwin PrintScreen, Gadwin PrintScreen Pro, and Gadwin ScreenRecorder.

All three download their installers from www.gadwin.com, whose Let's Encrypt certificate expired 2026-08-02 and has not been renewed:

subject=CN=gadwin.com
issuer=C=US, O=Let's Encrypt, CN=R13
notBefore=May  4 13:06:54 2026 GMT
notAfter=Aug  2 13:06:53 2026 GMT

Every FMA validation run now fails these three apps:

level=ERROR msg="Error downloading maintained app: downloading installer:
performing request for URL https://www.gadwin.com/download/PrintScreen650_Win64.msi:
tls: failed to verify certificate: x509: certificate has expired or is not yet valid"
app="Gadwin PrintScreen"

This is not just CI: Fleet fetches the installer from that same URL when a user installs the app, so all three are currently uninstallable for customers.

Note

The certificate expired only one day before this PR was opened. If Gadwin renews it, these apps become viable again and the alternative fix is "frozen": true in each winget input (which skips validation) rather than removal. Removing was chosen because a lapsed auto-renewing certificate means no one is maintaining the download host, and a broken installer URL is worse for users than an absent app. Happy to switch to a freeze if reviewers prefer to wait it out.

What's removed

Per app, all locations that applied:

Location PrintScreen PrintScreen Pro ScreenRecorder
ee/maintained-apps/inputs/winget/<slug>.json
ee/maintained-apps/outputs/<slug>/windows.json
ee/maintained-apps/outputs/apps.json entry
frontend/.../icons/<Name>.tsx — (none existed)
import + mapping in icons/index.ts
website/assets/images/app-icon-<slug>-60x60@2x.png — (none existed)

All three are Windows-only (no Homebrew input or darwin.json), so no macOS counterpart is affected and no shared icons needed to be retained. apps.json goes from 1393 to 1390 apps. The diff is deletion-only.

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

Testing

  • QA'd all new/changed functionality manually

Verification performed:

  • apps.json parses as valid JSON; no gadwin slugs remain.
  • Repo-wide grep for gadwin returns no dangling references. (The one remaining hit, cmd/osquery-perf/software-library/software.sql, is a simulated host-inventory fixture, not an FMA definition — intentionally left in place.)
  • npx tsc --noEmit reports no errors related to the removed icon components or the icon index.
  • npx prettier --check passes on icons/index.ts and apps.json.
  • go build ./cmd/maintained-apps/... ./ee/maintained-apps/... and go test ./ee/maintained-apps/... pass.

Summary by CodeRabbit

  • Chores
    • Removed Gadwin PrintScreen, Gadwin PrintScreen Pro, and Gadwin ScreenRecorder from the maintained Windows application catalog.
    • Removed their associated software listings, installation details, and product icons from the application interface.

All three Gadwin apps download their installers from www.gadwin.com, whose
Let's Encrypt certificate expired 2026-08-02 and has not been renewed. Every
FMA validation run now fails these three apps with:

  tls: failed to verify certificate: x509: certificate has expired or is not
  yet valid

The same failure applies to end users: Fleet fetches the installer from that
URL at install time, so the apps cannot be installed while the cert is
invalid.

Removes all six locations for each app: the winget input, the windows.json
output, the apps.json entry, and (for the two PrintScreen apps, which had
them) the frontend icon component, its import/mapping in the icon index, and
the website PNG. Gadwin ScreenRecorder had no icon.
Copilot AI review requested due to automatic review settings August 3, 2026 21:01
@allenhouchins
allenhouchins requested a review from a team as a code owner August 3, 2026 21:01
@fleet-release
fleet-release requested a review from eashaw August 3, 2026 21:02
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Script Diff Results

ee/maintained-apps/inputs/winget/gadwin-printscreen-pro.json

Error: File 'ee/maintained-apps/inputs/winget/gadwin-printscreen-pro.json' does not exist

ee/maintained-apps/inputs/winget/gadwin-printscreen.json

Error: File 'ee/maintained-apps/inputs/winget/gadwin-printscreen.json' does not exist

ee/maintained-apps/inputs/winget/gadwin-screenrecorder.json

Error: File 'ee/maintained-apps/inputs/winget/gadwin-screenrecorder.json' does not exist

ee/maintained-apps/outputs/gadwin-printscreen-pro/windows.json

Error: File 'ee/maintained-apps/outputs/gadwin-printscreen-pro/windows.json' does not exist

ee/maintained-apps/outputs/gadwin-printscreen/windows.json

Error: File 'ee/maintained-apps/outputs/gadwin-printscreen/windows.json' does not exist

ee/maintained-apps/outputs/gadwin-screenrecorder/windows.json

Error: File 'ee/maintained-apps/outputs/gadwin-screenrecorder/windows.json' does not exist

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f14d3394-c4fc-4f66-bd9a-a0ded4770247

📥 Commits

Reviewing files that changed from the base of the PR and between 74c2b79 and 50e800f.

⛔ Files ignored due to path filters (2)
  • website/assets/images/app-icon-gadwin-printscreen-60x60@2x.png is excluded by !**/*.png
  • website/assets/images/app-icon-gadwin-printscreen-pro-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (10)
  • ee/maintained-apps/inputs/winget/gadwin-printscreen-pro.json
  • ee/maintained-apps/inputs/winget/gadwin-printscreen.json
  • ee/maintained-apps/inputs/winget/gadwin-screenrecorder.json
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/gadwin-printscreen-pro/windows.json
  • ee/maintained-apps/outputs/gadwin-printscreen/windows.json
  • ee/maintained-apps/outputs/gadwin-screenrecorder/windows.json
  • frontend/pages/SoftwarePage/components/icons/GadwinPrintscreen.tsx
  • frontend/pages/SoftwarePage/components/icons/GadwinPrintscreenPro.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts
💤 Files with no reviewable changes (10)
  • ee/maintained-apps/inputs/winget/gadwin-printscreen-pro.json
  • ee/maintained-apps/inputs/winget/gadwin-screenrecorder.json
  • ee/maintained-apps/inputs/winget/gadwin-printscreen.json
  • ee/maintained-apps/outputs/gadwin-printscreen/windows.json
  • ee/maintained-apps/outputs/gadwin-screenrecorder/windows.json
  • frontend/pages/SoftwarePage/components/icons/GadwinPrintscreen.tsx
  • frontend/pages/SoftwarePage/components/icons/GadwinPrintscreenPro.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts
  • ee/maintained-apps/outputs/gadwin-printscreen-pro/windows.json
  • ee/maintained-apps/outputs/apps.json

Walkthrough

Removed the Gadwin PrintScreen, Gadwin PrintScreen Pro, and Gadwin ScreenRecorder maintained application definitions and Windows configurations. Removed their records from the maintained applications catalog. Removed the Gadwin PrintScreen and Gadwin PrintScreen Pro React icon components, imports, and software-name mappings.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the three removed Gadwin maintained apps and the expired certificate cause.
Description check ✅ Passed The description explains the cause, scope, affected files, rationale, and validation steps, with the relevant checklist items addressed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-gadwin-fmas

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes three Windows Fleet-maintained apps (FMAs) that currently cannot be validated or installed because the upstream download host (www.gadwin.com) presents an expired TLS certificate.

Changes:

  • Removed the Winget input definitions and generated Windows outputs for the three Gadwin apps.
  • Removed the three apps from the maintained-app catalog (ee/maintained-apps/outputs/apps.json).
  • Removed the two corresponding software icon components and their mapping entries from the Software page icons index.

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/pages/SoftwarePage/components/icons/index.ts Removes imports and name→icon map entries for the two Gadwin icons.
frontend/pages/SoftwarePage/components/icons/GadwinPrintscreen.tsx Deletes the Gadwin PrintScreen icon component.
frontend/pages/SoftwarePage/components/icons/GadwinPrintscreenPro.tsx Deletes the Gadwin PrintScreen Pro icon component.
ee/maintained-apps/outputs/gadwin-screenrecorder/windows.json Deletes generated Windows output for Gadwin ScreenRecorder.
ee/maintained-apps/outputs/gadwin-printscreen/windows.json Deletes generated Windows output for Gadwin PrintScreen.
ee/maintained-apps/outputs/gadwin-printscreen-pro/windows.json Deletes generated Windows output for Gadwin PrintScreen Pro.
ee/maintained-apps/outputs/apps.json Removes the three Gadwin app entries from the maintained app catalog.
ee/maintained-apps/inputs/winget/gadwin-screenrecorder.json Deletes the Winget input for Gadwin ScreenRecorder.
ee/maintained-apps/inputs/winget/gadwin-printscreen.json Deletes the Winget input for Gadwin PrintScreen.
ee/maintained-apps/inputs/winget/gadwin-printscreen-pro.json Deletes the Winget input for Gadwin PrintScreen Pro.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.13%. Comparing base (bbbe93d) to head (50e800f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #50470   +/-   ##
=======================================
  Coverage   68.13%   68.13%           
=======================================
  Files        3947     3945    -2     
  Lines      251501   251497    -4     
  Branches    13307    13307           
=======================================
- Hits       171349   171347    -2     
+ Misses      64835    64833    -2     
  Partials    15317    15317           
Flag Coverage Δ
frontend 61.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins merged commit b2b2081 into main Aug 4, 2026
36 checks passed
@allenhouchins
allenhouchins deleted the remove-gadwin-fmas branch August 4, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants