Remove Dynalist macOS Fleet-maintained app (cask deleted from homebrew-cask) - #50215
Conversation
The dynalist cask was deleted from homebrew-cask on 2026-07-30 (commit adac21ffc4), completing Homebrew's deprecation lifecycle: deprecate! 2024-07-29 (:unmaintained) -> disable! 2025-07-29 -> cask file removed. formulae.brew.sh now 404s for it, so the scheduled FMA ingester panics with "app not found in brew API". Freezing the app does not help: the ingester fetches the cask JSON before the frozen flag is consulted, so the only fix is removal. Removes the homebrew input, the darwin output, and the dynalist/darwin entry in apps.json. The Windows (winget) FMA is unaffected and stays, along with the shared icons.
Script Diff Resultsee/maintained-apps/inputs/homebrew/dynalist.jsonError: File 'ee/maintained-apps/inputs/homebrew/dynalist.json' does not existee/maintained-apps/outputs/dynalist/darwin.jsonError: File 'ee/maintained-apps/outputs/dynalist/darwin.json' does not exist |
There was a problem hiding this comment.
Pull request overview
Removes the macOS (Homebrew/cask) Fleet-maintained app definition for Dynalist after the upstream cask was deleted, preventing the maintained-apps ingest from failing when the Brew API returns 404. The Windows (winget) Dynalist FMA remains intact.
Changes:
- Deleted the Homebrew input definition for
dynalist(macOS). - Deleted the generated macOS output metadata for
dynalist. - Removed the
dynalist/darwinentry from the maintained apps registry (apps.json), leavingdynalist/windows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ee/maintained-apps/outputs/dynalist/darwin.json | Removes macOS maintained-app output metadata for Dynalist. |
| ee/maintained-apps/outputs/apps.json | Drops the dynalist/darwin entry while keeping dynalist/windows. |
| ee/maintained-apps/inputs/homebrew/dynalist.json | Removes the Homebrew input for the now-nonexistent cask. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughRemoved Dynalist’s macOS application mapping and associated macOS maintained-app configuration and output. The Windows Dynalist entry remains available. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Related issue: NA — fixing a failing scheduled "Update Fleet-maintained apps" run.
Removes the macOS Dynalist Fleet-maintained app. The Windows (winget) FMA is unaffected and stays.
Why
The
dynalistcask was deleted from homebrew-cask on 2026-07-30 (commitadac21ffc4), completing Homebrew's full deprecation lifecycle:deprecate!2024-07-29,because: :unmaintaineddisable!2025-07-29https://formulae.brew.sh/api/cask/dynalist.jsonnow returns 404, so the scheduled ingester panics:Marking the app
"frozen": truedoes not fix this — the ingester fetches the cask JSON before the frozen flag is consulted (cmd/maintained-apps/main.go), so removal is the only fix for a dead upstream cask.What changed
Deletions only (39 lines, no additions):
ee/maintained-apps/inputs/homebrew/dynalist.json— deletedee/maintained-apps/outputs/dynalist/darwin.json— deleteddynalist/darwinentry inee/maintained-apps/outputs/apps.json— removed;dynalist/windowsremainsDeliberately kept
Because the Windows FMA still needs them:
ee/maintained-apps/outputs/dynalist/windows.json,ee/maintained-apps/inputs/winget/dynalist.json, and its install/uninstall scriptsfrontend/pages/SoftwarePage/components/icons/Dynalist.tsxand itsdynalist:mapping inicons/index.ts— the map is keyed by lowercased app name and is shared across platformswebsite/assets/images/app-icon-dynalist-60x60@2x.png— keyed by slug token, still serving the Windows entry in the app libraryNote for reviewers
Hosts that currently have the macOS Dynalist FMA installed will lose the maintained-app entry on the next sync. This matches the behavior of prior FMA removals (Nocturnal #50050, Dell Display Manager #47420, Messenger #46541).
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.Not applicable — consistent with prior FMA removal PRs, which do not add a changes file.
Testing
Verified that
ee/maintained-apps/outputs/apps.jsonstill parses as valid JSON (1381 apps) and thatDynalistnow resolves to onlydynalist/windows. Confirmed the 404 against the brew API and read the pre-removal cask atadac21ffc4~1to establish the deprecation reason.git diffconfirms the change is deletions-only.Summary by CodeRabbit