iOS/iPadOS device vitals: expose in GET host API response - #50082
Conversation
|
@coderabbitai full review |
✅ Action performedFull review finished. |
WalkthroughAdds Apple MDM device-vitals fields to Possibly related issues
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 49984-ios-ipados-vitals #50082 +/- ##
==========================================================
Coverage ? 68.11%
==========================================================
Files ? 3940
Lines ? 251157
Branches ? 13277
==========================================================
Hits ? 171083
Misses ? 64732
Partials ? 15342
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
140876b to
2d16ab0
Compare
17ca536 to
4cc022a
Compare
Adds the 29 new host_mdm_apple_device_vitals / host_mdm_apple_service_subscriptions fields to fleet.Host, loaded for iOS/iPadOS hosts only and fully omitted (not null) otherwise, wired into GET /hosts/:id and GET /hosts/identifier/:identifier.
Apple reports CellularTechnology as an integer (0 None, 1 GSM, 2 CDMA, 3 GSM and CDMA). Keep persisting that raw integer and map it to the label only when serializing the host response, via a MarshalJSON on a named type (same pattern as fleet.LabelType). An integer outside Apple's documented set maps to "unknown" rather than failing the whole response.
4cc022a to
c06a525
Compare
Related issue: Resolves #49985
Exposes the the 29 iOS/iPadOS device vitals fields in
GET /hosts/:idandGET /hosts/identifier/:identifierfor iOS/iPadOS hosts.Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Will be added in feature branch.
Testing
Added/updated automated tests
QA'd all new/changed functionality manually
Summary by CodeRabbit
New Features
Bug Fixes
Tests