Add Adobe plugins to software inventory

[juan-fdz-hawa]

Resolves #49060

Ingest fleetd's adobe_plugins table as a new adobe_plugins software source, so Adobe Creative Cloud CEP and UXP extensions show up in inventory on macOS and Windows hosts.

osquery-perf gets -common_adobe_plugins_software_count and -software_adobe_plugins_query_fail_prob.

Related issue: Resolves #

Checklist for submitter

If some of the following don't apply, delete the relevant line.

Testing

• Added/updated automated tests
• QA'd all new/changed functionality manually

Summary by CodeRabbit

• New Features

  • Added Adobe plugin inventory collection for macOS and Windows devices.
  • Adobe plugin details now appear in software inventory, including names, versions, vendors, identifiers, and installation paths.
  • Added configurable simulation options for plugin counts, uninstall behavior, and query failures.

• Bug Fixes

  • Improved software inventory processing to merge Adobe plugin results into platform-specific software records when available.

[juan-fdz-hawa]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

[coderabbitai]

Walkthrough

Adds the software_adobe_plugins detail query for macOS and Windows, gated by the adobe_plugins table and mapped into Fleet software fields. Extra-query preprocessing now merges plugin rows into platform software results. Tests cover query registration, column mappings, direct ingestion, discovery, platform behavior, and merging. The osquery-perf agent now generates configurable Adobe plugin rows and simulates query failures, uninstall behavior, and platform-specific paths.

Possibly related issues

• #45414 — Adds Adobe CEP/UXP plugin inventory collection, discovery gating, result merging, and osquery-perf coverage described by this issue.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is too sparse for the template and omits required sections like changelog, migration, and several checklist items.	Fill out the full template, including the related issue, changelog/changes file note, migration notes, and any applicable checklist items.
Linked Issues check	⚠️ Warning	Issue #49060 is mostly satisfied, but the required changelog entry is not shown in the summarized changes.	Add the required changes/ changelog entry and ensure it is included in the PR.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: adding Adobe plugins to software inventory.
Out of Scope Changes check	✅ Passed	All summarized changes relate to Adobe plugin ingestion, merge logic, tests, or osquery-perf support.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 49060-adobe-plugins-software-inventory-ingestion-detail-query-source-handling-osquery-perf

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cmd/osquery-perf/agent.go`:
- Around line 3919-3931: Add startup validation for
commonAdobePluginsSoftwareCount and uniqueAdobePluginsSoftwareCount before
agents are created, alongside the existing software uninstall validation. Reject
negative values before softwareAdobePlugins reaches make, using the same
validation and failure behavior already used for related software counts.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f5b67c49-32d4-4604-88b5-10bd3b862e63

📥 Commits

Reviewing files that changed from the base of the PR and between 098f427 and 073644d.

📒 Files selected for processing (5)

• cmd/osquery-perf/agent.go
• server/service/osquery.go
• server/service/osquery_test.go
• server/service/osquery_utils/queries.go
• server/service/osquery_utils/queries_test.go

[codecov]

Codecov Report

❌ Patch coverage is 3.61446% with 80 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (45414-software-inventory-vulnerabilities-add-adobe-plugins@098f427). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
cmd/osquery-perf/agent.go	0.00%	80 Missing ⚠️

Additional details and impacted files

@@                                      Coverage Diff                                      @@
##             45414-software-inventory-vulnerabilities-add-adobe-plugins   #50039   +/-   ##
=============================================================================================
  Coverage                                                              ?   67.94%           
=============================================================================================
  Files                                                                 ?     3922           
  Lines                                                                 ?   250114           
  Branches                                                              ?    13178           
=============================================================================================
  Hits                                                                  ?   169949           
  Misses                                                                ?    64865           
  Partials                                                              ?    15300           

Flag	Coverage Δ
backend	69.34% <3.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[juan-fdz-hawa]

Docs to be added elsewhere