Update Fleet-maintained apps - #49974
Closed
fleet-release wants to merge 1 commit into
Closed
Conversation
Generated automatically with cmd/maintained-apps.
Contributor
Script Diff Resultsee/maintained-apps/outputs/air-explorer/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/appium-inspector/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/elgato-control-center/darwin.json=== Install Script (no changes) ===
=== Uninstall // 01138a65 -> 1c0989fd ===
--- /tmp/old.AtDAU8 2026-07-27 13:06:37.841634801 +0000
+++ /tmp/new.Qf71xU 2026-07-27 13:06:37.841634801 +0000
@@ -95,8 +95,11 @@
quit_application 'com.corsair.ControlCenter'
sudo rm -rf "$APPDIR/Elgato Control Center.app"
trash $LOGGED_IN_USER '~/Library/Application Scripts/com.corsair.ControlCenterLauncher'
+trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/com.corsair.controlcenter.sfl*'
trash $LOGGED_IN_USER '~/Library/Application Support/com.corsair.ControlCenter'
+trash $LOGGED_IN_USER '~/Library/Application Support/Elgato Control Center'
trash $LOGGED_IN_USER '~/Library/Caches/com.corsair.ControlCenter'
trash $LOGGED_IN_USER '~/Library/Caches/com.plausiblelabs.crashreporter.data/com.corsair.ControlCenter'
trash $LOGGED_IN_USER '~/Library/Containers/com.corsair.ControlCenterLauncher'
+trash $LOGGED_IN_USER '~/Library/HTTPStorages/com.corsair.ControlCenter'
trash $LOGGED_IN_USER '~/Library/Preferences/com.corsair.ControlCenter.plist'ee/maintained-apps/outputs/firefox@nightly/darwin.json=== Install Script (no changes) ===
=== Uninstall // d7c711ad -> 0661f848 ===
--- /tmp/old.D3ykjv 2026-07-27 13:06:37.898636358 +0000
+++ /tmp/new.VDdeev 2026-07-27 13:06:37.899636385 +0000
@@ -65,5 +65,6 @@
trash $LOGGED_IN_USER '~/Library/Caches/Mozilla/updates/Applications/Firefox'
trash $LOGGED_IN_USER '~/Library/Caches/org.mozilla.firefox'
trash $LOGGED_IN_USER '~/Library/Preferences/org.mozilla.firefox.plist'
+trash $LOGGED_IN_USER '~/Library/Preferences/org.mozilla.nightly.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/org.mozilla.firefox.savedState'
trash $LOGGED_IN_USER '~/Library/WebKit/org.mozilla.firefox'ee/maintained-apps/outputs/kiro/darwin.json=== Install Script (no changes) ===
=== Uninstall // b5d79db0 -> 4678d87f ===
--- /tmp/old.u52ew7 2026-07-27 13:06:37.948637724 +0000
+++ /tmp/new.WRc63p 2026-07-27 13:06:37.948637724 +0000
@@ -54,6 +54,8 @@
sudo rm -rf "$APPDIR/Kiro.app"
sudo rm -rf 'kiro'
+sudo rmdir '~/.kiro'
+trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/dev.kiro.desktop.sfl*'
trash $LOGGED_IN_USER '~/Library/Application Support/Kiro'
trash $LOGGED_IN_USER '~/Library/Preferences/dev.kiro.desktop.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/dev.kiro.desktop.savedState'ee/maintained-apps/outputs/marked-app/darwin.json=== Install Script (no changes) ===
=== Uninstall // 9e4b9fca -> 57b4bcf2 ===
--- /tmp/old.sKT83l 2026-07-27 13:06:37.998639089 +0000
+++ /tmp/new.paKau4 2026-07-27 13:06:37.998639089 +0000
@@ -94,10 +94,15 @@
quit_application 'com.brettterpstra.marked'
sudo rm -rf "$APPDIR/Marked.app"
+trash $LOGGED_IN_USER '~/Library/Application Scripts/com.brettterpstra.marked.Share'
trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/com.brettterpstra.marked.sfl*'
+trash $LOGGED_IN_USER '~/Library/Application Support/com.brettterpstra.marked'
trash $LOGGED_IN_USER '~/Library/Application Support/Marked'
trash $LOGGED_IN_USER '~/Library/Caches/com.brettterpstra.marked'
trash $LOGGED_IN_USER '~/Library/Caches/Marked'
+trash $LOGGED_IN_USER '~/Library/Containers/com.brettterpstra.marked.Share'
+trash $LOGGED_IN_USER '~/Library/HTTPStorages/com.brettterpstra.marked'
trash $LOGGED_IN_USER '~/Library/Logs/Marked'
trash $LOGGED_IN_USER '~/Library/Preferences/com.brettterpstra.marked.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/com.brettterpstra.marked.savedState'
+trash $LOGGED_IN_USER '~/Library/WebKit/com.brettterpstra.marked'ee/maintained-apps/outputs/mellel/darwin.json=== Install Script (no changes) ===
=== Uninstall // 7a83c8df -> 0ed774a5 ===
--- /tmp/old.4hjpdj 2026-07-27 13:06:38.056640674 +0000
+++ /tmp/new.8j56Ym 2026-07-27 13:06:38.056640674 +0000
@@ -54,6 +54,7 @@
sudo rm -rf "$APPDIR/Mellel 6.app"
trash $LOGGED_IN_USER '~/Library/Application Scripts/com.redlex.mellel'
+trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/com.redlex.mellel6.sfl*'
trash $LOGGED_IN_USER '~/Library/Application Support/com.redlex.mellel6'
trash $LOGGED_IN_USER '~/Library/Application Support/Mellel 6'
trash $LOGGED_IN_USER '~/Library/Caches/com.redlex.mellel6'ee/maintained-apps/outputs/melodics/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/opencode-desktop/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/purevpn/darwin.json=== Install Script (no changes) ===
=== Uninstall // c8aad552 -> d713dfe8 ===
--- /tmp/old.PHSZtF 2026-07-27 13:06:38.174643897 +0000
+++ /tmp/new.e2m9XE 2026-07-27 13:06:38.175643924 +0000
@@ -161,9 +161,12 @@
quit_application 'com.purevpn.app.mac'
remove_pkg_files 'com.purevpn.mac.installer'
forget_pkg 'com.purevpn.mac.installer'
+trash $LOGGED_IN_USER '~/Library/Application Scripts/4H849Z7V2K.com.purevpn.app.mac'
trash $LOGGED_IN_USER '~/Library/Application Support/com.purevpn.app.mac'
trash $LOGGED_IN_USER '~/Library/Caches/com.purevpn.app.mac'
+trash $LOGGED_IN_USER '~/Library/Group Containers/4H849Z7V2K.com.purevpn.app.mac'
trash $LOGGED_IN_USER '~/Library/HTTPStorages/com.purevpn.app.mac'
trash $LOGGED_IN_USER '~/Library/HTTPStorages/com.purevpn.app.mac.binarycookies'
trash $LOGGED_IN_USER '~/Library/Preferences/com.purevpn.app.mac.plist'
+trash $LOGGED_IN_USER '~/Library/Preferences/group.com.purevpn.app.mac.firebase.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/com.purevpn.app.mac.savedState'ee/maintained-apps/outputs/reqable/darwin.json=== Install Script (no changes) ===
=== Uninstall // 3319d75e -> 5fd65159 ===
--- /tmp/old.ZM5SRf 2026-07-27 13:06:38.222645208 +0000
+++ /tmp/new.hLkoER 2026-07-27 13:06:38.222645208 +0000
@@ -53,5 +53,6 @@
}
sudo rm -rf "$APPDIR/Reqable.app"
+trash $LOGGED_IN_USER '~/Library/Application Support/com.reqable.macosx'
trash $LOGGED_IN_USER '~/Library/Caches/Reqable'
trash $LOGGED_IN_USER '~/Library/Preferences/com.reqable.macosx.plist'ee/maintained-apps/outputs/rize/darwin.json=== Install Script (no changes) ===
=== Uninstall // 8f8ad201 -> fe9839a4 ===
--- /tmp/old.0odJap 2026-07-27 13:06:38.269646492 +0000
+++ /tmp/new.Jlt9bY 2026-07-27 13:06:38.270646519 +0000
@@ -53,6 +53,7 @@
}
sudo rm -rf "$APPDIR/Rize.app"
+trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/io.rize.sfl*'
trash $LOGGED_IN_USER '~/Library/Application Support/Rize'
trash $LOGGED_IN_USER '~/Library/Caches/io.rize'
trash $LOGGED_IN_USER '~/Library/Caches/io.rize.ShipIt'ee/maintained-apps/outputs/screen-studio/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/sourcetree/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/voiceink/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/whatsapp/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/zed/darwin.json=== Install Script (no changes) ===
=== Uninstall // 9e70631b -> 0436e2d8 ===
--- /tmp/old.UzMAJu 2026-07-27 13:06:38.525653484 +0000
+++ /tmp/new.gr3Ggk 2026-07-27 13:06:38.525653484 +0000
@@ -92,9 +92,9 @@
fi
}
+quit_application 'dev.zed.Zed'
sudo rm -rf "$APPDIR/Zed.app"
sudo rm -rf 'zed'
-quit_application 'dev.zed.Zed'
trash $LOGGED_IN_USER '~/.config/zed'
trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/dev.zed.zed.sfl*'
trash $LOGGED_IN_USER '~/Library/Application Support/Zed' |
Contributor
WalkthroughUpdated 17 maintained app manifests with newer release versions or installer artifacts, synchronized patch-detection thresholds and checksums, and changed macOS uninstall script references. Several uninstall scripts now remove additional application data, remove fewer paths, add shared file list cleanup, or quit applications before deleting their files. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/firefox`@nightly/darwin.json:
- Line 19: Add a bounded quit-and-verify step for the org.mozilla.nightly
process before the sudo rm -rf command in the uninstall script, following the
existing Zed uninstall pattern. Ensure deletion proceeds only after Firefox
Nightly has quit or the verification timeout is reached.
- Line 19: Application bundles are removed without first stopping and confirming
their processes have exited. In the uninstall scripts, add a bounded
quit-and-verify step before each bundle deletion, preserving the existing rm -rf
behavior only after the application is no longer running. Apply this in
ee/maintained-apps/outputs/firefox@nightly/darwin.json (19-19),
ee/maintained-apps/outputs/mellel/darwin.json (19-19),
ee/maintained-apps/outputs/reqable/darwin.json (20-20), and
ee/maintained-apps/outputs/rize/darwin.json (20-20).
In `@ee/maintained-apps/outputs/kiro/darwin.json`:
- Line 20: Update the `.kiro` cleanup command in the generated script to pass
the path through the existing `trash` function using `~/.kiro` unquoted so its
tilde expansion logic resolves it for the logged-in user, and use recursive
removal behavior rather than `rmdir` so non-empty application data is removed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: eaf061b4-7a38-4d4e-ad3c-22abd0d9f451
📒 Files selected for processing (17)
ee/maintained-apps/outputs/air-explorer/windows.jsonee/maintained-apps/outputs/appium-inspector/darwin.jsonee/maintained-apps/outputs/elgato-control-center/darwin.jsonee/maintained-apps/outputs/firefox@nightly/darwin.jsonee/maintained-apps/outputs/kiro/darwin.jsonee/maintained-apps/outputs/marked-app/darwin.jsonee/maintained-apps/outputs/mellel/darwin.jsonee/maintained-apps/outputs/melodics/darwin.jsonee/maintained-apps/outputs/opencode-desktop/darwin.jsonee/maintained-apps/outputs/purevpn/darwin.jsonee/maintained-apps/outputs/reqable/darwin.jsonee/maintained-apps/outputs/rize/darwin.jsonee/maintained-apps/outputs/screen-studio/darwin.jsonee/maintained-apps/outputs/sourcetree/darwin.jsonee/maintained-apps/outputs/voiceink/darwin.jsonee/maintained-apps/outputs/whatsapp/darwin.jsonee/maintained-apps/outputs/zed/darwin.json
| "refs": { | ||
| "418c9331": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# extract contents\nMOUNT_POINT=$(mktemp -d /tmp/dmg_mount_XXXXXX)\nyes | hdiutil attach -plist -nobrowse -readonly -mountpoint \"$MOUNT_POINT\" \"$INSTALLER_PATH\" || exit 1\nsudo cp -R \"$MOUNT_POINT\"/* \"$TMPDIR\"\nhdiutil detach \"$MOUNT_POINT\" || true\n# copy to the applications folder\nquit_and_track_application 'org.mozilla.nightly'\nif [ -d \"$APPDIR/Firefox Nightly.app\" ]; then\n\tsudo mv \"$APPDIR/Firefox Nightly.app\" \"$TMPDIR/Firefox Nightly.app.bkp\"\nfi\nsudo cp -R \"$TMPDIR/Firefox Nightly.app\" \"$APPDIR\"\nrelaunch_application 'org.mozilla.nightly'\n", | ||
| "d7c711ad": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Firefox Nightly.app\"\nsudo rmdir '~/Library/Application Support/Mozilla'\nsudo rmdir '~/Library/Caches/Mozilla'\nsudo rmdir '~/Library/Caches/Mozilla/updates'\nsudo rmdir '~/Library/Caches/Mozilla/updates/Applications'\ntrash $LOGGED_IN_USER '/Library/Logs/DiagnosticReports/firefox_*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/org.mozilla.firefox.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/CrashReporter/firefox_*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/Mozilla/updates/Applications/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/org.mozilla.firefox'\ntrash $LOGGED_IN_USER '~/Library/Preferences/org.mozilla.firefox.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/org.mozilla.firefox.savedState'\ntrash $LOGGED_IN_USER '~/Library/WebKit/org.mozilla.firefox'\n" | ||
| "0661f848": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Firefox Nightly.app\"\nsudo rmdir '~/Library/Application Support/Mozilla'\nsudo rmdir '~/Library/Caches/Mozilla'\nsudo rmdir '~/Library/Caches/Mozilla/updates'\nsudo rmdir '~/Library/Caches/Mozilla/updates/Applications'\ntrash $LOGGED_IN_USER '/Library/Logs/DiagnosticReports/firefox_*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/org.mozilla.firefox.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/CrashReporter/firefox_*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/Mozilla/updates/Applications/Firefox'\ntrash $LOGGED_IN_USER '~/Library/Caches/org.mozilla.firefox'\ntrash $LOGGED_IN_USER '~/Library/Preferences/org.mozilla.firefox.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/org.mozilla.nightly.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/org.mozilla.firefox.savedState'\ntrash $LOGGED_IN_USER '~/Library/WebKit/org.mozilla.firefox'\n", |
Contributor
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== locate relevant files =="
fd -a 'darwin\.json|zed.*\.json' . | sed 's#^\./##' | head -100
echo
echo "== firefox uninstall script fields =="
python3 - <<'PY'
import json, pathlib
p=pathlib.Path('ee/maintained-apps/outputs/firefox@nightly/darwin.json')
if p.exists():
data=json.loads(p.read_text())
print("first keys:", list(data.keys())[:10])
for k,v in data.items():
if isinstance(v, dict):
# print uninstall if likely scripts are in a dict
pass
PY
echo
echo "== search Zed uninstall for quit pattern =="
rg -n "pkill|killall|quitch|quit|sudo rm -rf.*Zed|Zed" ee/maintained-apps/outputs 2>/dev/null | head -200
echo
echo "== search quit usage in outputs =="
rg -n "pkill|killall|quitch|quit" ee/maintained-apps/outputs 2>/dev/null | head -200Repository: fleetdm/fleet
Length of output: 7220
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== inspect exact firefox uninstall and nearby uninstall files =="
for f in \
ee/maintained-apps/outputs/firefox@nightly/darwin.json \
ee/maintained-apps/outputs/zed/darwin.json \
ee/maintained-apps/outputs/zed-nightly/darwin.json
do
if [ -f "$f" ]; then
echo "--- $f ($(wc -l < "$f") lines) ---"
sed -n '1,120p' "$f"
fi
done
echo
echo "== parse JSON keys and uninstall values =="
python3 - <<'PY'
import json, pathlib, re
for f in pathlib.Path('ee/maintained-apps/outputs').rglob('darwin.json'):
data=json.loads(f.read_text())
for key, value in data.items():
if isinstance(value, str):
if 'rm -rf' in value or 'rmdir' in value or 'Library/Application Support' in value:
print(f"FILE {f}\nKEY {key}\nUNINSTALL contains rm/rmdir/Library/Application Support\n")
for i,line in enumerate(value.splitlines(),1):
if i<=80:
print(f"{i:4}: {line}")
print("-----")
PYRepository: fleetdm/fleet
Length of output: 15828
Quit Firefox Nightly before deleting its bundle.
The uninstall script removes Firefox Nightly.app directly; a bounded quit-and-verify step for org.mozilla.nightly before sudo rm -rf should mirror the Zed uninstall pattern.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/firefox`@nightly/darwin.json at line 19, Add a
bounded quit-and-verify step for the org.mozilla.nightly process before the sudo
rm -rf command in the uninstall script, following the existing Zed uninstall
pattern. Ensure deletion proceeds only after Firefox Nightly has quit or the
verification timeout is reached.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "Repo files of interest:"
git ls-files 'ee/maintained-apps/outputs/*/*/darwin.json' | rg 'firefox@nightly|mellel|reqable|rize' || true
for f in \
ee/maintained-apps/outputs/firefox@nightly/darwin.json \
ee/maintained-apps/outputs/mellel/darwin.json \
ee/maintained-apps/outputs/reqable/darwin.json \
ee/maintained-apps/outputs/rize/darwin.json
do
echo
echo "===== $f ====="
sed -n '1,80p' "$f"
done
echo
echo "Search for quit/pkill/launchctl in referenced darwin scripts:"
rg -n 'pkill|killall|launchctl|quit|quit app|osascript|app terminate|AppleScript|Mozilla|Firefox|Reqable|Rize|Mellel' ee/maintained-apps/outputs/firefox@nightly/darwin.json ee/maintained-apps/outputs/mellel/darwin.json ee/maintained-apps/outputs/reqable/darwin.json ee/maintained-apps/outputs/rize/darwin.json || trueRepository: fleetdm/fleet
Length of output: 50369
Quit running applications before deleting their bundles.
The uninstall scripts delete the application bundles directly, so a running process can survive deletion and recreate uninstall state after uninstall. Add a bounded quit-and-verify step before each rm -rf "$APPDIR/*.app" in:
ee/maintained-apps/outputs/firefox@nightly/darwin.json(0661f848)ee/maintained-apps/outputs/mellel/darwin.json(0ed774a5)ee/maintained-apps/outputs/reqable/darwin.json(5fd65159)ee/maintained-apps/outputs/rize/darwin.json(fe9839a4)
📍 Affects 4 files
ee/maintained-apps/outputs/firefox@nightly/darwin.json#L19-L19(this comment)ee/maintained-apps/outputs/mellel/darwin.json#L19-L19ee/maintained-apps/outputs/reqable/darwin.json#L20-L20ee/maintained-apps/outputs/rize/darwin.json#L20-L20
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/firefox`@nightly/darwin.json at line 19,
Application bundles are removed without first stopping and confirming their
processes have exited. In the uninstall scripts, add a bounded quit-and-verify
step before each bundle deletion, preserving the existing rm -rf behavior only
after the application is no longer running. Apply this in
ee/maintained-apps/outputs/firefox@nightly/darwin.json (19-19),
ee/maintained-apps/outputs/mellel/darwin.json (19-19),
ee/maintained-apps/outputs/reqable/darwin.json (20-20), and
ee/maintained-apps/outputs/rize/darwin.json (20-20).
| "refs": { | ||
| "28c3d1eb": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# extract contents\nMOUNT_POINT=$(mktemp -d /tmp/dmg_mount_XXXXXX)\nyes | hdiutil attach -plist -nobrowse -readonly -mountpoint \"$MOUNT_POINT\" \"$INSTALLER_PATH\" || exit 1\nsudo cp -R \"$MOUNT_POINT\"/* \"$TMPDIR\"\nhdiutil detach \"$MOUNT_POINT\" || true\n# copy to the applications folder\nquit_and_track_application 'dev.kiro.desktop'\nif [ -d \"$APPDIR/Kiro.app\" ]; then\n\tsudo mv \"$APPDIR/Kiro.app\" \"$TMPDIR/Kiro.app.bkp\"\nfi\nsudo cp -R \"$TMPDIR/Kiro.app\" \"$APPDIR\"\nrelaunch_application 'dev.kiro.desktop'\nmkdir -p .\n/bin/ln -h -f -s -- \"$APPDIR/Kiro.app/Contents/Resources/app/bin/code\" \"kiro\"\n", | ||
| "b5d79db0": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Kiro.app\"\nsudo rm -rf 'kiro'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Kiro'\ntrash $LOGGED_IN_USER '~/Library/Preferences/dev.kiro.desktop.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/dev.kiro.desktop.savedState'\n" | ||
| "4678d87f": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Kiro.app\"\nsudo rm -rf 'kiro'\nsudo rmdir '~/.kiro'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/dev.kiro.desktop.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Kiro'\ntrash $LOGGED_IN_USER '~/Library/Preferences/dev.kiro.desktop.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/dev.kiro.desktop.savedState'\n" |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Fix the .kiro cleanup path and removal command.
Line 20 passes '~/.kiro' literally, so the shell does not expand it to the logged-in user’s home directory. Additionally, rmdir fails when the directory contains files, leaving the intended application data behind.
Proposed fix
- sudo rmdir '~/.kiro'
+ if [[ -n "$LOGGED_IN_USER" ]]; then
+ sudo rm -rf -- "/Users/$LOGGED_IN_USER/.kiro"
+ fi📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "4678d87f": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/Kiro.app\"\nsudo rm -rf 'kiro'\nsudo rmdir '~/.kiro'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/dev.kiro.desktop.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/Kiro'\ntrash $LOGGED_IN_USER '~/Library/Preferences/dev.kiro.desktop.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/dev.kiro.desktop.savedState'\n" | |
| sudo rm -rf 'kiro' | |
| if [[ -n "$LOGGED_IN_USER" ]]; then | |
| sudo rm -rf -- "/Users/$LOGGED_IN_USER/.kiro" | |
| fi | |
| trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/dev.kiro.desktop.sfl*' |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/kiro/darwin.json` at line 20, Update the `.kiro`
cleanup command in the generated script to pass the path through the existing
`trash` function using `~/.kiro` unquoted so its tilde expansion logic resolves
it for the logged-in user, and use recursive removal behavior rather than
`rmdir` so non-empty application data is removed.
Contributor
|
Closing in favor of #49989. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit
Updates
Bug Fixes