Website: (Android proxy) Add deviceNotFound exit to four android proxy endpoints

[eashaw]

Changes:

• Updated the delete-android-device, get-android-device, issue-command-on-android-device, and modify-android-device actions to return a deviceNotFound response to Fleet servers when the Android management API returns a 404 response.

Summary by CodeRabbit

• Bug Fixes
  • Improved Android device management error handling.
  • Device deletion, retrieval, command issuance, and modification now clearly report when the requested device cannot be found.
  • Prevents missing devices from being reported as generic errors.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9a43bfde-baf5-4b92-a032-e46ae6d96621

📥 Commits

Reviewing files that changed from the base of the PR and between 5c127e5 and 18794ed.

📒 Files selected for processing (4)

• website/api/controllers/android-proxy/delete-android-device.js
• website/api/controllers/android-proxy/get-android-device.js
• website/api/controllers/android-proxy/issue-command-on-android-device.js
• website/api/controllers/android-proxy/modify-android-device.js

---

Walkthrough

Four Android proxy controllers now declare a deviceNotFound exit with a notFound response type. Their Android Management API error interception chains also map HTTP 404 responses to this exit instead of generic error handling.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is only a one-line summary and omits the required issue reference, checklist, and testing details from the template.	Add the related issue field and complete the template sections for checklist items, testing, and any applicable deployment or migration notes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: adding a deviceNotFound exit to four Android proxy endpoints.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch website-update-patch-device-proxy-endpoint

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Adds a new deviceNotFound exit across Android proxy endpoints so Fleet servers can receive a dedicated “device does not exist” notFound response when the Android Management API returns HTTP 404.

Changes:

• Added a deviceNotFound exit to the four Android proxy actions.
• Added status: 404 interception in each action’s AMAPI call flow to map AMAPI 404 → deviceNotFound.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
website/api/controllers/android-proxy/modify-android-device.js	Adds deviceNotFound exit and intercepts AMAPI 404 responses.
website/api/controllers/android-proxy/issue-command-on-android-device.js	Adds deviceNotFound exit and intercepts AMAPI 404 responses.
website/api/controllers/android-proxy/get-android-device.js	Adds deviceNotFound exit and intercepts AMAPI 404 responses.
website/api/controllers/android-proxy/delete-android-device.js	Adds deviceNotFound exit and intercepts AMAPI 404 responses.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.