Skip to content

Add apps installed through Windows app store to software inventory - #49827

Merged
juan-fdz-hawa merged 1 commit into
mainfrom
14717-add-apps-installed-through-windows-app-store-to-software-inventory
Jul 30, 2026
Merged

Add apps installed through Windows app store to software inventory#49827
juan-fdz-hawa merged 1 commit into
mainfrom
14717-add-apps-installed-through-windows-app-store-to-software-inventory

Conversation

@juan-fdz-hawa

@juan-fdz-hawa juan-fdz-hawa commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Related issue: Resolves #14717

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

Summary by CodeRabbit

  • Updates
    • Renamed the Windows software inventory label from “Program (Windows)” to “Application (Windows)”.
    • The updated label includes applications installed through the Windows App Store.

@juan-fdz-hawa juan-fdz-hawa changed the title Added changes file Add apps installed through Windows app store to software inventory Jul 23, 2026
@juan-fdz-hawa
juan-fdz-hawa force-pushed the 14717-add-apps-installed-through-windows-app-store-to-software-inventory branch from ffeef8e to 6ffc51a Compare July 23, 2026 16:49
@juan-fdz-hawa
juan-fdz-hawa force-pushed the 14717-add-apps-installed-through-windows-app-store-to-software-inventory branch from 6ffc51a to cc6d570 Compare July 23, 2026 20:52
Closes #14717

Windows app store apps report with source='programs' alongside classic
installers, so rename the category rather than break store apps out into
a separate type. Blanket rename in SOURCE_TYPE_CONVERSION — no
conditional logic, icon mapping unchanged.
@juan-fdz-hawa
juan-fdz-hawa force-pushed the 14717-add-apps-installed-through-windows-app-store-to-software-inventory branch from cc6d570 to 3894b59 Compare July 27, 2026 17:38
@juan-fdz-hawa juan-fdz-hawa linked an issue Jul 27, 2026 that may be closed by this pull request
29 tasks
@juan-fdz-hawa
juan-fdz-hawa marked this pull request as ready for review July 27, 2026 17:40
@juan-fdz-hawa
juan-fdz-hawa requested a review from a team as a code owner July 27, 2026 17:40
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Renames the Windows software type label from “Program (Windows)” to “Application (Windows)” and clarifies that it includes Windows app store installations. Updates the SOURCE_TYPE_CONVERSION mapping and the related formatSoftwareType test expectation.

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: Windows app store apps are now included in software inventory.
Description check ✅ Passed The description includes the related issue and the relevant checklist items for changes, testing, and QA.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 14717-add-apps-installed-through-windows-app-store-to-software-inventory

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.95%. Comparing base (958fe8b) to head (3894b59).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #49827   +/-   ##
=======================================
  Coverage   67.95%   67.95%           
=======================================
  Files        3922     3922           
  Lines      250011   250011           
  Branches    13177    13177           
=======================================
  Hits       169888   169888           
  Misses      64830    64830           
  Partials    15293    15293           
Flag Coverage Δ
frontend 60.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dantecatalfamo

Copy link
Copy Markdown
Member

@juan-fdz-hawa Is this missing the changes file?

@juan-fdz-hawa

Copy link
Copy Markdown
Contributor Author

@juan-fdz-hawa Is this missing the changes file?

Nope, the PR description was borked

@juan-fdz-hawa
juan-fdz-hawa merged commit 554c62e into main Jul 30, 2026
28 checks passed
@juan-fdz-hawa
juan-fdz-hawa deleted the 14717-add-apps-installed-through-windows-app-store-to-software-inventory branch July 30, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add apps installed through Windows app store to software inventory

2 participants