Use EmptyState for configuration profiles empty state #49461 - #49772
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (3)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe configuration profiles page now uses Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Will review tomorrow AM |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49772 +/- ##
========================================
Coverage 68.33% 68.33%
========================================
Files 3953 3952 -1
Lines 253133 253130 -3
Branches 13335 13493 +158
========================================
- Hits 172990 172988 -2
+ Misses 64675 64673 -2
- Partials 15468 15469 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RachelElysia
left a comment
There was a problem hiding this comment.
Clean, well-scoped refactor. Mirrors the AssetsTab pattern verbatim — same variant, same GitOpsModeTooltipWrapper shape, same button behavior. Copy parallels the Assets tab tone.
Verified:
- No stale references to
AddProfileCardoradd-profile-cardanywhere in the tree ProfileGraphicstill used byAddProfileModal.tsx- Dropped
tipOffset={8}is a no-op —GitOpsModeTooltipWrapperdefaults to 8 in the non-single-field-row branch - Technician branch still shows the plain
Card— correct, only the admin/maintainer empty state changed

Related issue: Resolves #49461
Aligns the configuration profiles empty state with the newer Assets tab
pattern. Replaces the bespoke
AddProfileCardwith the sharedEmptyStatecomponent so admin/maintainer users see a consistent empty state across the
Profiles and Assets tabs. Removes the now-unused
AddProfileCardand its barrel.Checklist
changes/Testing
EmptyStatestory matching the Assets tab.Summary by CodeRabbit
Style
Bug Fixes