Set byod_fleet for dogfood Apple Business Manager tokens - #49564
Conversation
BYOD hosts appearing in Apple Business Manager now land in '📱🔐 Personal mobile devices' (Fleet Device Management Inc. token) and '🧪 Testing & QA' (Mactivate LLC token) instead of Unassigned.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated the Apple Business Manager organization mappings in Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)it-and-security/default.ymlTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sets the new
byod_fleetoption on both Apple Business Manager tokens in the dogfood GitOps config, so BYOD hosts appearing in Apple Business Manager are automatically added to the right fleet instead of "Unassigned":📱🔐 Personal mobile devices🧪 Testing & QAFleet names match the definitions in
it-and-security/fleets/personal-mobile-devices.ymlandit-and-security/fleets/testing-and-qa.ymlverbatim (including emoji prefixes). The file keeps the existingapple_business_managerparent key (deprecated alias forapple_business) to match the surrounding config; the alias machinery renames the parent before resolving nested keys, sobyod_fleetresolves correctly under it.Note for reviewers: this only affects where newly appearing BYOD hosts are placed — existing BYOD hosts in "Unassigned" are not retroactively moved.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Testing
Summary by CodeRabbit