Website: Update create-android-signup-url error handling

[eashaw]

Changes:

• Updated the website's Android proxy's create-android-signup-url endpoint to log a more detailed message if Google returns a 429 (rate limit exceeded) response in the get-is-enterprise-managed-by-fleet helper

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of Android enterprise-management rate limits when creating signup URLs.
  • If the upstream service responds with HTTP 429, the request now fails gracefully with a clear error instead of proceeding with the normal conflict/stale-record flow.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d6ad6e92-a084-4314-a768-f0cb3c59b46a

📥 Commits

Reviewing files that changed from the base of the PR and between e1d4dac and 3ca20af.

📒 Files selected for processing (1)

• website/api/controllers/android-proxy/create-android-signup-url.js

🚧 Files skipped from review as they are similar to previous changes (1)

• website/api/controllers/android-proxy/create-android-signup-url.js

---

Walkthrough

The Android signup URL controller now intercepts HTTP 429 responses from the enterprise-management lookup, logs a p1 Android management API rate-limit warning, and returns a new error.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is too sparse and omits required template sections like Related issue, checklist items, and Testing.	Add the required template sections, including a related issue reference, relevant checklist items, and testing details.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is clear and matches the main change: updating error handling for create-android-signup-url.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch website-update-proxy-helper-errors

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@website/api/controllers/android-proxy/create-android-signup-url.js`:
- Line 44: Update the error message returned by the Android signup URL creation
flow to replace “singup url” with “signup URL,” preserving the rest of the
message and the new 429-path behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8c7087d6-1443-4f19-a612-2e8bfc47bc26

📥 Commits

Reviewing files that changed from the base of the PR and between 94c2ac9 and f45de1b.

📒 Files selected for processing (1)

• website/api/controllers/android-proxy/create-android-signup-url.js

[Copilot]

Pull request overview

Updates the website Sails Android proxy create-android-signup-url controller to add explicit handling for Android Management API rate limiting (HTTP 429) when checking whether an existing enterprise is still present in Google, so the proxy can emit an alerting log and fail with a clearer error.

Changes:

• Added a .intercept({status: 429}, ...) on the getIsEnterpriseManagedByFleet helper call to log a p1: warning and return a new Error on rate limits.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@website/api/controllers/microsoft-proxy/create-compliance-partner-tenant.js`:
- Line 19: Update the success description in the compliance partner tenant
controller to replace the misspelled “Fleet isntance” wording with “Fleet
instance,” leaving the rest of the user-facing message unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c463e3c6-c208-48da-8a15-87e5056ce246

📥 Commits

Reviewing files that changed from the base of the PR and between f45de1b and 7447adf.

📒 Files selected for processing (1)

• website/api/controllers/microsoft-proxy/create-compliance-partner-tenant.js