Skip to content

Accept .py path-referenced packages in GitOps - #49387

Merged
cdcme merged 1 commit into
feat/41470-python-script-onlyfrom
fix-49370-gitops-path-py
Jul 16, 2026
Merged

Accept .py path-referenced packages in GitOps#49387
cdcme merged 1 commit into
feat/41470-python-script-onlyfrom
fix-49370-gitops-path-py

Conversation

@cdcme

@cdcme cdcme commented Jul 16, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #49370

fleetctl gitops rejected a local path:-referenced .py software package client-side with unsupported extension ".py", even though a url:-referenced .py worked end-to-end. The package-path switch and the two HydrateToPackageLevel gates (team-level advanced options + icon) only recognized .sh/.ps1. They now use fleet.IsScriptPackage, so .py is accepted — and future script types won't drift out of sync.

Checklist for submitter

  • Changes file: N/A — unreleased fix on the #41470 feature branch; the feature PR (Allow Python script-only packages #49070) carries the changes file.
  • Input data is properly validated (extension-gating fix only; no new input handling, SQL, or shell interpolation).

Testing

  • Added/updated automated tests — TestScriptOnlyPackagesPathPy (path .py with team-level self-service, uninstall/post-install scripts, pre-install query, and icon); confirmed it fails without the fix and passes with it. Also updated a sibling test's error-string assertion.
  • QA'd all new/changed functionality manually — live before/after with the real fleetctl binary: unfixed → unsupported extension ".py"; fixed → gitops dry run succeeded, and a real apply persisted the package with source: py_packages.

@cdcme
cdcme requested a review from a team as a code owner July 16, 2026 00:26
@cdcme cdcme linked an issue Jul 16, 2026 that may be closed by this pull request
2 tasks
@cdcme
cdcme merged commit 0ee839c into feat/41470-python-script-only Jul 16, 2026
29 checks passed
@cdcme
cdcme deleted the fix-49370-gitops-path-py branch July 16, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitOps: local path:-referenced .py script-only packages are rejected

2 participants