Accept .py path-referenced packages in GitOps - #49387
Merged
Merged
Conversation
2 tasks
jkatz01
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #49370
fleetctl gitopsrejected a localpath:-referenced.pysoftware package client-side withunsupported extension ".py", even though aurl:-referenced.pyworked end-to-end. The package-pathswitchand the twoHydrateToPackageLevelgates (team-level advanced options + icon) only recognized.sh/.ps1. They now usefleet.IsScriptPackage, so.pyis accepted — and future script types won't drift out of sync.Checklist for submitter
#41470feature branch; the feature PR (Allow Python script-only packages #49070) carries the changes file.Testing
TestScriptOnlyPackagesPathPy(path.pywith team-level self-service, uninstall/post-install scripts, pre-install query, and icon); confirmed it fails without the fix and passes with it. Also updated a sibling test's error-string assertion.fleetctlbinary: unfixed →unsupported extension ".py"; fixed →gitops dry run succeeded, and a real apply persisted the package withsource: py_packages.