Skip to content

Fix multi-package host software details - #49335

Merged
cdcme merged 4 commits into
feat/28108-multiple-custom-packagesfrom
fix-49208-multi-packages-installer-details
Jul 15, 2026
Merged

Fix multi-package host software details#49335
cdcme merged 4 commits into
feat/28108-multiple-custom-packagesfrom
fix-49208-multi-packages-installer-details

Conversation

@cdcme

@cdcme cdcme commented Jul 15, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #49208

Host software details now show the status and install details for the installer scoped to the host, for titles with multiple packages.

No changes/ file: this is an unreleased bug fix, and the multiple-packages feature PR carries the changes entry.

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

@cdcme
cdcme requested a review from a team as a code owner July 15, 2026 14:10
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.10345% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/28108-multiple-custom-packages@f29ecfa). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/datastore/mysql/software.go 93.10% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##             feat/28108-multiple-custom-packages   #49335   +/-   ##
======================================================================
  Coverage                                       ?   68.11%           
======================================================================
  Files                                          ?     3768           
  Lines                                          ?   239475           
  Branches                                       ?    12552           
======================================================================
  Hits                                           ?   163110           
  Misses                                         ?    61668           
  Partials                                       ?    14697           
Flag Coverage Δ
backend 69.61% <93.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cdcme cdcme linked an issue Jul 15, 2026 that may be closed by this pull request
2 tasks
return host
}

seedInstall := func(hostID, installerID uint, executionID string, at time.Time, exitCode int) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this test maybe use InsertSoftwareInstallRequest() / InsertSoftwareUninstallRequest() to be a bit more realistic?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but since this test targets the read path (not the write path, already covered by testSetHostSoftwareInstallResult), the raw rows are the minimal fixture and stay consistent with the neighboring multi-package tests.

@cdcme
cdcme merged commit 90857fe into feat/28108-multiple-custom-packages Jul 15, 2026
36 checks passed
@cdcme
cdcme deleted the fix-49208-multi-packages-installer-details branch July 15, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple packages status/details for wrong installer are shown

2 participants