Fix multi-package host software details - #49335
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/28108-multiple-custom-packages #49335 +/- ##
======================================================================
Coverage ? 68.11%
======================================================================
Files ? 3768
Lines ? 239475
Branches ? 12552
======================================================================
Hits ? 163110
Misses ? 61668
Partials ? 14697
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| return host | ||
| } | ||
|
|
||
| seedInstall := func(hostID, installerID uint, executionID string, at time.Time, exitCode int) { |
There was a problem hiding this comment.
Could this test maybe use InsertSoftwareInstallRequest() / InsertSoftwareUninstallRequest() to be a bit more realistic?
There was a problem hiding this comment.
We could, but since this test targets the read path (not the write path, already covered by testSetHostSoftwareInstallResult), the raw rows are the minimal fixture and stay consistent with the neighboring multi-package tests.
Related issue: Resolves #49208
Host software details now show the status and install details for the installer scoped to the host, for titles with multiple packages.
No
changes/file: this is an unreleased bug fix, and the multiple-packages feature PR carries the changes entry.Checklist for submitter
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Testing