[Activity] Patch policies: Install new version when app is closed - #49106
Merged
Conversation
Added explanation for 'install_skipped_when_app_open' field in audit logs.
58 tasks
marko-lisica
commented
Jul 10, 2026
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rachaelshaw
requested changes
Jul 22, 2026
Co-authored-by: Rachael Shaw <r@rachael.wtf>
This was referenced Aug 11, 2026
cdcme
added a commit
that referenced
this pull request
Aug 14, 2026
**Related issue:** Resolves #51052 Renames the `installed_software` activity detail flag from `install_skipped_when_app_open` to `skipped_install`, the name Product approved and the one `docs-v4.91.0` already publishes (`audit-logs.md:1661`). The implementation (#49858) landed six days before the activity docs (#49106), so the two diverged; since patch-when-closed is unreleased, this renames outright rather than aliasing. The name is deliberately reason-agnostic: #39178 will set the same flag for a second skip reason (notify-then-defer), where `install_skipped_when_app_open` would be false. Rename only — no behavior change. Covers the JSON tag, the Go field (`InstallSkippedWhenAppOpen` → `SkippedInstall`), and the frontend, where all four readers were swept: activity feed, host activity card, policy automations table, and the install-details modal (including its `installSkippedWhenAppOpen` prop). No endpoint paths changed. Deliberately unchanged: `isAppOpenSkip` in `orbit.go` still names the detection of the app-open case specifically, and the pre-existing frontend-only `"skipped_install"` display status (`interfaces/software.ts`) is not an API value — after this rename the two simply agree. No changes file: `~unreleased bug`, and `changes/39962-patch-when-closed` already covers the feature. No migration: activity details are an opaque `activity_past.details` JSON blob and no SQL reads this key. A `renameto:` alias was considered and rejected — aliases are applied before the INSERT, so it would permanently double-write a never-released key into every row. > [!IMPORTANT] > `rc-minor-fleet-v4.91.0` was cut on 2026-08-11 and still carries the old name. This needs a cherry-pick into that branch before the 4.91.0 cut, or 4.91.0 ships `install_skipped_when_app_open` while its own reference docs document `skipped_install`. # Checklist for submitter ## Testing - [x] Added/updated automated tests - [ ] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [x] Confirmed that the fix is not expected to adversely impact load test results <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Updated installed-software activity handling to consistently identify installations skipped because the app was open. * Preserved skipped-install status messages, labels, icons, and detail visibility across activity views and policy automation tables. * **Refactor** * Standardized the activity field name used for skipped installations across the application. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
rachaelshaw
pushed a commit
that referenced
this pull request
Aug 25, 2026
) **Related issue:** #51052 The `installed_software` activity reference cross-referenced the patch policy field as `patch_only_when_closed`. The field has always been `patch_when_closed` in GitOps and the API — the old name only ever existed in docs. `yaml-files.md` was corrected during review; this line was missed and carried onto this branch by #49106. The `skipped_install` key documented on the same line is already correct and unchanged — that name is what #51102 renames the code to match. Docs-only, one line. # Checklist for submitter ## Testing - [ ] QA'd all new/changed functionality manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: