Skip to content

Fix missing space in EndUserAuthSection help text - #48979

Closed
allenhouchins wants to merge 1 commit into
mainfrom
allenhouchins-fix-spacing
Closed

Fix missing space in EndUserAuthSection help text#48979
allenhouchins wants to merge 1 commit into
mainfrom
allenhouchins-fix-spacing

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Jul 8, 2026

Copy link
Copy Markdown
Member

Adds a missing space between "Full name" and "in Setup Assistant" to prevent words from running together in the UI.

Related issue: Resolves #

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

  • Timeouts are implemented and retries are limited to avoid infinite loops

  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results
  • Alerted the release DRI if additional load testing is needed

Database migrations

  • Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

New Fleet configuration settings

  • Setting(s) is/are explicitly excluded from GitOps

If you didn't check the box above, follow this checklist for GitOps-enabled settings:

  • Verified that the setting is exported via fleetctl generate-gitops
  • Verified the setting is documented in a separate PR to the GitOps documentation
  • Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)
  • Verified that any relevant UI is disabled when GitOps mode is enabled

fleetd/orbit/Fleet Desktop

  • Verified compatibility with the latest released version of Fleet (see Must rule)
  • If the change applies to only one platform, confirmed that runtime.GOOS is used as needed to isolate changes
  • Verified that fleetd runs on macOS, Linux and Windows
  • Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

Summary by CodeRabbit

  • Style
    • Improved the help text formatting for the “Lock end user info” option.
    • Adjusted spacing around the bolded “Account Name” and “Full name” labels for better readability.

Adds a missing space between "Full name" and "in Setup Assistant" to prevent words from running together in the UI.
@allenhouchins
allenhouchins marked this pull request as ready for review July 8, 2026 20:05
@allenhouchins
allenhouchins requested a review from a team as a code owner July 8, 2026 20:05
Copilot AI review requested due to automatic review settings July 8, 2026 20:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a minor UI text formatting issue in the “Lock end user info” checkbox help text so the words don’t run together after the <strong>Full name</strong> fragment.

Changes:

  • Adds an explicit JSX whitespace ({" "}) after the “Full name” <strong> element in the help text.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 78d6663d-58db-47f3-9520-c61bddb7811a

📥 Commits

Reviewing files that changed from the base of the PR and between 4449830 and fcbd717.

📒 Files selected for processing (1)
  • frontend/pages/ManageControlsPage/SetupExperience/cards/Users/components/UsersForm/components/EndUserAuthSection/EndUserAuthSection.tsx

Walkthrough

This change modifies a single line of text formatting in the EndUserAuthSection component. The help text for the "Lock end user info" checkbox was updated to adjust whitespace around the bolded "Account Name" and "Full name" labels. No functional or structural code changes were made, and no exported or public entities were altered.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the EndUserAuthSection spacing fix.
Description check ✅ Passed The description follows the template and explains the UI spacing fix, though the related issue line is still a placeholder.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-fix-spacing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.12%. Comparing base (4449830) to head (fcbd717).

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #48979    +/-   ##
========================================
  Coverage   68.12%   68.12%            
========================================
  Files        3717     3717            
  Lines      235203   235203            
  Branches    12515    12369   -146     
========================================
  Hits       160223   160223            
  Misses      60604    60604            
  Partials    14376    14376            
Flag Coverage Δ
frontend 59.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MagnusHJensen

Copy link
Copy Markdown
Member

This was fixed by: #49074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants