Update Fleet-maintained apps - #48906
Closed
fleet-release wants to merge 1 commit into
Closed
Conversation
Generated automatically with cmd/maintained-apps.
Contributor
Script Diff Resultsee/maintained-apps/outputs/adguard/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/aptakube/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/bezel/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/bitrix24/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/bitwig-studio/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/claude/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/cloudflare-warp/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/dbvisualizer/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/docker/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/dockside/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/element/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/elgato-wave-link/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/firefox/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/forklift/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/hive-app/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/knime/darwin.json=== Install // c72d935a -> 3c077491 ===
--- /tmp/old.xMtWxy 2026-07-07 20:08:31.131795878 +0000
+++ /tmp/new.sm3noz 2026-07-07 20:08:31.131795878 +0000
@@ -101,8 +101,8 @@
hdiutil detach "$MOUNT_POINT" || true
# copy to the applications folder
quit_and_track_application 'org.knime.product'
-if [ -d "$APPDIR/KNIME 5.8.3.app" ]; then
- sudo mv "$APPDIR/KNIME 5.8.3.app" "$TMPDIR/KNIME 5.8.3.app.bkp"
+if [ -d "$APPDIR/KNIME 5.12.0.app" ]; then
+ sudo mv "$APPDIR/KNIME 5.12.0.app" "$TMPDIR/KNIME 5.12.0.app.bkp"
fi
-sudo cp -R "$TMPDIR/KNIME 5.8.3.app" "$APPDIR"
+sudo cp -R "$TMPDIR/KNIME 5.12.0.app" "$APPDIR"
relaunch_application 'org.knime.product'
=== Uninstall // cb0b822a -> c9b745d8 ===
--- /tmp/old.T8OpkA 2026-07-07 20:08:31.148795803 +0000
+++ /tmp/new.a7XQV5 2026-07-07 20:08:31.148795803 +0000
@@ -52,7 +52,7 @@
fi
}
-sudo rm -rf "$APPDIR/KNIME 5.8.3.app"
+sudo rm -rf "$APPDIR/KNIME 5.12.0.app"
trash $LOGGED_IN_USER '~/Library/Caches/org.knime.product'
trash $LOGGED_IN_USER '~/Library/Preferences/org.knime.product.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/org.knime.product.savedState'ee/maintained-apps/outputs/masscode/darwin.json=== Install Script (no changes) ===
=== Uninstall // 39171b71 -> 02f458b9 ===
--- /tmp/old.5Fy4Sb 2026-07-07 20:08:31.195795596 +0000
+++ /tmp/new.zo91Xv 2026-07-07 20:08:31.195795596 +0000
@@ -54,6 +54,8 @@
sudo rm -rf "$APPDIR/massCode.app"
sudo rmdir '~/massCode'
-trash $LOGGED_IN_USER '~/Library/Application Support/massCode'
+trash $LOGGED_IN_USER '~/.massCode'
+trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/io.masscode.app.sfl*'
+trash $LOGGED_IN_USER '~/Library/Application Support/masscode'
trash $LOGGED_IN_USER '~/Library/Preferences/io.masscode.app.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/io.masscode.app.savedState'ee/maintained-apps/outputs/microsoft-excel/darwin.json=== Install // eb617288 -> 8dd8cff8 ===
--- /tmp/old.SmBpUe 2026-07-07 20:08:31.246795371 +0000
+++ /tmp/new.1Z7cCp 2026-07-07 20:08:31.247795367 +0000
@@ -117,6 +117,6 @@
EOF
-sudo installer -pkg "$TMPDIR"/Microsoft_Excel_16.110.26062818_Installer.pkg -target / -applyChoiceChangesXML "$CHOICE_XML"
+sudo installer -pkg "$TMPDIR"/Microsoft_Excel_16.110.26070318_Installer.pkg -target / -applyChoiceChangesXML "$CHOICE_XML"
relaunch_application 'com.microsoft.Excel'
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/microsoft-powerpoint/darwin.json=== Install // 4a7cc8ae -> fc3e906d ===
--- /tmp/old.fI9JzR 2026-07-07 20:08:31.299795137 +0000
+++ /tmp/new.pqkJk1 2026-07-07 20:08:31.299795137 +0000
@@ -117,6 +117,6 @@
EOF
-sudo installer -pkg "$TMPDIR"/Microsoft_PowerPoint_16.110.26062818_Installer.pkg -target / -applyChoiceChangesXML "$CHOICE_XML"
+sudo installer -pkg "$TMPDIR"/Microsoft_PowerPoint_16.110.26070318_Installer.pkg -target / -applyChoiceChangesXML "$CHOICE_XML"
relaunch_application 'com.microsoft.Powerpoint'
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/microsoft-word/darwin.json=== Install // 481e55cb -> 3adefd29 ===
--- /tmp/old.Gk6Msi 2026-07-07 20:08:31.352794903 +0000
+++ /tmp/new.fStEgl 2026-07-07 20:08:31.352794903 +0000
@@ -117,6 +117,6 @@
EOF
-sudo installer -pkg "$TMPDIR"/Microsoft_Word_16.110.26062818_Installer.pkg -target / -applyChoiceChangesXML "$CHOICE_XML"
+sudo installer -pkg "$TMPDIR"/Microsoft_Word_16.110.26070318_Installer.pkg -target / -applyChoiceChangesXML "$CHOICE_XML"
relaunch_application 'com.microsoft.Word'
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/musescore/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/opencode-desktop/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/origami-studio/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/portfolioperformance/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/portfolioperformance/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/postman/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/postman/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/proton-pass/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/runjs/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/shapr3d/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/stats/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/telegram/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/vscodium/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/webcatalog/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/whatsapp/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/worksheet-crafter/darwin.json=== Install // 545289c7 -> 9be99456 ===
--- /tmp/old.6uH9TI 2026-07-07 20:08:32.048791832 +0000
+++ /tmp/new.lPDdPA 2026-07-07 20:08:32.048791832 +0000
@@ -96,5 +96,5 @@
# install pkg files
quit_and_track_application 'com.SchoolCraft.WillBeReplacedByQMake'
-sudo installer -pkg "$TMPDIR/worksheet-crafter_2026.2.4.pkg" -target /
+sudo installer -pkg "$TMPDIR/worksheet-crafter_2026.2.11.pkg" -target /
relaunch_application 'com.SchoolCraft.WillBeReplacedByQMake'
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/zotero/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) === |
Contributor
WalkthroughThis PR updates version metadata across numerous Fleet-maintained app output JSON manifests (macOS/Windows). Changes include bumping Sequence Diagram(s)No sequence diagram generated, as these are data-only manifest version bumps without a meaningful runtime interaction flow to depict. Possibly related PRs
Suggested labels fleet-ee, maintained-apps Suggested reviewers None specified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/knime/darwin.json`:
- Around line 9-20: The install and uninstall scripts are hardcoded to the
versioned bundle name, which can miss the real app bundle across upgrades.
Update the KNIME app handling in the install_script_ref and uninstall_script_ref
scripts to use the stable KNIME.app bundle name consistently for the copy, move,
and removal logic, and make sure the relaunch/quit checks still target the same
KNIME application bundle identifier.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 16ad4a9b-e525-4c9a-8e21-a81ff5d50dc6
📒 Files selected for processing (37)
ee/maintained-apps/outputs/adguard/darwin.jsonee/maintained-apps/outputs/aptakube/windows.jsonee/maintained-apps/outputs/bezel/darwin.jsonee/maintained-apps/outputs/bitrix24/darwin.jsonee/maintained-apps/outputs/bitwig-studio/darwin.jsonee/maintained-apps/outputs/claude/darwin.jsonee/maintained-apps/outputs/cloudflare-warp/windows.jsonee/maintained-apps/outputs/dbvisualizer/darwin.jsonee/maintained-apps/outputs/docker/windows.jsonee/maintained-apps/outputs/dockside/darwin.jsonee/maintained-apps/outputs/element/darwin.jsonee/maintained-apps/outputs/elgato-wave-link/darwin.jsonee/maintained-apps/outputs/firefox/darwin.jsonee/maintained-apps/outputs/forklift/darwin.jsonee/maintained-apps/outputs/hive-app/darwin.jsonee/maintained-apps/outputs/knime/darwin.jsonee/maintained-apps/outputs/masscode/darwin.jsonee/maintained-apps/outputs/microsoft-excel/darwin.jsonee/maintained-apps/outputs/microsoft-powerpoint/darwin.jsonee/maintained-apps/outputs/microsoft-word/darwin.jsonee/maintained-apps/outputs/musescore/darwin.jsonee/maintained-apps/outputs/opencode-desktop/darwin.jsonee/maintained-apps/outputs/origami-studio/darwin.jsonee/maintained-apps/outputs/portfolioperformance/darwin.jsonee/maintained-apps/outputs/portfolioperformance/windows.jsonee/maintained-apps/outputs/postman/darwin.jsonee/maintained-apps/outputs/postman/windows.jsonee/maintained-apps/outputs/proton-pass/darwin.jsonee/maintained-apps/outputs/runjs/darwin.jsonee/maintained-apps/outputs/shapr3d/darwin.jsonee/maintained-apps/outputs/stats/darwin.jsonee/maintained-apps/outputs/telegram/darwin.jsonee/maintained-apps/outputs/vscodium/darwin.jsonee/maintained-apps/outputs/webcatalog/darwin.jsonee/maintained-apps/outputs/whatsapp/darwin.jsonee/maintained-apps/outputs/worksheet-crafter/darwin.jsonee/maintained-apps/outputs/zotero/darwin.json
Comment on lines
+9
to
+20
| "installer_url": "https://download.knime.org/analytics-platform/macosx/knime_5.12.0.app.macosx.cocoa.aarch64.dmg", | ||
| "install_script_ref": "3c077491", | ||
| "uninstall_script_ref": "c9b745d8", | ||
| "sha256": "a7e28a83be9e7af38677bf9764c36cf88bc44066744ba47c1a3b93c0d689dea7", | ||
| "default_categories": [ | ||
| "Productivity" | ||
| ] | ||
| } | ||
| ], | ||
| "refs": { | ||
| "c72d935a": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# extract contents\nMOUNT_POINT=$(mktemp -d /tmp/dmg_mount_XXXXXX)\nyes | hdiutil attach -plist -nobrowse -readonly -mountpoint \"$MOUNT_POINT\" \"$INSTALLER_PATH\" || exit 1\nsudo cp -R \"$MOUNT_POINT\"/* \"$TMPDIR\"\nhdiutil detach \"$MOUNT_POINT\" || true\n# copy to the applications folder\nquit_and_track_application 'org.knime.product'\nif [ -d \"$APPDIR/KNIME 5.8.3.app\" ]; then\n\tsudo mv \"$APPDIR/KNIME 5.8.3.app\" \"$TMPDIR/KNIME 5.8.3.app.bkp\"\nfi\nsudo cp -R \"$TMPDIR/KNIME 5.8.3.app\" \"$APPDIR\"\nrelaunch_application 'org.knime.product'\n", | ||
| "cb0b822a": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/KNIME 5.8.3.app\"\ntrash $LOGGED_IN_USER '~/Library/Caches/org.knime.product'\ntrash $LOGGED_IN_USER '~/Library/Preferences/org.knime.product.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/org.knime.product.savedState'\n" | ||
| "3c077491": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# extract contents\nMOUNT_POINT=$(mktemp -d /tmp/dmg_mount_XXXXXX)\nyes | hdiutil attach -plist -nobrowse -readonly -mountpoint \"$MOUNT_POINT\" \"$INSTALLER_PATH\" || exit 1\nsudo cp -R \"$MOUNT_POINT\"/* \"$TMPDIR\"\nhdiutil detach \"$MOUNT_POINT\" || true\n# copy to the applications folder\nquit_and_track_application 'org.knime.product'\nif [ -d \"$APPDIR/KNIME 5.12.0.app\" ]; then\n\tsudo mv \"$APPDIR/KNIME 5.12.0.app\" \"$TMPDIR/KNIME 5.12.0.app.bkp\"\nfi\nsudo cp -R \"$TMPDIR/KNIME 5.12.0.app\" \"$APPDIR\"\nrelaunch_application 'org.knime.product'\n", | ||
| "c9b745d8": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/KNIME 5.12.0.app\"\ntrash $LOGGED_IN_USER '~/Library/Caches/org.knime.product'\ntrash $LOGGED_IN_USER '~/Library/Preferences/org.knime.product.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/org.knime.product.savedState'\n" |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify how KNIME's naming convention is handled by the ingestion tooling,
# and check whether prior knime/darwin.json versions also embedded the version in the app name.
fd -a knime.go maintained-apps 2>/dev/null
rg -n "KNIME" ee/maintained-apps -g '*.go' -C3Repository: fleetdm/fleet
Length of output: 151
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== KNIME-related files =="
git ls-files | rg 'ee/maintained-apps/.*/knime|knime|maintained-apps/.+darwin\.json|maintained-apps/.+outputs/.+knime' || true
echo
echo "== Current KNIME output entries =="
rg -n '"installer_url"|KNIME|install_script_ref|uninstall_script_ref' ee/maintained-apps/outputs -g '*knime*' -C2 || true
echo
echo "== KNIME generator/source references =="
rg -n "KNIME|knime" ee/maintained-apps -g '*.go' -g '*.json' -g '*.yaml' -g '*.yml' -C3 || trueRepository: fleetdm/fleet
Length of output: 50369
🌐 Web query:
KNIME macOS bundle name versioned app "KNIME 5.12.0.app" "KNIME.app"
💡 Result:
On macOS, the KNIME Analytics Platform application is officially named and distributed as KNIME.app [1][2][3]. While users or IT departments may occasionally rename the application bundle on their local file system—for example, to "KNIME 4.3.1.app" to distinguish between multiple installed versions [4][5]—the standard installation process provided by KNIME documentation instructs users to move the "KNIME" icon to the Applications folder, resulting in the "KNIME.app" bundle [2][3]. There is no official "KNIME 5.12.0.app" naming convention; the bundle name remains "KNIME.app" regardless of the internal software version [2][6][7]. If you need to verify the version of an installed KNIME instance, you should launch the application and check the "About" menu or inspect the internal configuration files located within the package [1][2]. To access these internal files, you can right-click on "KNIME.app" in Finder, select "Show Package Contents," and navigate to the "Contents" directory [1][7].
Citations:
- 1: https://www.knime.com/faq
- 2: https://docs.knime.com/ap/latest/analytics_platform_installation_guide/
- 3: https://docs.knime.com/ap/5.2/analytics_platform_installation_guide.pdf
- 4: https://forum.knime.com/t/knime-info-plist-error-on-mac/64969
- 5: https://forum.knime.com/t/knime-platform-quits-unexpectedly-macbook-pro-with-apple-m1-chip-and-macos-bigsur/29230
- 6: https://docs.knime.com/ap/5.8/analytics_platform_installation_guide/
- 7: https://docs.knime.com/ap/latest/analytics_platform_user_guide/
Use the stable KNIME.app bundle name KNIME 5.12.0.app is version-specific and will miss the actual macOS bundle, so install/uninstall won’t correctly replace/remove KNIME across upgrades.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/knime/darwin.json` around lines 9 - 20, The
install and uninstall scripts are hardcoded to the versioned bundle name, which
can miss the real app bundle across upgrades. Update the KNIME app handling in
the install_script_ref and uninstall_script_ref scripts to use the stable
KNIME.app bundle name consistently for the copy, move, and removal logic, and
make sure the relaunch/quit checks still target the same KNIME application
bundle identifier.
Contributor
|
Closing in favor of #48920. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit