Update Fleet-maintained apps - #48848
Closed
fleet-release wants to merge 1 commit into
Closed
Conversation
Generated automatically with cmd/maintained-apps.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Script Diff Resultsee/maintained-apps/outputs/adguard/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/aptakube/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/docker/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/elgato-wave-link/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/hive-app/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/knime/darwin.json=== Install // c72d935a -> 3c077491 ===
--- /tmp/old.XA1xRo 2026-07-07 12:51:22.127168658 +0000
+++ /tmp/new.UMuCSI 2026-07-07 12:51:22.127168658 +0000
@@ -101,8 +101,8 @@
hdiutil detach "$MOUNT_POINT" || true
# copy to the applications folder
quit_and_track_application 'org.knime.product'
-if [ -d "$APPDIR/KNIME 5.8.3.app" ]; then
- sudo mv "$APPDIR/KNIME 5.8.3.app" "$TMPDIR/KNIME 5.8.3.app.bkp"
+if [ -d "$APPDIR/KNIME 5.12.0.app" ]; then
+ sudo mv "$APPDIR/KNIME 5.12.0.app" "$TMPDIR/KNIME 5.12.0.app.bkp"
fi
-sudo cp -R "$TMPDIR/KNIME 5.8.3.app" "$APPDIR"
+sudo cp -R "$TMPDIR/KNIME 5.12.0.app" "$APPDIR"
relaunch_application 'org.knime.product'
=== Uninstall // cb0b822a -> c9b745d8 ===
--- /tmp/old.fQFs5V 2026-07-07 12:51:22.144168786 +0000
+++ /tmp/new.AMves1 2026-07-07 12:51:22.144168786 +0000
@@ -52,7 +52,7 @@
fi
}
-sudo rm -rf "$APPDIR/KNIME 5.8.3.app"
+sudo rm -rf "$APPDIR/KNIME 5.12.0.app"
trash $LOGGED_IN_USER '~/Library/Caches/org.knime.product'
trash $LOGGED_IN_USER '~/Library/Preferences/org.knime.product.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/org.knime.product.savedState'ee/maintained-apps/outputs/masscode/darwin.json=== Install Script (no changes) ===
=== Uninstall // 39171b71 -> 02f458b9 ===
--- /tmp/old.yyoYLZ 2026-07-07 12:51:22.192169149 +0000
+++ /tmp/new.5l8X4I 2026-07-07 12:51:22.192169149 +0000
@@ -54,6 +54,8 @@
sudo rm -rf "$APPDIR/massCode.app"
sudo rmdir '~/massCode'
-trash $LOGGED_IN_USER '~/Library/Application Support/massCode'
+trash $LOGGED_IN_USER '~/.massCode'
+trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/io.masscode.app.sfl*'
+trash $LOGGED_IN_USER '~/Library/Application Support/masscode'
trash $LOGGED_IN_USER '~/Library/Preferences/io.masscode.app.plist'
trash $LOGGED_IN_USER '~/Library/Saved Application State/io.masscode.app.savedState'ee/maintained-apps/outputs/portfolioperformance/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/portfolioperformance/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/whatsapp/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/worksheet-crafter/darwin.json=== Install // 545289c7 -> 9be99456 ===
--- /tmp/old.phbHIr 2026-07-07 12:51:22.370170491 +0000
+++ /tmp/new.IJxggi 2026-07-07 12:51:22.370170491 +0000
@@ -96,5 +96,5 @@
# install pkg files
quit_and_track_application 'com.SchoolCraft.WillBeReplacedByQMake'
-sudo installer -pkg "$TMPDIR/worksheet-crafter_2026.2.4.pkg" -target /
+sudo installer -pkg "$TMPDIR/worksheet-crafter_2026.2.11.pkg" -target /
relaunch_application 'com.SchoolCraft.WillBeReplacedByQMake'
=== Uninstall Script (no changes) === |
Contributor
WalkthroughThis PR updates version metadata across multiple Fleet-maintained app manifests: AdGuard, Aptakube, Docker Desktop, Elgato Wave Link, Hive, KNIME, massCode, Portfolio Performance (macOS and Windows), WhatsApp, and worksheet-crafter. Each entry's version string, patched-version SQL comparison threshold, installer URL, and SHA-256 checksum are refreshed to the new release. Additionally, KNIME's install/uninstall bash scripts, massCode's uninstall script, and worksheet-crafter's install script are updated to reference new bundle paths, filenames, or removal logic corresponding to the new versions. Changes
Sequence Diagram(s)Not applicable — this PR consists of flat configuration/metadata updates without new control flow. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/masscode/darwin.json`:
- Line 19: The uninstall script still leaves the massCode home directory behind
because `sudo rmdir '~/massCode'` passes a quoted tilde, so it never resolves to
the logged-in user’s home. Update the cleanup logic in this script to remove
`~/massCode` the same way the other home-relative paths are handled, either by
routing it through `trash()` or by using the existing `LOGGED_IN_USER`/home
expansion approach. Keep the fix aligned with the existing `trash` function and
the other uninstall paths in this JSON entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 15cf0021-df30-453c-b329-b4cd576c7f9b
📒 Files selected for processing (11)
ee/maintained-apps/outputs/adguard/darwin.jsonee/maintained-apps/outputs/aptakube/windows.jsonee/maintained-apps/outputs/docker/windows.jsonee/maintained-apps/outputs/elgato-wave-link/darwin.jsonee/maintained-apps/outputs/hive-app/darwin.jsonee/maintained-apps/outputs/knime/darwin.jsonee/maintained-apps/outputs/masscode/darwin.jsonee/maintained-apps/outputs/portfolioperformance/darwin.jsonee/maintained-apps/outputs/portfolioperformance/windows.jsonee/maintained-apps/outputs/whatsapp/darwin.jsonee/maintained-apps/outputs/worksheet-crafter/darwin.json
| "refs": { | ||
| "0a664ca4": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# extract contents\nMOUNT_POINT=$(mktemp -d /tmp/dmg_mount_XXXXXX)\nyes | hdiutil attach -plist -nobrowse -readonly -mountpoint \"$MOUNT_POINT\" \"$INSTALLER_PATH\" || exit 1\nsudo cp -R \"$MOUNT_POINT\"/* \"$TMPDIR\"\nhdiutil detach \"$MOUNT_POINT\" || true\n# copy to the applications folder\nquit_and_track_application 'io.masscode.app'\nif [ -d \"$APPDIR/massCode.app\" ]; then\n\tsudo mv \"$APPDIR/massCode.app\" \"$TMPDIR/massCode.app.bkp\"\nfi\nsudo cp -R \"$TMPDIR/massCode.app\" \"$APPDIR\"\nrelaunch_application 'io.masscode.app'\n", | ||
| "39171b71": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/massCode.app\"\nsudo rmdir '~/massCode'\ntrash $LOGGED_IN_USER '~/Library/Application Support/massCode'\ntrash $LOGGED_IN_USER '~/Library/Preferences/io.masscode.app.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/io.masscode.app.savedState'\n" | ||
| "02f458b9": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/massCode.app\"\nsudo rmdir '~/massCode'\ntrash $LOGGED_IN_USER '~/.massCode'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/io.masscode.app.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/masscode'\ntrash $LOGGED_IN_USER '~/Library/Preferences/io.masscode.app.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/io.masscode.app.savedState'\n", |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Uninstall leaves ~/massCode behind — tilde isn't expanded.
sudo rmdir '~/massCode' single-quotes the tilde, so bash never expands it to the user's home directory; the command targets a literal, effectively non-existent path and silently fails to remove any real files. It's also inconsistent with the rest of the script, which routes all home-relative paths through the trash() helper that manually substitutes ~ for /Users/$logged_in_user.
🧹 Proposed fix
-sudo rmdir '~/massCode'
-trash $LOGGED_IN_USER '~/.massCode'
+trash $LOGGED_IN_USER '~/massCode'
+trash $LOGGED_IN_USER '~/.massCode'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "02f458b9": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n\n # If the target contains glob characters, expand it and move each match.\n if [[ \"$target_file\" == *[*?[]* ]]; then\n local file file_name\n local matched=false\n local i=0\n # compgen -G expands the (quoted) pattern itself, so paths containing\n # spaces glob correctly; reading line by line keeps each match intact.\n while IFS= read -r file; do\n [[ -n \"$file\" ]] || continue\n [[ -e \"$file\" || -L \"$file\" ]] || continue\n matched=true\n i=$((i + 1))\n file_name=\"$(basename \"$file\")\"\n echo \"removing $file.\"\n # The per-match counter keeps matches that share a basename from\n # overwriting each other in the trash.\n mv -f \"$file\" \"$trash/${file_name}_${timestamp}_${rand}_${i}\"\n done < <(compgen -G \"$target_file\" 2>/dev/null)\n if [[ \"$matched\" == false ]]; then\n echo \"$target_file doesn't exist.\"\n fi\n return\n fi\n\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsudo rm -rf \"$APPDIR/massCode.app\"\nsudo rmdir '~/massCode'\ntrash $LOGGED_IN_USER '~/.massCode'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/io.masscode.app.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/masscode'\ntrash $LOGGED_IN_USER '~/Library/Preferences/io.masscode.app.plist'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/io.masscode.app.savedState'\n", | |
| sudo rm -rf "$APPDIR/massCode.app" | |
| trash $LOGGED_IN_USER '~/massCode' | |
| trash $LOGGED_IN_USER '~/.massCode' | |
| trash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/io.masscode.app.sfl*' | |
| trash $LOGGED_IN_USER '~/Library/Application Support/masscode' | |
| trash $LOGGED_IN_USER '~/Library/Preferences/io.masscode.app.plist' | |
| trash $LOGGED_IN_USER '~/Library/Saved Application State/io.masscode.app.savedState' |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/masscode/darwin.json` at line 19, The uninstall
script still leaves the massCode home directory behind because `sudo rmdir
'~/massCode'` passes a quoted tilde, so it never resolves to the logged-in
user’s home. Update the cleanup logic in this script to remove `~/massCode` the
same way the other home-relative paths are handled, either by routing it through
`trash()` or by using the existing `LOGGED_IN_USER`/home expansion approach.
Keep the fix aligned with the existing `trash` function and the other uninstall
paths in this JSON entry.
Contributor
|
Closing in favor of #48870. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit