Skip to content

Add WinDirStat as a Windows FMA - #48762

Merged
allenhouchins merged 1 commit into
mainfrom
allenhouchins-windirstat
Jul 6, 2026
Merged

Add WinDirStat as a Windows FMA#48762
allenhouchins merged 1 commit into
mainfrom
allenhouchins-windirstat

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Jul 6, 2026

Copy link
Copy Markdown
Member

Adds WinDirStat to maintained apps for Windows by introducing the winget input metadata, generated app output entries, and installer/uninstaller version data. Also adds the WinDirStat icon asset and wires it into the SoftwarePage icon map so the app displays with the correct branding in the UI.

Summary by CodeRabbit

  • New Features
    • Added WinDirStat to the app catalog for Windows, including install and update information.
    • Added a WinDirStat app icon so it displays correctly in the software list.
    • Included version details and uninstall/install handling to improve availability and management of the app.

Adds WinDirStat to maintained apps for Windows by introducing the winget input metadata, generated app output entries, and installer/uninstaller version data. Also adds the WinDirStat icon asset and wires it into the SoftwarePage icon map so the app displays with the correct branding in the UI.
@allenhouchins
allenhouchins marked this pull request as ready for review July 6, 2026 13:54
@allenhouchins
allenhouchins requested a review from a team as a code owner July 6, 2026 13:54
Copilot AI review requested due to automatic review settings July 6, 2026 13:54
@fleet-release
fleet-release requested a review from eashaw July 6, 2026 13:54

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@allenhouchins allenhouchins changed the title Add WinDirStat maintained app and icon Add WinDirStat as a Windows FMA Jul 6, 2026
@allenhouchins
allenhouchins merged commit 8415ae4 into main Jul 6, 2026
19 of 22 checks passed
@allenhouchins
allenhouchins deleted the allenhouchins-windirstat branch July 6, 2026 13:55
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.02%. Comparing base (9921d7d) to head (348f22c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pages/SoftwarePage/components/icons/Windirstat.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #48762      +/-   ##
==========================================
- Coverage   68.02%   68.02%   -0.01%     
==========================================
  Files        3680     3681       +1     
  Lines      233959   233961       +2     
  Branches    12456    12307     -149     
==========================================
+ Hits       159145   159146       +1     
- Misses      60496    60498       +2     
+ Partials    14318    14317       -1     
Flag Coverage Δ
frontend 58.96% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0162014d-157e-4f65-98b2-7a4795c6444f

📥 Commits

Reviewing files that changed from the base of the PR and between 9921d7d and 348f22c.

⛔ Files ignored due to path filters (1)
  • website/assets/images/app-icon-windirstat-60x60@2x.png is excluded by !**/*.png
📒 Files selected for processing (5)
  • ee/maintained-apps/inputs/winget/windirstat.json
  • ee/maintained-apps/outputs/apps.json
  • ee/maintained-apps/outputs/windirstat/windows.json
  • frontend/pages/SoftwarePage/components/icons/Windirstat.tsx
  • frontend/pages/SoftwarePage/components/icons/index.ts

Walkthrough

This PR adds WinDirStat as a new maintained app. It introduces a winget input JSON with package metadata, an apps.json catalog entry for WinDirStat on Windows, and a windows.json output defining version 2.7.0 with install/uninstall PowerShell scripts using msiexec and COM-based product enumeration. It also adds a new frontend Windirstat SVG icon component and registers it in the software-name-to-icon map.

Changes

  • Added windirstat.json winget input with package identifiers, matching config, installer metadata, and publisher info
  • Added WinDirStat entry to apps.json catalog with slug, unique identifier, and description
  • Added windirstat/windows.json output with version detection SQL, installer URL/checksum, and embedded install/uninstall PowerShell scripts
  • Added Windirstat React icon component rendering an inline SVG
  • Registered windirstat key in SOFTWARE_NAME_TO_ICON_MAP

Possibly related PRs

  • fleetdm/fleet#47000: Adds a similar new Windows app entry to apps.json and icon map wiring for a different app (Cinc).
  • fleetdm/fleet#47046: Adds a new icon component and registers it in SOFTWARE_NAME_TO_ICON_MAP for Beekeeper Studio.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins-windirstat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds WinDirStat as a Windows Fleet-maintained app (winget-backed) and wires a new icon into the Software page icon mapping so the app displays with correct branding.

Changes:

  • Added WinDirStat winget input metadata and generated maintained-app outputs (app listing + Windows version/install/uninstall metadata).
  • Added a WinDirStat icon component and registered it in the Software icon map.
  • Updated the consolidated maintained-apps apps.json catalog to include WinDirStat.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
frontend/pages/SoftwarePage/components/icons/Windirstat.tsx Adds WinDirStat icon asset as an SVG component (base64 PNG).
frontend/pages/SoftwarePage/components/icons/index.ts Registers the WinDirStat icon and maps the windirstat software-name key to it.
ee/maintained-apps/outputs/windirstat/windows.json Adds WinDirStat Windows installer metadata, queries, and install/uninstall script refs.
ee/maintained-apps/outputs/apps.json Adds WinDirStat entry to the maintained-app catalog.
ee/maintained-apps/inputs/winget/windirstat.json Adds winget input metadata for generating WinDirStat Windows output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +6 to +7
"exists": "SELECT 1 FROM programs WHERE name LIKE 'WinDirStat %' AND publisher = 'WinDirStat Team';",
"patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name LIKE 'WinDirStat %' AND publisher = 'WinDirStat Team' AND version_compare(version, '2.7.0') < 0);"
"slug": "windirstat/windows",
"package_identifier": "WinDirStat.WinDirStat",
"unique_identifier": "WinDirStat",
"fuzzy_match_name": true,
}
],
"refs": {
"8959087b": "$logFile = \"${env:TEMP}/fleet-install-software.log\"\n\ntry {\n\n$installProcess = Start-Process msiexec.exe `\n -ArgumentList \"/quiet /norestart /lv ${logFile} /i `\"${env:INSTALLER_PATH}`\"\" `\n -PassThru -Verb RunAs -Wait\n\nGet-Content $logFile -Tail 500\n\nExit $installProcess.ExitCode\n\n} catch {\n Write-Host \"Error: $_\"\n Exit 1\n}\n",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants