Add WinDirStat as a Windows FMA - #48762
Conversation
Adds WinDirStat to maintained apps for Windows by introducing the winget input metadata, generated app output entries, and installer/uninstaller version data. Also adds the WinDirStat icon asset and wires it into the SoftwarePage icon map so the app displays with the correct branding in the UI.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48762 +/- ##
==========================================
- Coverage 68.02% 68.02% -0.01%
==========================================
Files 3680 3681 +1
Lines 233959 233961 +2
Branches 12456 12307 -149
==========================================
+ Hits 159145 159146 +1
- Misses 60496 60498 +2
+ Partials 14318 14317 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
WalkthroughThis PR adds WinDirStat as a new maintained app. It introduces a winget input JSON with package metadata, an apps.json catalog entry for WinDirStat on Windows, and a windows.json output defining version 2.7.0 with install/uninstall PowerShell scripts using msiexec and COM-based product enumeration. It also adds a new frontend Windirstat SVG icon component and registers it in the software-name-to-icon map. Changes
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds WinDirStat as a Windows Fleet-maintained app (winget-backed) and wires a new icon into the Software page icon mapping so the app displays with correct branding.
Changes:
- Added WinDirStat winget input metadata and generated maintained-app outputs (app listing + Windows version/install/uninstall metadata).
- Added a WinDirStat icon component and registered it in the Software icon map.
- Updated the consolidated maintained-apps
apps.jsoncatalog to include WinDirStat.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/pages/SoftwarePage/components/icons/Windirstat.tsx | Adds WinDirStat icon asset as an SVG component (base64 PNG). |
| frontend/pages/SoftwarePage/components/icons/index.ts | Registers the WinDirStat icon and maps the windirstat software-name key to it. |
| ee/maintained-apps/outputs/windirstat/windows.json | Adds WinDirStat Windows installer metadata, queries, and install/uninstall script refs. |
| ee/maintained-apps/outputs/apps.json | Adds WinDirStat entry to the maintained-app catalog. |
| ee/maintained-apps/inputs/winget/windirstat.json | Adds winget input metadata for generating WinDirStat Windows output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "exists": "SELECT 1 FROM programs WHERE name LIKE 'WinDirStat %' AND publisher = 'WinDirStat Team';", | ||
| "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM programs WHERE name LIKE 'WinDirStat %' AND publisher = 'WinDirStat Team' AND version_compare(version, '2.7.0') < 0);" |
| "slug": "windirstat/windows", | ||
| "package_identifier": "WinDirStat.WinDirStat", | ||
| "unique_identifier": "WinDirStat", | ||
| "fuzzy_match_name": true, |
| } | ||
| ], | ||
| "refs": { | ||
| "8959087b": "$logFile = \"${env:TEMP}/fleet-install-software.log\"\n\ntry {\n\n$installProcess = Start-Process msiexec.exe `\n -ArgumentList \"/quiet /norestart /lv ${logFile} /i `\"${env:INSTALLER_PATH}`\"\" `\n -PassThru -Verb RunAs -Wait\n\nGet-Content $logFile -Tail 500\n\nExit $installProcess.ExitCode\n\n} catch {\n Write-Host \"Error: $_\"\n Exit 1\n}\n", |
Adds WinDirStat to maintained apps for Windows by introducing the winget input metadata, generated app output entries, and installer/uninstaller version data. Also adds the WinDirStat icon asset and wires it into the SoftwarePage icon map so the app displays with the correct branding in the UI.
Summary by CodeRabbit