Update Fleet-maintained apps - #48714
Merged
Merged
Conversation
Generated automatically with cmd/maintained-apps.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
WalkthroughThis pull request refreshes maintained-app metadata and Egnyte winget support. Most changes bump app versions in ChangesPossibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Egnyte's MSI has a LaunchCondition that fails with 1603 when reboot suppression is requested (/norestart => REBOOT=ReallySuppress) unless ED_UPDATE_ON_BOOT=1 is passed, which defers the CBFS driver update to the next boot instead of forcing an immediate reboot.
Contributor
Script Diff Resultsee/maintained-apps/outputs/acorn/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/alt-tab/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/aptakube/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/boltai/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/codexbar/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/deezer/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/egnyte/windows.json=== Install // 8959087b -> 07209af6 ===
--- /tmp/old.VsArzy 2026-07-04 01:28:06.411346185 +0000
+++ /tmp/new.qBM2D4 2026-07-04 01:28:06.411346185 +0000
@@ -1,14 +1,36 @@
+# Learn more about .msi install scripts:
+# http://fleetdm.com/learn-more-about/msi-install-scripts
+#
+# Egnyte's MSI has a LaunchCondition that fails (1603) when reboot
+# suppression is requested (/norestart => REBOOT=ReallySuppress) unless
+# ED_UPDATE_ON_BOOT=1 is also passed, which schedules the CBFS driver
+# update at next boot instead of forcing an immediate reboot.
+
$logFile = "${env:TEMP}/fleet-install-software.log"
+$msiFilePath = "${env:INSTALLER_PATH}"
try {
-$installProcess = Start-Process msiexec.exe `
- -ArgumentList "/quiet /norestart /lv ${logFile} /i `"${env:INSTALLER_PATH}`"" `
- -PassThru -Verb RunAs -Wait
+$processOptions = @{
+ FilePath = "msiexec.exe"
+ ArgumentList = "/i `"$msiFilePath`" /quiet /norestart ED_UPDATE_ON_BOOT=1 /lv `"$logFile`""
+ PassThru = $true
+ Wait = $true
+}
+
+$process = Start-Process @processOptions
+$exitCode = $process.ExitCode
+
+Write-Host "Install exit code: $exitCode"
+
+# MSI reboot-required success codes.
+if ($exitCode -eq 3010 -or $exitCode -eq 1641) { Exit 0 }
-Get-Content $logFile -Tail 500
+if ($exitCode -ne 0) {
+ Get-Content $logFile -Tail 500
+}
-Exit $installProcess.ExitCode
+Exit $exitCode
} catch {
Write-Host "Error: $_"
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/free-download-manager/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/git/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/home-assistant/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/jetbrains-toolbox/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/microsoft-teams/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/mimestream/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/modern-csv/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/mountain-duck/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/netron/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/opera/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/proxyman/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/pycharm/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/rustrover/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/spokenly/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/spotify/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/superhuman/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/surfshark/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/vivaldi/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/warp/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/yacreader/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/zappy/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) === |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ee/maintained-apps/inputs/winget/scripts/egnyte_install.ps1 (1)
29-33: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winGet-Content failure could swallow the real exit code.
If
$logFileisn't created (e.g., msiexec fails before writing the log),Get-Contentthrows inside thetryblock, which is caught by the outercatchand forcesExit 1— losing the original$exitCodethat would otherwise help diagnose the failure.🛠️ Suggested fix
if ($exitCode -ne 0) { - Get-Content $logFile -Tail 500 + Get-Content $logFile -Tail 500 -ErrorAction SilentlyContinue }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ee/maintained-apps/inputs/winget/scripts/egnyte_install.ps1` around lines 29 - 33, The failure-handling block in egnyte_install.ps1 can mask the original installer exit code if Get-Content throws because the log file does not exist. Update the error-path logic around $exitCode and $logFile so the log tail is only attempted when the file is present/readable, or any Get-Content failure is handled locally without escaping to the outer catch. Keep the final Exit using the original $exitCode from the installer flow, and make sure the behavior is centered on the existing $exitCode, $logFile, and Get-Content logic.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ee/maintained-apps/inputs/winget/scripts/egnyte_install.ps1`:
- Around line 29-33: The failure-handling block in egnyte_install.ps1 can mask
the original installer exit code if Get-Content throws because the log file does
not exist. Update the error-path logic around $exitCode and $logFile so the log
tail is only attempted when the file is present/readable, or any Get-Content
failure is handled locally without escaping to the outer catch. Keep the final
Exit using the original $exitCode from the installer flow, and make sure the
behavior is centered on the existing $exitCode, $logFile, and Get-Content logic.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bd6629bc-f3c3-4097-91cc-cab263f34800
📒 Files selected for processing (3)
ee/maintained-apps/inputs/winget/egnyte.jsonee/maintained-apps/inputs/winget/scripts/egnyte_install.ps1ee/maintained-apps/outputs/egnyte/windows.json
🚧 Files skipped from review as they are similar to previous changes (1)
- ee/maintained-apps/outputs/egnyte/windows.json
allenhouchins
approved these changes
Jul 4, 2026
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit