Software title page tweaks - #48577
Conversation
Removed unnecessary line breaks from tooltip text.
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis change updates policy-chip tooltip content and tooltip positioning in Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48577 +/- ##
==========================================
- Coverage 68.01% 68.00% -0.02%
==========================================
Files 3678 3678
Lines 233758 233575 -183
Branches 12416 12305 -111
==========================================
- Hits 158981 158831 -150
+ Misses 60475 60452 -23
+ Partials 14302 14292 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Converting this to draft because I noticed that we're still using the "Shield" icon for patch policies. We decided to remove that because it's already being used for critical policies. Also the tooltip copy isn't quite right. 
Also, smaller screen widths are strange: 
Also the veil in darkmode is strange: 
|
noahtalerman
changed the title
We decided to remove the "Shield" icon for patch policies because they're already being used for critical policies. Also, the tooltip copy isn't quite right.
Also, smaller screen widths are strange:
I updated this to not wrap: 
Also the veil in darkmode is strange:
Fix in this PR: 
@RachelElysia @cdcme @marko-lisica I increased the scope of this PR to include the above updates. Please let me know if you disagree with any of the choices. Also, Carlo, please let me know if you want me to break up this PR into smaller bites. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwareSummaryCard/SoftwareSummaryCard.tsx (1)
47-61: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winFix prettier formatting flagged by lint.
Static analysis flags the multi-line JSX text on Lines 57-59; collapse it to match prettier formatting.
🎨 Proposed fix
return isSinglePolicy ? ( <>Policy triggers install.</> ) : ( - <> - Policies trigger install. - </> + <>Policies trigger install.</> );🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwareSummaryCard/SoftwareSummaryCard.tsx` around lines 47 - 61, The tooltip JSX in getPolicyChipTooltip is formatted in a way that violates prettier rules; simplify the multi-line fragment in the non-single-policy branch of SoftwareSummaryCard so it matches the same compact JSX style used elsewhere and passes lint formatting.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwareSummaryCard/SoftwareSummaryCard.tsx`:
- Around line 47-61: The tooltip JSX in getPolicyChipTooltip is formatted in a
way that violates prettier rules; simplify the multi-line fragment in the
non-single-policy branch of SoftwareSummaryCard so it matches the same compact
JSX style used elsewhere and passes lint formatting.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cc62db99-8b84-4f8d-b954-d36019850e5a
📒 Files selected for processing (4)
frontend/components/Chip/Chip.tsxfrontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/_styles.scssfrontend/pages/SoftwarePage/SoftwareTitleDetailsPage/SoftwareSummaryCard/SoftwareSummaryCard.tsxfrontend/pages/SoftwarePage/components/cards/SoftwareDetailsSummary/_styles.scss
✅ Files skipped from review due to trivial changes (1)
- frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/_styles.scss
cdcme
left a comment
cdcme
left a comment
There was a problem hiding this comment.
No, @noahtalerman I think this looks good. Thanks!
2 participants
QA'd all new/changed functionality manually
@noahtalerman: Tweaks on top of the following story:
We decided to remove the "Shield" icon for patch policies because they're already being used for critical policies.
Also, the tooltip copy isn't quite right.
Also, smaller screen widths are strange:
I updated this to not wrap:
Also the veil in darkmode is strange:
Fix in this PR:
Summary by CodeRabbit
Summary by CodeRabbit