Update Fleet-maintained apps - #48454
Closed
fleet-release wants to merge 1 commit into
Closed
Conversation
Generated automatically with cmd/maintained-apps.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Script Diff Resultsee/maintained-apps/outputs/beyond-compare/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/codex-app/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/discord/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/discord/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/docker-desktop/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/drawio/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/nextcloud/darwin.json=== Install // 19e01bca -> c18d4d3b ===
--- /tmp/old.95bpCf 2026-06-29 20:40:18.779875309 +0000
+++ /tmp/new.OXWyoA 2026-06-29 20:40:18.779875309 +0000
@@ -96,5 +96,5 @@
# install pkg files
quit_and_track_application 'com.nextcloud.desktopclient'
-sudo installer -pkg "$TMPDIR/Nextcloud-33.0.6.pkg" -target /
+sudo installer -pkg "$TMPDIR/Nextcloud-33.0.7.pkg" -target /
relaunch_application 'com.nextcloud.desktopclient'
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/notion-calendar/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/novabench/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/reqable/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/reqable/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/rocket-chat/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/shift/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/shift/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/spokenly/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/wins/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) === |
Contributor
WalkthroughVersion metadata updates across 15 maintained-app JSON manifests under Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ee/maintained-apps/outputs/nextcloud/darwin.json (1)
20-20: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse
INSTALLER_PATHinstead of hardcoding the package filename.The new ref still bakes
Nextcloud-33.0.7.pkginto the script, so every version bump now has to keep the manifest URL and the embedded installer path in sync. Pointinstaller -pkgat"$INSTALLER_PATH"to remove that drift risk.Proposed change
- sudo installer -pkg "$TMPDIR/Nextcloud-33.0.7.pkg" -target / + sudo installer -pkg "$INSTALLER_PATH" -target /🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ee/maintained-apps/outputs/nextcloud/darwin.json` at line 20, The installer invocation still hardcodes the package filename inside the Nextcloud script, which can drift from the downloaded artifact. Update the `installer` call in the script logic that uses `TMPDIR` and `INSTALLER_PATH` so it installs from `"$INSTALLER_PATH"` instead of a versioned `Nextcloud-33.0.7.pkg`, keeping the package path tied to the actual downloaded file.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ee/maintained-apps/outputs/nextcloud/darwin.json`:
- Line 20: The installer invocation still hardcodes the package filename inside
the Nextcloud script, which can drift from the downloaded artifact. Update the
`installer` call in the script logic that uses `TMPDIR` and `INSTALLER_PATH` so
it installs from `"$INSTALLER_PATH"` instead of a versioned
`Nextcloud-33.0.7.pkg`, keeping the package path tied to the actual downloaded
file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c33e5600-c370-4e11-a625-ce4e1708061b
📒 Files selected for processing (16)
ee/maintained-apps/outputs/beyond-compare/darwin.jsonee/maintained-apps/outputs/codex-app/darwin.jsonee/maintained-apps/outputs/discord/darwin.jsonee/maintained-apps/outputs/discord/windows.jsonee/maintained-apps/outputs/docker-desktop/darwin.jsonee/maintained-apps/outputs/drawio/windows.jsonee/maintained-apps/outputs/nextcloud/darwin.jsonee/maintained-apps/outputs/notion-calendar/darwin.jsonee/maintained-apps/outputs/novabench/darwin.jsonee/maintained-apps/outputs/reqable/darwin.jsonee/maintained-apps/outputs/reqable/windows.jsonee/maintained-apps/outputs/rocket-chat/darwin.jsonee/maintained-apps/outputs/shift/darwin.jsonee/maintained-apps/outputs/shift/windows.jsonee/maintained-apps/outputs/spokenly/darwin.jsonee/maintained-apps/outputs/wins/darwin.json
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Contributor
|
Closing in favor of #48464. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit