Skip to content

Return per-version filename in fleet_maintained_versions - #48335

Merged
cdcme merged 1 commit into
feat/38504-auto-update-pin-rollback-fmafrom
fix-48334-fma-version-filename
Jun 26, 2026
Merged

Return per-version filename in fleet_maintained_versions#48335
cdcme merged 1 commit into
feat/38504-auto-update-pin-rollback-fmafrom
fix-48334-fma-version-filename

Conversation

@cdcme

@cdcme cdcme commented Jun 26, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #48334

The software title response now returns a per-version filename in fleet_maintained_versions, and the Library version rows render each version's own filename instead of the active installer's. Previously, every cached-version row showed the active installer's filename because the array didn't include one.

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

@cdcme
cdcme marked this pull request as ready for review June 26, 2026 14:23
@cdcme
cdcme requested review from a team as code owners June 26, 2026 14:23

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.45%. Comparing base (d8c4faa) to head (72b2ef3).

Additional details and impacted files
@@                             Coverage Diff                             @@
##           feat/38504-auto-update-pin-rollback-fma   #48335      +/-   ##
===========================================================================
+ Coverage                                    67.36%   67.45%   +0.09%     
===========================================================================
  Files                                         3668     3668              
  Lines                                       232220   232216       -4     
  Branches                                     12401    12402       +1     
===========================================================================
+ Hits                                        156428   156642     +214     
+ Misses                                       61790    61535     -255     
- Partials                                     14002    14039      +37     
Flag Coverage Δ
backend 68.99% <100.00%> (+0.11%) ⬆️
frontend 59.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkatz01 jkatz01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for backend, thanks!

@cdcme
cdcme merged commit 0b6f806 into feat/38504-auto-update-pin-rollback-fma Jun 26, 2026
38 checks passed
@cdcme
cdcme deleted the fix-48334-fma-version-filename branch June 26, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto update, pin, and rollback FMA - version rows show the same filename for every cached version

3 participants