Skip to content

Fleet UI: FMA UI follow-ups for version pinning and patch-policy chip - #48304

Merged
RachelElysia merged 1 commit into
feat/38504-auto-update-pin-rollback-fmafrom
38504-ui-followup
Jun 25, 2026
Merged

Fleet UI: FMA UI follow-ups for version pinning and patch-policy chip#48304
RachelElysia merged 1 commit into
feat/38504-auto-update-pin-rollback-fmafrom
38504-ui-followup

Conversation

@RachelElysia

@RachelElysia RachelElysia commented Jun 25, 2026

Copy link
Copy Markdown
Member

Issue

Closes #48299

Description

  • Edit Software modal (FMAs): Removed the dead PackageVersionSelector dropdown — it was disabled with a now-stale "GitOps only" tooltip. VersionsModal is the single source of truth for version pinning, so the dropdown (and the file-replace pencil, which never applied to FMAs) are gone. Also dropped the now-unused version field from IPackageFormData and the sortByVersionLatestFirst helper.
  • Actions ▾ → Versions in gitops mode: No longer disabled with GitOpsModeTooltipWrapper. The VersionsModal itself disables Save in gitops mode, matching the behavior when clicking the in-row Latest/Pinned badge — those two paths are now consistent.
  • Summary card chip: When every linked policy is patch-only (no "dynamic" in any policy's type set), the chip now reads "Patch policy" with the policy (shield) icon. "Auto install" with the refresh icon still wins as soon as any policy is dynamic.

Screenrecording

Screen.Recording.2026-06-25.at.4.08.21.PM.mov

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

@RachelElysia
RachelElysia requested a review from a team as a code owner June 25, 2026 20:03

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.36%. Comparing base (b9f8c1d) to head (55d166d).

Files with missing lines Patch % Lines
...ePage/components/forms/PackageForm/PackageForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##           feat/38504-auto-update-pin-rollback-fma   #48304    +/-   ##
=========================================================================
  Coverage                                    67.35%   67.36%            
=========================================================================
  Files                                         3669     3668     -1     
  Lines                                       232268   232223    -45     
  Branches                                     12266    12399   +133     
=========================================================================
- Hits                                        156447   156432    -15     
+ Misses                                       61820    61790    -30     
  Partials                                     14001    14001            
Flag Coverage Δ
frontend 59.01% <85.71%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Edit Software modal: drop the dead PackageVersionSelector dropdown for
  FMAs (and stop offering the file-replace pencil). VersionsModal is the
  single source of truth for version pinning now.
- Actions > Versions: stop gating the menu item in gitops mode. The
  VersionsModal already disables Save with GitOpsModeTooltipWrapper, so
  opening it stays consistent with the in-row Latest/Pinned badge.
- Summary card chip: show "Patch policy" with the policy (shield) icon
  when every linked policy is patch-only; "Auto install" wins as soon as
  any policy is dynamic.
@RachelElysia
RachelElysia merged commit d8c4faa into feat/38504-auto-update-pin-rollback-fma Jun 25, 2026
18 checks passed
@RachelElysia
RachelElysia deleted the 38504-ui-followup branch June 25, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants