Fleet UI: FMA UI follow-ups for version pinning and patch-policy chip - #48304
Merged
RachelElysia merged 1 commit intoJun 25, 2026
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/38504-auto-update-pin-rollback-fma #48304 +/- ##
=========================================================================
Coverage 67.35% 67.36%
=========================================================================
Files 3669 3668 -1
Lines 232268 232223 -45
Branches 12266 12399 +133
=========================================================================
- Hits 156447 156432 -15
+ Misses 61820 61790 -30
Partials 14001 14001
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cdcme
approved these changes
Jun 25, 2026
- Edit Software modal: drop the dead PackageVersionSelector dropdown for FMAs (and stop offering the file-replace pencil). VersionsModal is the single source of truth for version pinning now. - Actions > Versions: stop gating the menu item in gitops mode. The VersionsModal already disables Save with GitOpsModeTooltipWrapper, so opening it stays consistent with the in-row Latest/Pinned badge. - Summary card chip: show "Patch policy" with the policy (shield) icon when every linked policy is patch-only; "Auto install" wins as soon as any policy is dynamic.
RachelElysia
force-pushed
the
38504-ui-followup
branch
from
June 25, 2026 20:18
d1568b5 to
55d166d
Compare
cdcme
approved these changes
Jun 25, 2026
RachelElysia
merged commit Jun 25, 2026
d8c4faa
into
feat/38504-auto-update-pin-rollback-fma
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #48299
Description
PackageVersionSelectordropdown — it was disabled with a now-stale "GitOps only" tooltip.VersionsModalis the single source of truth for version pinning, so the dropdown (and the file-replace pencil, which never applied to FMAs) are gone. Also dropped the now-unusedversionfield fromIPackageFormDataand thesortByVersionLatestFirsthelper.GitOpsModeTooltipWrapper. TheVersionsModalitself disables Save in gitops mode, matching the behavior when clicking the in-row Latest/Pinned badge — those two paths are now consistent."dynamic"in any policy's type set), the chip now reads "Patch policy" with thepolicy(shield) icon. "Auto install" with therefreshicon still wins as soon as any policy is dynamic.Screenrecording
Screen.Recording.2026-06-25.at.4.08.21.PM.mov
Testing