Skip to content

Versions modal, multi-row Library, pinned state - #48081

Merged
cdcme merged 2 commits into
feat/38504-auto-update-pin-rollback-fmafrom
feat-47623-version-pinning-e2e
Jun 24, 2026
Merged

Versions modal, multi-row Library, pinned state#48081
cdcme merged 2 commits into
feat/38504-auto-update-pin-rollback-fmafrom
feat-47623-version-pinning-e2e

Conversation

@cdcme

@cdcme cdcme commented Jun 23, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #47623

Summary

Wires up the Fleet-maintained app version-pinning UI on the software title details page:

  • Versions modal — opened from Actions ▾ → Versions or the active row's version badge. Choose Automatically update to latest, pin to an exact version, or pin to a major version; pre-selected from the current pin, and Save is disabled with a tooltip in GitOps mode.
  • Multi-row Library — one accordion row per cached version; the active/pinned row is badged (Latest / Pinned / Major version) and older versions are dimmed.
  • Adds pinned_version to the software-package interface and a version field to the installer PATCH request.

Frontend only; targets the feat/38504-auto-update-pin-rollback-fma feature branch (backend, layout, and accordion already merged there).

Checklist for submitter

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually
Screen.Recording.2026-06-23.at.14.45.20.mov

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/38504-auto-update-pin-rollback-fma@09e2912). Learn more about missing BASE report.

Files with missing lines Patch % Lines
frontend/services/entities/software.ts 0.00% 2 Missing ⚠️
...reTitleDetailsPage/VersionsModal/VersionsModal.tsx 96.96% 1 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##             feat/38504-auto-update-pin-rollback-fma   #48081   +/-   ##
==========================================================================
  Coverage                                           ?   67.26%           
==========================================================================
  Files                                              ?     3641           
  Lines                                              ?   230040           
  Branches                                           ?    11934           
==========================================================================
  Hits                                               ?   154747           
  Misses                                             ?    61418           
  Partials                                           ?    13875           
Flag Coverage Δ
frontend 58.54% <94.64%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cdcme
cdcme force-pushed the feat-47623-version-pinning-e2e branch from eb3cb81 to 911cbca Compare June 23, 2026 17:57
@cdcme

cdcme commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

@claude review once

@cdcme
cdcme marked this pull request as ready for review June 23, 2026 19:09
@cdcme
cdcme requested a review from a team as a code owner June 23, 2026 19:09

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

softwareId,
teamId,
});
renderFlash(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to have to update this to the new notify.success @marko-lisica implemented

refetchSoftwareTitle();
onExit();
} catch (error) {
renderFlash("error", "Couldn't update version. Please try again.");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Samesies

@RachelElysia RachelElysia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no blockers! thanks for all this

@cdcme
cdcme merged commit e991001 into feat/38504-auto-update-pin-rollback-fma Jun 24, 2026
17 checks passed
@cdcme
cdcme deleted the feat-47623-version-pinning-e2e branch June 24, 2026 22:13
@marko-lisica

Copy link
Copy Markdown
Member
Screenshot 2026-06-25 at 14 06 34

Hey @cdcme @RachelElysia, I see that we have a container around radio buttons. That's not in Figma. Can we get rid of that?

georgekarrv added a commit that referenced this pull request Jun 26, 2026
#48293)

**Related issue:** Resolves #38504

  **Constituent PRs (merged into this feature branch):**

- #47682 — Fleet UI: APRF Software title details page Library/Inventory
layout
- #47808 — Extend update software installer API to support FMA version
pinning
  - #47944 — Fleet UI: APRF library item accordion component
  - #48081 — Versions modal, multi-row Library, pinned state
  - #48098 — Add `pinned_version` to `edited_software` activity
  - #48123 — Auto-update FMA cron
  - #48144 — Download a newly-published FMA version when pinned to it

  # Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or
`ee/fleetd-chrome/changes`. See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements), JS
inline code is prevented especially for url redirects, and untrusted
data interpolated into shell scripts/commands is validated against shell
metacharacters.
- [x] Timeouts are implemented and retries are limited to avoid infinite
loops
- [x] If paths of existing endpoints are modified without backwards
compatibility, checked the frontend/CLI for any necessary changes

  ## Testing

  - [x] Added/updated automated tests
- [x] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates
  to one hosts's records do not affect another)

  - [x] QA'd all new/changed functionality manually


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added Fleet-maintained app version pinning (Latest, exact, and major)
via a new Versions modal.
* Introduced premium auto-updates for maintained apps with pin-aware
promotion and rollback-safe caching.
  * Added expandable library version rows and a Policies modal.
* **Bug Fixes**
* Improved pin handling, cache/manifest hydration, and safer update
behavior on per-app failures and deduplication.
* **UI/UX**
* Refreshed the Software title details experience with new
accordion/list patterns, redesigned details widget/tooltips, and updated
installer presentation.
* **Documentation**
* Expanded Storybook component/page coverage and adjusted Storybook
canvas padding.
* **Tests**
* Added/updated unit and integration tests for pinning, auto-update
flows, and new modal/UI behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

APRF: Wire up version pinning (Versions modal, multi-row Library, pinned-state display)

3 participants