Update Fleet-maintained apps - #47978
Closed
fleet-release wants to merge 1 commit into
Closed
Conversation
Generated automatically with cmd/maintained-apps.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
WalkthroughTwenty-two maintained-app JSON manifests under Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/kiro/darwin.json`:
- Around line 4-7: The patched query in the darwin.json file uses version
comparison logic that assumes version increases, but the current change rolls
back from 1.0.0 to 0.12.333. Since the query checks
version_compare(bundle_short_version, '0.12.333') < 0, devices reporting version
1.0.0 will be marked as already patched and skip targeting. Confirm whether this
downgrade behavior is intentional, or update the patched query logic to properly
target devices with the higher version for downgrading by adjusting the
comparison condition or adding additional logic to handle version rollbacks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 975a20de-dcd6-48d6-8dc8-8e377e8cb6ec
📒 Files selected for processing (22)
ee/maintained-apps/outputs/adobe-acrobat-pro/darwin.jsonee/maintained-apps/outputs/adobe-acrobat-pro/windows.jsonee/maintained-apps/outputs/alcove/darwin.jsonee/maintained-apps/outputs/aws-cli/windows.jsonee/maintained-apps/outputs/boltai/darwin.jsonee/maintained-apps/outputs/clipy/darwin.jsonee/maintained-apps/outputs/codex-app/darwin.jsonee/maintained-apps/outputs/darktable/darwin.jsonee/maintained-apps/outputs/darktable/windows.jsonee/maintained-apps/outputs/dbeaver-community/darwin.jsonee/maintained-apps/outputs/dockside/darwin.jsonee/maintained-apps/outputs/drawio/windows.jsonee/maintained-apps/outputs/input-source-pro/darwin.jsonee/maintained-apps/outputs/kiro/darwin.jsonee/maintained-apps/outputs/onedrive/windows.jsonee/maintained-apps/outputs/opencode-desktop/darwin.jsonee/maintained-apps/outputs/postman/windows.jsonee/maintained-apps/outputs/rustdesk/darwin.jsonee/maintained-apps/outputs/stats/darwin.jsonee/maintained-apps/outputs/visual-studio-code/windows.jsonee/maintained-apps/outputs/vnc-viewer/windows.jsonee/maintained-apps/outputs/webcatalog/darwin.json
Comment on lines
+4
to
+7
| "version": "0.12.333", | ||
| "queries": { | ||
| "exists": "SELECT 1 FROM apps WHERE bundle_identifier = 'dev.kiro.desktop';", | ||
| "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM apps WHERE bundle_identifier = 'dev.kiro.desktop' AND version_compare(bundle_short_version, '1.0.0') < 0);" | ||
| "patched": "SELECT 1 WHERE NOT EXISTS (SELECT 1 FROM apps WHERE bundle_identifier = 'dev.kiro.desktop' AND version_compare(bundle_short_version, '0.12.333') < 0);" |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# 1) Confirm current value in this branch
sed -n '1,40p' ee/maintained-apps/outputs/kiro/darwin.json
# 2) Inspect recent history for this manifest's version trajectory
git log --oneline -- ee/maintained-apps/outputs/kiro/darwin.json | head -n 10
# 3) Show prior committed content (if available) to verify rollback intent
prev_commit=$(git rev-list -n 1 HEAD^ -- ee/maintained-apps/outputs/kiro/darwin.json 2>/dev/null || true)
if [ -n "$prev_commit" ]; then
git show "${prev_commit}:ee/maintained-apps/outputs/kiro/darwin.json" | sed -n '1,40p'
fiRepository: fleetdm/fleet
Length of output: 6676
🏁 Script executed:
# Get more details about the commit that touched this file
git show --stat 73fe6419
# Show the actual diff for this file in that commit
git show 73fe6419 -- ee/maintained-apps/outputs/kiro/darwin.json | head -100
# Check if there are other commits mentioning 1.0.0 or kiro
git log --all --grep="1.0.0\|kiro" --oneline | head -20Repository: fleetdm/fleet
Length of output: 50371
🏁 Script executed:
# Get the diff for just the kiro darwin.json file
git show 73fe6419 -- ee/maintained-apps/outputs/kiro/darwin.json
# Check if there are commits before this one that touched the kiro file
git log --all --oneline -- ee/maintained-apps/outputs/kiro/darwin.jsonRepository: fleetdm/fleet
Length of output: 7330
🏁 Script executed:
# Search for any prior kiro entries in maintained-apps
find ee/maintained-apps -name "*kiro*" -type f
# Check the earlier commits mentioned in the log
git show 15fedbae:ee/maintained-apps/outputs/kiro/darwin.json 2>/dev/null || echo "File not found in that commit"
git show abd70c75:ee/maintained-apps/outputs/kiro/darwin.json 2>/dev/null || echo "File not found in that commit"
# Look for any kiro in sources directory
rg -i "kiro" ee/maintained-apps/sources/ 2>/dev/null | head -20Repository: fleetdm/fleet
Length of output: 13460
Verify the version rollback semantics are intentional.
This commit rolls back from version 1.0.0 to 0.12.333. The patched query on line 7 uses version_compare(bundle_short_version, '0.12.333') < 0, which means any device reporting version 1.0.0 will be marked as already patched (since 1.0.0 > 0.12.333) and will skip upgrade targeting. Confirm this downgrade behavior is expected, or the query logic may need to handle version rollbacks differently.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/kiro/darwin.json` around lines 4 - 7, The patched
query in the darwin.json file uses version comparison logic that assumes version
increases, but the current change rolls back from 1.0.0 to 0.12.333. Since the
query checks version_compare(bundle_short_version, '0.12.333') < 0, devices
reporting version 1.0.0 will be marked as already patched and skip targeting.
Confirm whether this downgrade behavior is intentional, or update the patched
query logic to properly target devices with the higher version for downgrading
by adjusting the comparison condition or adding additional logic to handle
version rollbacks.
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Contributor
|
Closing in favor of #47979. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit