Skip to content

Cherry pick: Change self-service categories GitOps to not require dedicated key - #47458

Merged
jkatz01 merged 2 commits into
rc-minor-fleet-v4.87.0from
39018-gitops-changes-cherry-pick
Jun 11, 2026
Merged

Cherry pick: Change self-service categories GitOps to not require dedicated key#47458
jkatz01 merged 2 commits into
rc-minor-fleet-v4.87.0from
39018-gitops-changes-cherry-pick

Conversation

@jkatz01

@jkatz01 jkatz01 commented Jun 11, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #

Cherry-picks #47439 to 4.87.0

…47439)

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.
    - Not needed

- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements), JS
inline code is prevented especially for url redirects, and untrusted
data interpolated into shell scripts/commands is validated against shell
metacharacters.
- [ ] Timeouts are implemented and retries are limited to avoid infinite
loops
- [ ] If paths of existing endpoints are modified without backwards
compatibility, checked the frontend/CLI for any necessary changes

- [x] Added/updated automated tests
- [ ] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

* **New Features**
* Batch software installer and app-association endpoints now return the
list of referenced self-service categories.
* Category fields support an “omit when unset” JSON behavior so omitted
vs empty categories are distinguishable.

* **Bug Fixes**
* Improved category validation (trim + case-insensitive dedupe) and
GitOps reconciliation to remove unused categories.

* **Chores**
* GitOps schema simplified: no separate top-level
self_service_categories; categories are defined inline with packages.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@jkatz01
jkatz01 marked this pull request as ready for review June 11, 2026 20:45
@jkatz01
jkatz01 requested a review from a team as a code owner June 11, 2026 20:45
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.37563% with 82 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.87.0@45d5ce9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ee/server/service/vpp.go 38.00% 29 Missing and 2 partials ⚠️
ee/server/service/software_installers.go 59.67% 16 Missing and 9 partials ⚠️
server/service/client_software.go 66.66% 7 Missing and 3 partials ⚠️
...d/fleetctl/fleetctl/testing_utils/testing_utils.go 50.00% 2 Missing and 2 partials ⚠️
server/service/client.go 73.33% 2 Missing and 2 partials ⚠️
server/service/software_installers.go 50.00% 4 Missing ⚠️
server/service/client_teams.go 66.66% 3 Missing ⚠️
cmd/fleetctl/fleetctl/get.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.87.0   #47458   +/-   ##
=========================================================
  Coverage                          ?   67.18%           
=========================================================
  Files                             ?     2914           
  Lines                             ?   226689           
  Branches                          ?    11824           
=========================================================
  Hits                              ?   152294           
  Misses                            ?    60616           
  Partials                          ?    13779           
Flag Coverage Δ
backend 68.81% <58.37%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkatz01
jkatz01 marked this pull request as draft June 11, 2026 20:50
@jkatz01
jkatz01 marked this pull request as ready for review June 11, 2026 21:21
@jkatz01
jkatz01 merged commit b2c5047 into rc-minor-fleet-v4.87.0 Jun 11, 2026
38 checks passed
@jkatz01
jkatz01 deleted the 39018-gitops-changes-cherry-pick branch June 11, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants