Skip to content

Cherry-pick #47129: Use brightest color for checkerboard when only one is available - #47133

Merged
sgress454 merged 1 commit into
rc-minor-fleet-v4.87.0from
sgress454/checkerboard-brightest-color-cp
Jun 8, 2026
Merged

Cherry-pick #47129: Use brightest color for checkerboard when only one is available#47133
sgress454 merged 1 commit into
rc-minor-fleet-v4.87.0from
sgress454/checkerboard-brightest-color-cp

Conversation

@sgress454

Copy link
Copy Markdown
Contributor

Cherry-pick of #47129 into the rc-minor-fleet-v4.87.0 RC branch.

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #47128

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.
n/a, unreleased 

## Testing

- [X] Added/updated automated tests
- [X] QA'd all new/changed functionality manually
on main:
<img width="499" height="404" alt="Image"
src="https://github.com/user-attachments/assets/3d5c3663-61de-444b-ba42-3ebab984d7a3"
/>

on branch:
<img width="493" height="409" alt="image"
src="https://github.com/user-attachments/assets/0e7c7fd1-b729-4de8-bb77-41d1e593e926"
/>

For unreleased bug fixes in a release candidate, one of:

- [X] Confirmed that the fix is not expected to adversely impact load
test results


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Fixed checkerboard visualization color scaling to properly render
non-zero data cells at the brightest color level when all non-zero
values are identical.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@sgress454
sgress454 requested a review from a team as a code owner June 8, 2026 20:22
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.17%. Comparing base (b23f808) to head (c28ce71).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           rc-minor-fleet-v4.87.0   #47133   +/-   ##
=======================================================
  Coverage                   67.17%   67.17%           
=======================================================
  Files                        2908     2908           
  Lines                      226136   226137    +1     
  Branches                    11829    11829           
=======================================================
+ Hits                       151898   151899    +1     
  Misses                      60508    60508           
  Partials                    13730    13730           
Flag Coverage Δ
frontend 57.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgress454
sgress454 merged commit d1f6ab0 into rc-minor-fleet-v4.87.0 Jun 8, 2026
16 checks passed
@sgress454
sgress454 deleted the sgress454/checkerboard-brightest-color-cp branch June 8, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants