Skip to content

Update Fleet-maintained apps - #46852

Closed
fleet-release wants to merge 1 commit into
mainfrom
fma-2606041951
Closed

Update Fleet-maintained apps#46852
fleet-release wants to merge 1 commit into
mainfrom
fma-2606041951

Conversation

@fleet-release

@fleet-release fleet-release commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Chores
    • Updated NordVPN Windows app metadata to version 8.4.3.0, including installer path and integrity verification.

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8e4754e1-e1ac-46cd-abc0-a575e70beb6c

📥 Commits

Reviewing files that changed from the base of the PR and between d67394f and 3601fc0.

📒 Files selected for processing (1)
  • ee/maintained-apps/outputs/nordvpn/windows.json

Walkthrough

This PR updates the NordVPN Windows app metadata file to version 8.4.3.0. The changes include bumping the version field, updating the SQL query in queries.patched to compare against 8.4.3.0 for detecting previously-equal installations, changing the installer_url to the new version's binary location, and replacing the sha256 checksum with the updated integrity hash. The script reference IDs are unchanged.

Possibly related PRs

  • fleetdm/fleet#46831: Updates version metadata in ee/maintained-apps/outputs/* JSON entries with the same pattern of changes (version, installer_url, patched SQL comparisons, and sha256 checksums).
  • fleetdm/fleet#45680: Data-only metadata update for Fleet-maintained apps JSON files, following the same version/patched/installer_url/sha256 edit pattern for app platform outputs.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is extremely minimal and vague, providing only 'Automated ingestion of latest Fleet-maintained app data' without following the required template structure or providing necessary details about the changes. Follow the repository's PR template by adding relevant checklist items (e.g., testing, related issue number) and provide more specific details about what app versions were updated and why.
Title check ❓ Inconclusive The title 'Update Fleet-maintained apps' is broad and partially related to the changeset, which specifically updates NordVPN Windows app metadata to version 8.4.3.0, but does not clearly identify this primary change. Consider a more specific title like 'Update NordVPN Windows app to version 8.4.3.0' to clearly identify the main change while maintaining conciseness.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2606041951

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #46856.

@github-actions github-actions Bot closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants