Skip to content

Update Fleet-maintained apps - #46838

Closed
fleet-release wants to merge 1 commit into
mainfrom
fma-2606041810
Closed

Update Fleet-maintained apps#46838
fleet-release wants to merge 1 commit into
mainfrom
fma-2606041810

Conversation

@fleet-release

@fleet-release fleet-release commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Automated ingestion of latest Fleet-maintained app data.

Summary by CodeRabbit

  • Chores
    • Updated macOS application maintenance metadata: Brave Browser (149.1.91.168), Figma (126.4.12), Granola (7.303.0), and Loom (0.352.4). Each version update includes new installer download URLs and refreshed SHA256 checksums for integrity verification. Updates ensure accurate deployment, proper version detection, and integrity checking across all applications while maintaining existing deployment script configurations.

Generated automatically with cmd/maintained-apps.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR updates version metadata for four Fleet-managed macOS applications. Each maintained app's darwin.json file is updated to reflect a new release: Brave Browser (149.1.91.168), Figma (126.4.12), Granola (7.303.0), and Loom (0.352.4). For each app, the update synchronizes the version field, the queries.patched version comparison threshold, the installer_url to the new release artifact, and the sha256 checksum for integrity verification. Script references remain unchanged.

Possibly related PRs

  • fleetdm/fleet#46492: Both PRs perform the same kind of Fleet maintained-app metadata bump for ee/maintained-apps/outputs/loom/darwin.json (updating version, queries.patched's version_compare, installer_url, and sha256).
  • fleetdm/fleet#46418: Both PRs update Fleet-maintained macOS app manifest data by bumping versions and the corresponding queries.patched version_compare, installer_url, and sha256—in particular ee/maintained-apps/outputs/figma/darwin.json is modified in both.
  • fleetdm/fleet#46307: Both PRs update version-metadata fields in ee/maintained-apps/outputs/granola/darwin.json (including the queries.patched threshold, installer_url, and sha256), so the changes overlap at the same JSON entry level.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description 'Automated ingestion of latest Fleet-maintained app data' is vague and generic. It does not detail which apps were updated, what versions they target, or follow the repository's PR description template. Expand the description to specify which apps were updated (Brave, Figma, Granola, Loom) and provide version details. Consider whether the PR template requirements apply and complete any relevant checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update Fleet-maintained apps' accurately describes the main change—updating version information for multiple Fleet-maintained applications across macOS configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fma-2606041810

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
ee/maintained-apps/outputs/brave-browser/darwin.json (1)

4-12: ⚡ Quick win

Brave installer_url points to the correct artifact (despite version/path mismatch)

  • The installer_url (.../stable-arm64/191.168/Brave-Browser-arm64.dmg) returns HTTP 200.
  • Downloaded dmg SHA256 matches the manifest’s sha256 (7b85fd3d16837c205f7e26631e0f8c5cd921bcbd0f9a2632fd90c6b52b14648c).

The 191.168 path segment doesn’t literally match the full version (149.1.91.168), but the checksum indicates the URL is correct; consider documenting/aligning the version-to-CDN-path mapping to prevent future confusion.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/brave-browser/darwin.json` around lines 4 - 12,
The manifest's installer_url path segment (installer_url) doesn't verbatim match
the manifest version (version) which causes confusion; update the JSON to either
(a) add a short explanatory field (e.g., "cdn_path_note" or "path_mapping")
documenting how the CDN path segment (191.168) is derived from the full version
(149.1.91.168), or (b) normalize/build installer_url from the version field so
they align, and keep the sha256 and queries entries unchanged; reference the
keys installer_url, version, and sha256 when making the change so the mapping is
explicit for future maintainers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@ee/maintained-apps/outputs/brave-browser/darwin.json`:
- Around line 4-12: The manifest's installer_url path segment (installer_url)
doesn't verbatim match the manifest version (version) which causes confusion;
update the JSON to either (a) add a short explanatory field (e.g.,
"cdn_path_note" or "path_mapping") documenting how the CDN path segment
(191.168) is derived from the full version (149.1.91.168), or (b)
normalize/build installer_url from the version field so they align, and keep the
sha256 and queries entries unchanged; reference the keys installer_url, version,
and sha256 when making the change so the mapping is explicit for future
maintainers.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5949b88a-41d7-46ac-89d7-353a410e64a0

📥 Commits

Reviewing files that changed from the base of the PR and between 07df7c5 and 7ef7091.

📒 Files selected for processing (4)
  • ee/maintained-apps/outputs/brave-browser/darwin.json
  • ee/maintained-apps/outputs/figma/darwin.json
  • ee/maintained-apps/outputs/granola/darwin.json
  • ee/maintained-apps/outputs/loom/darwin.json

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of #46841.

@github-actions github-actions Bot closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants