Update Fleet-maintained apps - #46838
Conversation
Generated automatically with cmd/maintained-apps.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
WalkthroughThis PR updates version metadata for four Fleet-managed macOS applications. Each maintained app's Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ee/maintained-apps/outputs/brave-browser/darwin.json (1)
4-12: ⚡ Quick winBrave
installer_urlpoints to the correct artifact (despite version/path mismatch)
- The
installer_url(.../stable-arm64/191.168/Brave-Browser-arm64.dmg) returns HTTP 200.- Downloaded dmg SHA256 matches the manifest’s
sha256(7b85fd3d16837c205f7e26631e0f8c5cd921bcbd0f9a2632fd90c6b52b14648c).The
191.168path segment doesn’t literally match the fullversion(149.1.91.168), but the checksum indicates the URL is correct; consider documenting/aligning the version-to-CDN-path mapping to prevent future confusion.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ee/maintained-apps/outputs/brave-browser/darwin.json` around lines 4 - 12, The manifest's installer_url path segment (installer_url) doesn't verbatim match the manifest version (version) which causes confusion; update the JSON to either (a) add a short explanatory field (e.g., "cdn_path_note" or "path_mapping") documenting how the CDN path segment (191.168) is derived from the full version (149.1.91.168), or (b) normalize/build installer_url from the version field so they align, and keep the sha256 and queries entries unchanged; reference the keys installer_url, version, and sha256 when making the change so the mapping is explicit for future maintainers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ee/maintained-apps/outputs/brave-browser/darwin.json`:
- Around line 4-12: The manifest's installer_url path segment (installer_url)
doesn't verbatim match the manifest version (version) which causes confusion;
update the JSON to either (a) add a short explanatory field (e.g.,
"cdn_path_note" or "path_mapping") documenting how the CDN path segment
(191.168) is derived from the full version (149.1.91.168), or (b)
normalize/build installer_url from the version field so they align, and keep the
sha256 and queries entries unchanged; reference the keys installer_url, version,
and sha256 when making the change so the mapping is explicit for future
maintainers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5949b88a-41d7-46ac-89d7-353a410e64a0
📒 Files selected for processing (4)
ee/maintained-apps/outputs/brave-browser/darwin.jsonee/maintained-apps/outputs/figma/darwin.jsonee/maintained-apps/outputs/granola/darwin.jsonee/maintained-apps/outputs/loom/darwin.json
|
Closing in favor of #46841. |
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit