Fleet UI: Add dynamic categories to edit software modal - #46601
Merged
RachelElysia merged 1 commit intoJun 2, 2026
Merged
Conversation
- Replace hardcoded category list in CategoriesSelector with a useQuery fetch against the self-service categories API for the current fleet. - Add empty state with an "Add category" link to /software/library/categories when the fleet has no categories. - Render DataError when the categories fetch fails (retry: false so users see the error fast instead of waiting through 4 retries). - Handle "some or all of the categories provided" BE error on edit save. - Cap the categories list at 210px max-height with inner scroll so the last row peeks; apply the same 210px to TargetLabelSelector's checkbox list per Figma dev note. - Static fallback path (no teamId passed) preserves the existing hardcoded list for VPP/Android/FMA forms until they're wired up separately.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/39018-self-service-categories #46601 +/- ##
=====================================================================
Coverage ? 66.86%
=====================================================================
Files ? 2810
Lines ? 223765
Branches ? 11534
=====================================================================
Hits ? 149618
Misses ? 60592
Partials ? 13555
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RachelElysia
marked this pull request as ready for review
June 1, 2026 21:05
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
cdcme
approved these changes
Jun 1, 2026
RachelElysia
merged commit Jun 2, 2026
9f6f80d
into
feat/39018-self-service-categories
17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Part of #39018
Closes #46371
Description
Screen recording
Screen.Recording.2026-06-01.at.4.53.01.PM.mov
Testing