Windows FMA - TextExpander

[harrisonravazzolo]

Summary by CodeRabbit

• New Features

  • Added TextExpander as a supported Windows app with automated MSI-based installation, uninstallation, and upgrade handling.
  • Added Windows-specific deployment metadata and detection to enable reliable install/upgrade workflows.

• Bug Fixes

  • Fixed punctuation in the existing TextExpander description for macOS.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8b6eb491-8514-4fc8-92fe-620f3d32f00d

📥 Commits

Reviewing files that changed from the base of the PR and between 4544a41 and c9f94b2.

📒 Files selected for processing (1)

• ee/maintained-apps/outputs/apps.json

🚧 Files skipped from review as they are similar to previous changes (1)

• ee/maintained-apps/outputs/apps.json

---

Walkthrough

This pull request adds TextExpander as a new maintained application in Fleet's application catalog. The change introduces a Winget input manifest defining the package metadata, registers the application in the centralized apps catalog for Windows, and provides complete installer configuration with version information, detection queries, MSI download URL, and PowerShell scripts for installation and uninstallation procedures.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is completely empty, missing all required sections and context for the change.	Add a comprehensive description including: related issue number, explanation of changes (Windows FMA support for TextExpander), testing performed, and relevant checklist items.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding Windows support for TextExpander in the FMA (Fleet Managed Apps) system.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch win-fma-textexpander

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

ee/maintained-apps/outputs/textexpander/windows.json (1)

16-20: ⚖️ Poor tradeoff

Consider parameterizing the upgrade code in the uninstall script.

The upgrade code {F6F4E16E-F3FD-4CD1-A4E5-587808F9C886} appears in both the version object (Line 16) and hardcoded in the uninstall script (Line 20). While MSI upgrade codes typically don't change, hardcoding creates a maintenance burden if an update is ever needed.

Consider whether the script could reference the upgrade code dynamically, though this may conflict with the current script referencing architecture.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ee/maintained-apps/outputs/textexpander/windows.json` around lines 16 - 20,
The uninstall script hardcodes the upgrade code
"{F6F4E16E-F3FD-4CD1-A4E5-587808F9C886}" (present as the JSON "upgrade_code" and
inside the PowerShell call to $inst.RelatedProducts(...)); change the script to
accept or read a single source of truth (e.g., pass an $upgradeCode parameter or
read the JSON "upgrade_code" field) and use that variable in the call to
$inst.RelatedProducts($upgradeCode) so updates only require one change; ensure
you preserve any existing architecture-specific logic so behavior remains
identical.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ee/maintained-apps/outputs/apps.json`:
- Line 2228: Update the Darwin platform entry's "description" field in the
apps.json entry for TextExpander to correct the grammatical contraction: replace
"let's" with "lets" so the description reads "TextExpander is an application
that lets you create and insert pre-made snippets of text anywhere."; locate the
Darwin entry by its "description" key and apply the string change.
- Line 2235: Update the "description" field for the TextExpander entry to fix
the grammatical error: replace "let's you create and insert pre-made snippets of
text anywhere." with "lets you create and insert pre-made snippets of text
anywhere." so the verb "lets" (no apostrophe) is used; locate the JSON object
for TextExpander and edit its "description" property accordingly.

---

Nitpick comments:
In `@ee/maintained-apps/outputs/textexpander/windows.json`:
- Around line 16-20: The uninstall script hardcodes the upgrade code
"{F6F4E16E-F3FD-4CD1-A4E5-587808F9C886}" (present as the JSON "upgrade_code" and
inside the PowerShell call to $inst.RelatedProducts(...)); change the script to
accept or read a single source of truth (e.g., pass an $upgradeCode parameter or
read the JSON "upgrade_code" field) and use that variable in the call to
$inst.RelatedProducts($upgradeCode) so updates only require one change; ensure
you preserve any existing architecture-specific logic so behavior remains
identical.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f00fc967-93d2-42de-9722-27043b4a2b4d

📥 Commits

Reviewing files that changed from the base of the PR and between 8ef2590 and 4544a41.

📒 Files selected for processing (3)

• ee/maintained-apps/inputs/winget/textexpander.json
• ee/maintained-apps/outputs/apps.json
• ee/maintained-apps/outputs/textexpander/windows.json