Update Fleet-maintained apps - #46417
Closed
fleet-release wants to merge 1 commit into
Closed
Conversation
Generated automatically with cmd/maintained-apps.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Script Diff Resultsee/maintained-apps/outputs/brave-browser/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/claude/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/dialpad/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/dropbox/windows.json=== Install Script (no changes) ===
=== Uninstall // d941db84 -> 9bebe5c6 ===
--- /tmp/old.TrPBRC 2026-05-29 02:28:32.009548766 +0000
+++ /tmp/new.9QfCbm 2026-05-29 02:28:32.009548766 +0000
@@ -1,4 +1,4 @@
-$product_code = '{4FACD0F4-1AE8-5B27-9912-CCF9EFF75582}'
+$product_code = '{7113B28E-75FC-50C6-98DE-854CAD48372B}'
$timeoutSeconds = 300 # 5 minute timeout
# Fleet uninstalls app using product code that's extracted on uploadee/maintained-apps/outputs/figma/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/lastpass/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/microsoft-edge/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/notion-calendar/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/parallels/darwin.json=== Install Script (no changes) ===
=== Uninstall // 9c10ac4b -> 038b4616 ===
--- /tmp/old.aBhcDJ 2026-05-29 02:28:32.201547335 +0000
+++ /tmp/new.p50ng4 2026-05-29 02:28:32.202547328 +0000
@@ -72,6 +72,7 @@
sudo rm -rf '/usr/local/bin/prl_convert'
sudo rm -rf '/usr/local/bin/prl_disk_tool'
sudo rm -rf '/usr/local/bin/prl_perf_ctl'
+sudo rm -rf '/usr/local/bin/prlcopy'
sudo rm -rf '/usr/local/bin/prlcore2dmp'
sudo rm -rf '/usr/local/bin/prlctl'
sudo rm -rf '/usr/local/bin/prlexec'ee/maintained-apps/outputs/tailscale/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/zed/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) === |
Contributor
WalkthroughThis pull request updates the maintained-apps registry with version bumps and installer metadata for eleven applications across Windows and macOS platforms. Windows apps include Brave Browser, Claude, Dialpad, LastPass, and Tailscale, each advancing to newer minor or patch versions. macOS apps include Figma, Microsoft Edge, Notion Calendar, and Zed with similar version-specific metadata changes. Additionally, Dropbox updates its uninstall script reference and MSI product code, and Parallels introduces revised uninstall logic for detecting the console user and removing a broader set of application artifacts. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/parallels/darwin.json`:
- Around line 11-19: The uninstall script uses literal '~' and quoted patterns
so globs never expand (see trash(), LOGGED_IN_USER and the sudo rmdir calls);
change all literal-tilde targets to an expanded
user_home="/Users/$LOGGED_IN_USER" and use that variable in rmdir/remove calls,
and rewrite trash() to accept a pattern, expand leading '~' to
/Users/$LOGGED_IN_USER, enable shell globbing (nullglob) to collect matches into
an array, then iterate over matches and move each resolved file into the user's
.Trash with the timestamp/rand suffix (do not quote the pattern before
expansion); update calls like trash $LOGGED_IN_USER
'~/Library/Containers/com.parallels.desktop*' to rely on the new trash()
behavior so wildcards are actually processed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5da3b83e-304c-4fcb-84b2-4d44c8dfae71
📒 Files selected for processing (11)
ee/maintained-apps/outputs/brave-browser/windows.jsonee/maintained-apps/outputs/claude/windows.jsonee/maintained-apps/outputs/dialpad/windows.jsonee/maintained-apps/outputs/dropbox/windows.jsonee/maintained-apps/outputs/figma/darwin.jsonee/maintained-apps/outputs/lastpass/windows.jsonee/maintained-apps/outputs/microsoft-edge/darwin.jsonee/maintained-apps/outputs/notion-calendar/darwin.jsonee/maintained-apps/outputs/parallels/darwin.jsonee/maintained-apps/outputs/tailscale/windows.jsonee/maintained-apps/outputs/zed/darwin.json
Comment on lines
+11
to
+19
| "uninstall_script_ref": "038b4616", | ||
| "sha256": "417af3750e9e6378a4830303d75ff312461abbf5f49a69b6ba4e8ef76afcc35a", | ||
| "default_categories": [ | ||
| "Productivity" | ||
| ] | ||
| } | ||
| ], | ||
| "refs": { | ||
| "1142d1f5": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nTMPDIR=$(dirname \"$(realpath \"$INSTALLER_PATH\")\")\n# functions\n\nquit_and_track_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local timeout_duration=10\n\n # check if the application is running\n local app_running\n app_running=$(osascript -e \"application id \\\"$bundle_id\\\" is running\" 2>/dev/null)\n if [[ \"$app_running\" != \"true\" ]]; then\n eval \"export $var_name=0\"\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping quitting application ID '$bundle_id'.\"\n eval \"export $var_name=0\"\n return\n fi\n\n # App was running, mark it for relaunch\n eval \"export $var_name=1\"\n echo \"Application '$bundle_id' was running; will relaunch after installation.\"\n\n echo \"Quitting application '$bundle_id'...\"\n\n # try to quit the application within the timeout period\n local quit_success=false\n SECONDS=0\n while (( SECONDS < timeout_duration )); do\n if osascript -e \"tell application id \\\"$bundle_id\\\" to quit\" >/dev/null 2>&1; then\n if ! pgrep -f \"$bundle_id\" >/dev/null 2>&1; then\n echo \"Application '$bundle_id' quit successfully.\"\n quit_success=true\n break\n fi\n fi\n sleep 1\n done\n\n if [[ \"$quit_success\" = false ]]; then\n echo \"Application '$bundle_id' did not quit.\"\n fi\n}\n\n\nrelaunch_application() {\n local bundle_id=\"$1\"\n local var_name=\"APP_WAS_RUNNING_$(echo \"$bundle_id\" | tr '.-' '__')\"\n local was_running\n\n # Check if the app was running before installation\n eval \"was_running=\\$$var_name\"\n if [[ \"$was_running\" != \"1\" ]]; then\n return\n fi\n\n local console_user\n console_user=$(stat -f \"%Su\" /dev/console)\n if [[ -z \"$console_user\" || \"$console_user\" == \"root\" || \"$console_user\" == \"loginwindow\" ]]; then\n echo \"Not logged into a non-root GUI; skipping relaunching application ID '$bundle_id'.\"\n return\n fi\n\n echo \"Relaunching application '$bundle_id'...\"\n\n # Launch the app in the logged-in user's GUI session. Apps launched by root\n # won't register with the user's Dock/GUI, so run 'open' as the console user.\n # Use 'launchctl asuser' to bootstrap into the console user's Mach namespace\n # and GUI session — 'sudo -u' alone doesn't do this, which can cause\n # LSOpenURLsWithRole() failures even when 'open' exits 0.\n local open_status=0\n if [[ $EUID -eq 0 ]]; then\n local console_uid\n console_uid=$(id -u \"$console_user\")\n /bin/launchctl asuser \"$console_uid\" sudo -u \"$console_user\" open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n else\n open -b \"$bundle_id\" >/dev/null 2>&1 || open_status=$?\n fi\n\n if [[ $open_status -eq 0 ]]; then\n echo \"Application '$bundle_id' relaunched successfully.\"\n else\n echo \"Failed to relaunch application '$bundle_id'.\"\n fi\n}\n\n\n# extract contents\nMOUNT_POINT=$(mktemp -d /tmp/dmg_mount_XXXXXX)\nhdiutil attach -plist -nobrowse -readonly -mountpoint \"$MOUNT_POINT\" \"$INSTALLER_PATH\"\nsudo cp -R \"$MOUNT_POINT\"/* \"$TMPDIR\"\nhdiutil detach \"$MOUNT_POINT\"\n# copy to the applications folder\nquit_and_track_application 'com.parallels.desktop.console'\nif [ -d \"$APPDIR/Parallels Desktop.app\" ]; then\n\tsudo mv \"$APPDIR/Parallels Desktop.app\" \"$TMPDIR/Parallels Desktop.app.bkp\"\nfi\nsudo cp -R \"$TMPDIR/Parallels Desktop.app\" \"$APPDIR\"\nrelaunch_application 'com.parallels.desktop.console'\n", | ||
| "9c10ac4b": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\nsend_signal() {\n local signal=\"$1\"\n local bundle_id=\"$2\"\n local logged_in_user=\"$3\"\n local logged_in_uid pids\n\n if [ -z \"$signal\" ] || [ -z \"$bundle_id\" ] || [ -z \"$logged_in_user\" ]; then\n echo \"Usage: uninstall_signal <signal> <bundle_id> <logged_in_user>\"\n return 1\n fi\n\n logged_in_uid=$(id -u \"$logged_in_user\")\n if [ -z \"$logged_in_uid\" ]; then\n echo \"Could not find UID for user '$logged_in_user'.\"\n return 1\n fi\n\n echo \"Signalling '$signal' to application ID '$bundle_id' for user '$logged_in_user'\"\n\n pids=$(/bin/launchctl asuser \"$logged_in_uid\" sudo -iu \"$logged_in_user\" /bin/launchctl list | awk -v bundle_id=\"$bundle_id\" '\n $3 ~ bundle_id { print $1 }')\n\n if [ -z \"$pids\" ]; then\n echo \"No processes found for bundle ID '$bundle_id'.\"\n return 0\n fi\n\n echo \"Unix PIDs are $pids for processes with bundle identifier $bundle_id\"\n for pid in $pids; do\n if kill -s \"$signal\" \"$pid\" 2>/dev/null; then\n echo \"Successfully signaled PID $pid with signal $signal.\"\n else\n echo \"Failed to kill PID $pid with signal $signal. Check permissions.\"\n fi\n done\n\n sleep 3\n}\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsend_signal 'TERM' 'com.parallels.desktop.console' \"$LOGGED_IN_USER\"\n(cd /Users/$LOGGED_IN_USER && '/usr/bin/pkill' '-TERM' 'prl_client_app') || true\nsudo rm -rf '/Library/Preferences/Parallels'\nsudo rm -rf '/usr/local/bin/prl_convert'\nsudo rm -rf '/usr/local/bin/prl_disk_tool'\nsudo rm -rf '/usr/local/bin/prl_perf_ctl'\nsudo rm -rf '/usr/local/bin/prlcore2dmp'\nsudo rm -rf '/usr/local/bin/prlctl'\nsudo rm -rf '/usr/local/bin/prlexec'\nsudo rm -rf '/usr/local/bin/prlsrvctl'\nsudo rm -rf \"$APPDIR/Parallels Desktop.app\"\nsudo rmdir '/Users/Shared/Parallels'\nsudo rmdir '~/Library/Caches/Parallels Software'\nsudo rmdir '~/Library/Parallels'\nsudo rmdir '~/Parallels'\ntrash $LOGGED_IN_USER '~/.parallels_settings'\ntrash $LOGGED_IN_USER '~/Applications (Parallels)'\ntrash $LOGGED_IN_USER '~/Library/Application Scripts/*.com.parallels.Desktop'\ntrash $LOGGED_IN_USER '~/Library/Application Scripts/com.parallels.desktop*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/com.parallels.desktop.console.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Caches/com.apple.helpd/Generated/com.parallels.desktop.console.help*'\ntrash $LOGGED_IN_USER '~/Library/Caches/com.parallels.desktop.console'\ntrash $LOGGED_IN_USER '~/Library/Caches/Parallels Software/Parallels Desktop'\ntrash $LOGGED_IN_USER '~/Library/Containers/com.parallels.desktop*'\ntrash $LOGGED_IN_USER '~/Library/Group Containers/*.com.parallels.Desktop'\ntrash $LOGGED_IN_USER '~/Library/Logs/parallels.log'\ntrash $LOGGED_IN_USER '~/Library/Parallels/Applications Menus'\ntrash $LOGGED_IN_USER '~/Library/Parallels/Downloads'\ntrash $LOGGED_IN_USER '~/Library/Parallels/Parallels Desktop'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.desktop.console.LSSharedFileList.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.desktop.console.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.Parallels Desktop Events.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.Parallels Desktop Statistics.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.Parallels Desktop.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.Parallels.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.PDInfo.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/Parallels'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/com.parallels.desktop.console.savedState'\n" | ||
| "038b4616": "#!/bin/bash\n\n# variables\nAPPDIR=\"/Applications/\"\nLOGGED_IN_USER=$(scutil <<< \"show State:/Users/ConsoleUser\" | awk '/Name :/ { print $3 }')\n# functions\n\nsend_signal() {\n local signal=\"$1\"\n local bundle_id=\"$2\"\n local logged_in_user=\"$3\"\n local logged_in_uid pids\n\n if [ -z \"$signal\" ] || [ -z \"$bundle_id\" ] || [ -z \"$logged_in_user\" ]; then\n echo \"Usage: uninstall_signal <signal> <bundle_id> <logged_in_user>\"\n return 1\n fi\n\n logged_in_uid=$(id -u \"$logged_in_user\")\n if [ -z \"$logged_in_uid\" ]; then\n echo \"Could not find UID for user '$logged_in_user'.\"\n return 1\n fi\n\n echo \"Signalling '$signal' to application ID '$bundle_id' for user '$logged_in_user'\"\n\n pids=$(/bin/launchctl asuser \"$logged_in_uid\" sudo -iu \"$logged_in_user\" /bin/launchctl list | awk -v bundle_id=\"$bundle_id\" '\n $3 ~ bundle_id { print $1 }')\n\n if [ -z \"$pids\" ]; then\n echo \"No processes found for bundle ID '$bundle_id'.\"\n return 0\n fi\n\n echo \"Unix PIDs are $pids for processes with bundle identifier $bundle_id\"\n for pid in $pids; do\n if kill -s \"$signal\" \"$pid\" 2>/dev/null; then\n echo \"Successfully signaled PID $pid with signal $signal.\"\n else\n echo \"Failed to kill PID $pid with signal $signal. Check permissions.\"\n fi\n done\n\n sleep 3\n}\n\ntrash() {\n local logged_in_user=\"$1\"\n local target_file=\"$2\"\n local timestamp=\"$(date +%Y-%m-%d-%s)\"\n local rand=\"$(jot -r 1 0 99999)\"\n\n # replace ~ with /Users/$logged_in_user\n if [[ \"$target_file\" == ~* ]]; then\n target_file=\"/Users/$logged_in_user${target_file:1}\"\n fi\n\n local trash=\"/Users/$logged_in_user/.Trash\"\n local file_name=\"$(basename \"${target_file}\")\"\n\n if [[ -e \"$target_file\" ]]; then\n echo \"removing $target_file.\"\n mv -f \"$target_file\" \"$trash/${file_name}_${timestamp}_${rand}\"\n else\n echo \"$target_file doesn't exist.\"\n fi\n}\n\nsend_signal 'TERM' 'com.parallels.desktop.console' \"$LOGGED_IN_USER\"\n(cd /Users/$LOGGED_IN_USER && '/usr/bin/pkill' '-TERM' 'prl_client_app') || true\nsudo rm -rf '/Library/Preferences/Parallels'\nsudo rm -rf '/usr/local/bin/prl_convert'\nsudo rm -rf '/usr/local/bin/prl_disk_tool'\nsudo rm -rf '/usr/local/bin/prl_perf_ctl'\nsudo rm -rf '/usr/local/bin/prlcopy'\nsudo rm -rf '/usr/local/bin/prlcore2dmp'\nsudo rm -rf '/usr/local/bin/prlctl'\nsudo rm -rf '/usr/local/bin/prlexec'\nsudo rm -rf '/usr/local/bin/prlsrvctl'\nsudo rm -rf \"$APPDIR/Parallels Desktop.app\"\nsudo rmdir '/Users/Shared/Parallels'\nsudo rmdir '~/Library/Caches/Parallels Software'\nsudo rmdir '~/Library/Parallels'\nsudo rmdir '~/Parallels'\ntrash $LOGGED_IN_USER '~/.parallels_settings'\ntrash $LOGGED_IN_USER '~/Applications (Parallels)'\ntrash $LOGGED_IN_USER '~/Library/Application Scripts/*.com.parallels.Desktop'\ntrash $LOGGED_IN_USER '~/Library/Application Scripts/com.parallels.desktop*'\ntrash $LOGGED_IN_USER '~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/com.parallels.desktop.console.sfl*'\ntrash $LOGGED_IN_USER '~/Library/Caches/com.apple.helpd/Generated/com.parallels.desktop.console.help*'\ntrash $LOGGED_IN_USER '~/Library/Caches/com.parallels.desktop.console'\ntrash $LOGGED_IN_USER '~/Library/Caches/Parallels Software/Parallels Desktop'\ntrash $LOGGED_IN_USER '~/Library/Containers/com.parallels.desktop*'\ntrash $LOGGED_IN_USER '~/Library/Group Containers/*.com.parallels.Desktop'\ntrash $LOGGED_IN_USER '~/Library/Logs/parallels.log'\ntrash $LOGGED_IN_USER '~/Library/Parallels/Applications Menus'\ntrash $LOGGED_IN_USER '~/Library/Parallels/Downloads'\ntrash $LOGGED_IN_USER '~/Library/Parallels/Parallels Desktop'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.desktop.console.LSSharedFileList.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.desktop.console.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.Parallels Desktop Events.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.Parallels Desktop Statistics.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.Parallels Desktop.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.Parallels.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/com.parallels.PDInfo.plist'\ntrash $LOGGED_IN_USER '~/Library/Preferences/Parallels'\ntrash $LOGGED_IN_USER '~/Library/Saved Application State/com.parallels.desktop.console.savedState'\n", |
Contributor
There was a problem hiding this comment.
Several new cleanup targets never resolve to real user paths.
The new uninstall script mixes literal ~ paths (sudo rmdir '~/Library/Parallels') with a trash() helper that always quotes $target_file, so the wildcard entries like ~/Library/Application Scripts/*.com.parallels.Desktop are never expanded either. As written, a big chunk of the newly added user-data cleanup is skipped.
Possible fix
user_home="/Users/$LOGGED_IN_USER"
sudo rmdir "$user_home/Library/Caches/Parallels Software" 2>/dev/null || true
sudo rmdir "$user_home/Library/Parallels" 2>/dev/null || true
sudo rmdir "$user_home/Parallels" 2>/dev/null || true
trash() {
local logged_in_user="$1"
local pattern="$2"
local timestamp="$(date +%Y-%m-%d-%s)"
local rand="$(jot -r 1 0 99999)"
local trash_dir="/Users/$logged_in_user/.Trash"
[[ "$pattern" == ~* ]] && pattern="/Users/$logged_in_user${pattern:1}"
shopt -s nullglob
local matches=( $pattern )
shopt -u nullglob
for target_file in "${matches[@]}"; do
local file_name
file_name="$(basename "$target_file")"
mv -f "$target_file" "$trash_dir/${file_name}_${timestamp}_${rand}"
done
}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/parallels/darwin.json` around lines 11 - 19, The
uninstall script uses literal '~' and quoted patterns so globs never expand (see
trash(), LOGGED_IN_USER and the sudo rmdir calls); change all literal-tilde
targets to an expanded user_home="/Users/$LOGGED_IN_USER" and use that variable
in rmdir/remove calls, and rewrite trash() to accept a pattern, expand leading
'~' to /Users/$LOGGED_IN_USER, enable shell globbing (nullglob) to collect
matches into an array, then iterate over matches and move each resolved file
into the user's .Trash with the timestamp/rand suffix (do not quote the pattern
before expansion); update calls like trash $LOGGED_IN_USER
'~/Library/Containers/com.parallels.desktop*' to rely on the new trash()
behavior so wildcards are actually processed.
Contributor
|
Closing in favor of #46418. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit